)]}'
{"nova/api/openstack/compute/plugins/v3/remote_consoles.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1587fca3e5060dda8037c8a89519eee3d6e73426","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        try:"},{"line_number":47,"context_line":"            instance \u003d common.get_instance(self.compute_api, context, id,"},{"line_number":48,"context_line":"                                           want_objects\u003dTrue)"},{"line_number":49,"context_line":"            authorize(context, target\u003dinstance)"},{"line_number":50,"context_line":"            output \u003d self.compute_api.get_vnc_console(context,"},{"line_number":51,"context_line":"                                                      instance,"},{"line_number":52,"context_line":"                                                      console_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_5a584f32","line":49,"updated":"2015-01-29 07:02:54.000000000","message":"We don\u0027t need to pass target to authrize() now, please see the comment on https://review.openstack.org/#/c/143393/","commit_id":"0a67b0ffc573355a2e04cba1ed8ab8bf9985ec20"}],"nova/tests/unit/api/openstack/compute/contrib/test_consoles.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4cdc9eafff70d42901a5580f577bb2d4470c9092","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self._call_server_controller_method(controller.get_vnc_console, \u0027\u0027)"},{"line_number":474,"context_line":"        self._call_server_controller_method(controller.get_spice_console, \u0027\u0027)"},{"line_number":475,"context_line":"        self._call_server_controller_method(controller.get_rdp_console, \u0027\u0027)"},{"line_number":476,"context_line":"        self._call_server_controller_method(controller.get_serial_console, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_61db594f","line":476,"updated":"2015-01-26 14:01:49.000000000","message":"I know the purpose here\n\nbut personal opinion is to split them since they are different function are we are testing different code branch","commit_id":"0a67b0ffc573355a2e04cba1ed8ab8bf9985ec20"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b6600cc71819c15dee65aeaaa077efd52d1c3b02","unresolved":false,"context_lines":[{"line_number":451,"context_line":"    def test_remote_vnc_console_policy_failed(self):"},{"line_number":452,"context_line":"        rule_name \u003d \"compute_extension:v3:os-remote-consoles\""},{"line_number":453,"context_line":"        self.policy.set_rules({rule_name: \"project:non_fake\"})"},{"line_number":454,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":455,"context_line":"        body \u003d {\u0027os-getVNCConsole\u0027: {\u0027type\u0027: \u0027novnc\u0027}}"},{"line_number":456,"context_line":"        exc \u003d self.assertRaises("},{"line_number":457,"context_line":"            exception.PolicyNotAuthorized,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_58fffb33","line":454,"updated":"2015-02-12 13:19:04.000000000","message":"we can move this into setUp()","commit_id":"e046d38b62a4dc5a436584f9bba153c22ef3e7f3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c0e46c80df23bd1ad48c4ec1f979ff2f923280ae","unresolved":false,"context_lines":[{"line_number":451,"context_line":"    def test_remote_vnc_console_policy_failed(self):"},{"line_number":452,"context_line":"        rule_name \u003d \"compute_extension:v3:os-remote-consoles\""},{"line_number":453,"context_line":"        self.policy.set_rules({rule_name: \"project:non_fake\"})"},{"line_number":454,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":455,"context_line":"        body \u003d {\u0027os-getVNCConsole\u0027: {\u0027type\u0027: \u0027novnc\u0027}}"},{"line_number":456,"context_line":"        exc \u003d self.assertRaises("},{"line_number":457,"context_line":"            exception.PolicyNotAuthorized,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_46999acf","line":454,"in_reply_to":"da86d52c_58fffb33","updated":"2015-02-13 16:45:04.000000000","message":"yes, agree","commit_id":"e046d38b62a4dc5a436584f9bba153c22ef3e7f3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c0e46c80df23bd1ad48c4ec1f979ff2f923280ae","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            body\u003dbody)"},{"line_number":499,"context_line":"        self.assertEqual("},{"line_number":500,"context_line":"            \"Policy doesn\u0027t allow %s to be performed.\" % rule_name,"},{"line_number":501,"context_line":"            exc.format_message())"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_867ab275","line":501,"updated":"2015-02-13 16:45:04.000000000","message":"can we generalize the code? \n\ne.g \n\n_test_console_policy_failed()\nxxx\n\n\nthen for each console\nadd body and function as param\nthen ew don\u0027t need to have some many code and \neasy to extend","commit_id":"e046d38b62a4dc5a436584f9bba153c22ef3e7f3"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"a8b846cacf4848b85d8c5c1e5958e907c913c268","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            body\u003dbody)"},{"line_number":499,"context_line":"        self.assertEqual("},{"line_number":500,"context_line":"            \"Policy doesn\u0027t allow %s to be performed.\" % rule_name,"},{"line_number":501,"context_line":"            exc.format_message())"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_1bebe813","line":501,"in_reply_to":"da86d52c_867ab275","updated":"2015-02-25 05:04:23.000000000","message":"agree.\n\nall rule_name are same in these 4 test cases.\nIt can also be moved to this _test_console_policy_failed().","commit_id":"e046d38b62a4dc5a436584f9bba153c22ef3e7f3"}]}