)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"61f7d1847968c55bda0e6989f04205b83d1de1f9","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"                                      RESIZE_REVERTING)"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"            self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1575,"context_line":"                                                     migration_ref)"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"            self.db.migration_update(elevated, migration_id,"},{"line_number":1578,"context_line":"                    {\u0027status\u0027: \u0027reverted\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F5gI%3D","line":1575,"updated":"2012-10-29 22:56:31.000000000","message":"why move after update?","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"acb4b54de6c43a41ef8834c9a4dac5ee7150f2d0","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"                                      RESIZE_REVERTING)"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"            self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1575,"context_line":"                                                     migration_ref)"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"            self.db.migration_update(elevated, migration_id,"},{"line_number":1578,"context_line":"                    {\u0027status\u0027: \u0027reverted\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F5fo%3D","line":1575,"in_reply_to":"AAAALn%2F%2F5gI%3D","updated":"2012-10-29 23:03:15.000000000","message":"The move is because the rxtx_factor is extracted from the instance_type, which isn\u0027t updated until here.  We need the new rxtx_factor…","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"bfe4f77a2acc791cc56d97aeaeb65447ef5c9eb9","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                                             RESIZE_FINISH)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1767,"context_line":"                                                 migration)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"        self.db.migration_update(context.elevated(), migration[\u0027id\u0027],"},{"line_number":1770,"context_line":"                                 {\u0027status\u0027: \u0027finished\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F5VM%3D","line":1767,"updated":"2012-10-30 03:37:01.000000000","message":"I think call self.network_api.migrate_instance_finish after\n   _instance_update(task_state\u003dNone) may lead to race conditions.","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"61f7d1847968c55bda0e6989f04205b83d1de1f9","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                                             RESIZE_FINISH)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1767,"context_line":"                                                 migration)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"        self.db.migration_update(context.elevated(), migration[\u0027id\u0027],"},{"line_number":1770,"context_line":"                                 {\u0027status\u0027: \u0027finished\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F5gM%3D","line":1767,"updated":"2012-10-29 22:56:31.000000000","message":"I\u0027m concerned about moving where this happens. Can you comment on your reasoning to do this after the instance_update?","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b5fc32f80d7c7d6b46f7948881eb73cac1bdf27d","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                                             RESIZE_FINISH)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1767,"context_line":"                                                 migration)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"        self.db.migration_update(context.elevated(), migration[\u0027id\u0027],"},{"line_number":1770,"context_line":"                                 {\u0027status\u0027: \u0027finished\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F4o8%3D","line":1767,"in_reply_to":"AAAALn%2F%2F4%2FY%3D","updated":"2012-10-30 17:48:38.000000000","message":"OK, I was under the impression (based on what was happening in finish_resize()) that instance_type_id was not updated until after this _instance_update() call, but now I see that it happens during the previous _instance_update() that this migrate_instance_finish() call was originally after.  I\u0027m reverting the ordering on this one, but I still wonder about the racing…","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"8f80f223fb8c57a91f902041fa3d799f9e223984","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                                             RESIZE_FINISH)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1767,"context_line":"                                                 migration)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"        self.db.migration_update(context.elevated(), migration[\u0027id\u0027],"},{"line_number":1770,"context_line":"                                 {\u0027status\u0027: \u0027finished\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F4Nw%3D","line":1767,"in_reply_to":"AAAALn%2F%2F4%2FY%3D","updated":"2012-10-31 03:27:01.000000000","message":"Sorry, I am wrong.\nI forget check_instance_state checks vm_state,too.","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"990cac08f79985735458c643accf52ff6cae9817","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                                             RESIZE_FINISH)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1767,"context_line":"                                                 migration)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"        self.db.migration_update(context.elevated(), migration[\u0027id\u0027],"},{"line_number":1770,"context_line":"                                 {\u0027status\u0027: \u0027finished\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F4%2FY%3D","line":1767,"in_reply_to":"AAAALn%2F%2F5VM%3D","updated":"2012-10-30 15:01:05.000000000","message":"Can you be more specific?  What will be racing against what?","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"acb4b54de6c43a41ef8834c9a4dac5ee7150f2d0","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"                                             RESIZE_FINISH)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1767,"context_line":"                                                 migration)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"        self.db.migration_update(context.elevated(), migration[\u0027id\u0027],"},{"line_number":1770,"context_line":"                                 {\u0027status\u0027: \u0027finished\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F5fk%3D","line":1767,"in_reply_to":"AAAALn%2F%2F5gM%3D","updated":"2012-10-29 23:03:15.000000000","message":"As before, we\u0027re trying to get the rxtx_factor from the instance_type set on the instance, and that\u0027s not updated until here.","commit_id":"c05d06fd2e53b4c3c14c365becb534545569e169"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d5f06ad96a30586e64f63c27d46be96d4cf99ed8","unresolved":false,"context_lines":[{"line_number":1571,"context_line":"                                  expected_task_state\u003dtask_states."},{"line_number":1572,"context_line":"                                      RESIZE_REVERTING)"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"            self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1575,"context_line":"                                                     migration_ref)"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"            self.db.migration_update(elevated, migration_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F4JA%3D","line":1574,"updated":"2012-10-31 06:08:40.000000000","message":"So there\u0027s no race with someone doing another migrate in between the above 2 lines? Once task_state is None, you can migrate again..","commit_id":"a1a6f194a48ee846a2c38fda5f79c1e18c0fe0e8"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"bf0c1a3ffe0aad258ac5819502132e5c21dc0e5d","unresolved":false,"context_lines":[{"line_number":1571,"context_line":"                                  expected_task_state\u003dtask_states."},{"line_number":1572,"context_line":"                                      RESIZE_REVERTING)"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"            self.network_api.migrate_instance_finish(context, instance,"},{"line_number":1575,"context_line":"                                                     migration_ref)"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"            self.db.migration_update(elevated, migration_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2F4HQ%3D","line":1574,"in_reply_to":"AAAALn%2F%2F4JA%3D","updated":"2012-10-31 06:43:57.000000000","message":"No, there is. We should update(vm_state\u003dvm_states.ACTIVE, task_state\u003dNone) after self.network_api.migrate_instance_finish","commit_id":"a1a6f194a48ee846a2c38fda5f79c1e18c0fe0e8"}]}