)]}'
{"nova/rootwrap/filters.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"66a7d8ede75a9d376c708603d4121441e9a33077","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if userargs[0] \u003d\u003d \u0027env\u0027:"},{"line_number":77,"context_line":"            for arg in userargs[1:]:"},{"line_number":78,"context_line":"                if \u0027\u003d\u0027 in arg:"},{"line_number":79,"context_line":"                    continue"},{"line_number":80,"context_line":"                if arg \u003d\u003d \u0027dnsmasq\u0027:"},{"line_number":81,"context_line":"                    return True"},{"line_number":82,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F4RM%3D","line":79,"updated":"2012-10-31 00:49:15.000000000","message":"This is too lax. Consider\n    env /tmp/my\u003dcommand\nAlso allowing any env var is dangerous.\ndnsmasq executes programs itself so allowing this is dangerous.\n    env PATH\u003d/tmp/mypath dnsmasq ...","commit_id":"e2df035a72d115037b7bb046874372b9f49e136e"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"66a7d8ede75a9d376c708603d4121441e9a33077","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                    return True"},{"line_number":82,"context_line":"                else:"},{"line_number":83,"context_line":"                    break"},{"line_number":84,"context_line":"            return True"},{"line_number":85,"context_line":"        return False"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_command(self, userargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F4RE%3D","line":84,"updated":"2012-10-31 00:49:15.000000000","message":"You don\u0027t want this \"return True\" here as it bypasses all checks essentially","commit_id":"e2df035a72d115037b7bb046874372b9f49e136e"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f0a23e743ae38f2adf615df10bd6260e7c8167b5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                    return True"},{"line_number":82,"context_line":"                else:"},{"line_number":83,"context_line":"                    break"},{"line_number":84,"context_line":"            return True"},{"line_number":85,"context_line":"        return False"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_command(self, userargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F4Q0%3D","line":84,"in_reply_to":"AAAALn%2F%2F4RE%3D","updated":"2012-10-31 01:13:13.000000000","message":"Great catch, this one was meant to be deleted.","commit_id":"e2df035a72d115037b7bb046874372b9f49e136e"}]}