)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7c310375302ba8bef2ce9839cfca2cfe14d149","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The \"serial_console\" feature uses a \u003cserial\u003e device"},{"line_number":10,"context_line":"for guests on X86 hosts. System z guests needs a"},{"line_number":11,"context_line":"\u003cconsole\u003e device instead."},{"line_number":12,"context_line":"The host module gets a new convinience function for"},{"line_number":13,"context_line":"querying the cpu arch from its capabilities."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Implements blueprint libvirt-kvm-systemz"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_be350ddd","line":12,"updated":"2015-02-06 20:35:43.000000000","message":"s/convinience/convenience/","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e2b66e36e860ed9265efc29e2fb08b1ce4af4a82","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The \"serial_console\" feature uses a \u003cserial\u003e device"},{"line_number":10,"context_line":"for guests on X86 hosts. System z guests needs a"},{"line_number":11,"context_line":"\u003cconsole\u003e device instead."},{"line_number":12,"context_line":"The host module gets a new convinience function for"},{"line_number":13,"context_line":"querying the cpu arch from its capabilities."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Implements blueprint libvirt-kvm-systemz"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_dc47ff49","line":12,"in_reply_to":"da86d52c_be350ddd","updated":"2015-02-09 13:34:25.000000000","message":"This conveniance method will be removed in the next patch set because the libvirt utils will be used. That means I will update the commit message.","commit_id":"c00887397536056f9675ce16638bed43e620c758"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7c310375302ba8bef2ce9839cfca2cfe14d149","unresolved":false,"context_lines":[{"line_number":2350,"context_line":"    def test_get_serial_ports_from_instance(self, mock_get_domain):"},{"line_number":2351,"context_line":"        i \u003d self._test_get_serial_ports_from_instance(None,"},{"line_number":2352,"context_line":"                                                      mock_get_domain,"},{"line_number":2353,"context_line":"                                                      \u0027serial\u0027)"},{"line_number":2354,"context_line":"        self.assertEqual(["},{"line_number":2355,"context_line":"            (\u0027127.0.0.1\u0027, 100),"},{"line_number":2356,"context_line":"            (\u0027127.0.0.1\u0027, 101),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1ea0d9a4","line":2353,"updated":"2015-02-06 20:35:43.000000000","message":"Make this the default for the new parameter so we don\u0027t have to touch all of these older tests.\n\nI\u0027m -1 for this.","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e2b66e36e860ed9265efc29e2fb08b1ce4af4a82","unresolved":false,"context_lines":[{"line_number":2350,"context_line":"    def test_get_serial_ports_from_instance(self, mock_get_domain):"},{"line_number":2351,"context_line":"        i \u003d self._test_get_serial_ports_from_instance(None,"},{"line_number":2352,"context_line":"                                                      mock_get_domain,"},{"line_number":2353,"context_line":"                                                      \u0027serial\u0027)"},{"line_number":2354,"context_line":"        self.assertEqual(["},{"line_number":2355,"context_line":"            (\u0027127.0.0.1\u0027, 100),"},{"line_number":2356,"context_line":"            (\u0027127.0.0.1\u0027, 101),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_675125d8","line":2353,"in_reply_to":"da86d52c_1ea0d9a4","updated":"2015-02-09 13:34:25.000000000","message":"Done","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7c310375302ba8bef2ce9839cfca2cfe14d149","unresolved":false,"context_lines":[{"line_number":2391,"context_line":"            (\u0027127.0.0.2\u0027, 101)], list(i))"},{"line_number":2392,"context_line":""},{"line_number":2393,"context_line":"    def _test_get_serial_ports_from_instance(self, mode, mock_get_domain,"},{"line_number":2394,"context_line":"                                             dev_name):"},{"line_number":2395,"context_line":"        xml \u003d \"\"\""},{"line_number":2396,"context_line":"        \u003cdomain type\u003d\u0027kvm\u0027\u003e"},{"line_number":2397,"context_line":"          \u003cdevices\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_5eb3310a","line":2394,"updated":"2015-02-06 20:35:43.000000000","message":"Let\u0027s default this to \u0027serial\u0027 so we don\u0027t have to touch all of the different tests calling into it.","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e2b66e36e860ed9265efc29e2fb08b1ce4af4a82","unresolved":false,"context_lines":[{"line_number":2391,"context_line":"            (\u0027127.0.0.2\u0027, 101)], list(i))"},{"line_number":2392,"context_line":""},{"line_number":2393,"context_line":"    def _test_get_serial_ports_from_instance(self, mode, mock_get_domain,"},{"line_number":2394,"context_line":"                                             dev_name):"},{"line_number":2395,"context_line":"        xml \u003d \"\"\""},{"line_number":2396,"context_line":"        \u003cdomain type\u003d\u0027kvm\u0027\u003e"},{"line_number":2397,"context_line":"          \u003cdevices\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_875d39ef","line":2394,"in_reply_to":"da86d52c_5eb3310a","updated":"2015-02-09 13:34:25.000000000","message":"Done","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7c310375302ba8bef2ce9839cfca2cfe14d149","unresolved":false,"context_lines":[{"line_number":2489,"context_line":"        self.assertEqual(\"s390x\", cfg.cpu.arch)"},{"line_number":2490,"context_line":""},{"line_number":2491,"context_line":"    @mock.patch.object(objects.Flavor, \u0027get_by_id\u0027)"},{"line_number":2492,"context_line":"    def test_get_guest_config_with_type_kvm_on_s390_serial(self, mock_flavor):"},{"line_number":2493,"context_line":"        self.flags(vnc_enabled\u003dFalse)"},{"line_number":2494,"context_line":"        self.flags(enabled\u003dTrue, group\u003d\u0027serial_console\u0027)"},{"line_number":2495,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_be68ad22","line":2492,"updated":"2015-02-06 20:35:43.000000000","message":"Sorry but what makes this different from the previous test case that it\u0027s mostly copied from and slightly changed?  I\u0027m just wondering if we can lump the console check into the exist test?\n\nOtherwise this is OK, but really I\u0027d rather just see a simple unit test that tests the _create_serial_console_devices method since the logic change is really in there, but maybe it\u0027s used later and that\u0027s why we need to check it, idk, just seems like a big clunky test for something that\u0027s in a smaller unit (and hence a smaller test is sufficient).","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e2b66e36e860ed9265efc29e2fb08b1ce4af4a82","unresolved":false,"context_lines":[{"line_number":2489,"context_line":"        self.assertEqual(\"s390x\", cfg.cpu.arch)"},{"line_number":2490,"context_line":""},{"line_number":2491,"context_line":"    @mock.patch.object(objects.Flavor, \u0027get_by_id\u0027)"},{"line_number":2492,"context_line":"    def test_get_guest_config_with_type_kvm_on_s390_serial(self, mock_flavor):"},{"line_number":2493,"context_line":"        self.flags(vnc_enabled\u003dFalse)"},{"line_number":2494,"context_line":"        self.flags(enabled\u003dTrue, group\u003d\u0027serial_console\u0027)"},{"line_number":2495,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_53cf82b0","line":2492,"in_reply_to":"da86d52c_be68ad22","updated":"2015-02-09 13:34:25.000000000","message":"Yes, this test is too big for the IF I want to test.\nThere will be a new `test_create_serial_console_devices`\nwhich will test that.","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d29bfd40a2595175314b8168ed1f8b1bde2037a0","unresolved":false,"context_lines":[{"line_number":2326,"context_line":"                    arch.S390: vconfig.LibvirtConfigGuestConsole,"},{"line_number":2327,"context_line":"                    arch.S390X: vconfig.LibvirtConfigGuestConsole}"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"        for guest_arch, device_type in expected.iteritems():"},{"line_number":2330,"context_line":"            mock_get_arch.return_value \u003d guest_arch"},{"line_number":2331,"context_line":"            guest \u003d vconfig.LibvirtConfigGuest()"},{"line_number":2332,"context_line":"            drvr._create_serial_console_devices(guest, instance\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_010f63e2","line":2329,"updated":"2015-02-09 17:00:00.000000000","message":"iteritems() isn\u0027t in python 3, so either use six.iteritems() or use expected.items().","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"eb0f826560db6e3c0943b6c716c3ef23fefcdaee","unresolved":false,"context_lines":[{"line_number":2326,"context_line":"                    arch.S390: vconfig.LibvirtConfigGuestConsole,"},{"line_number":2327,"context_line":"                    arch.S390X: vconfig.LibvirtConfigGuestConsole}"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"        for guest_arch, device_type in expected.iteritems():"},{"line_number":2330,"context_line":"            mock_get_arch.return_value \u003d guest_arch"},{"line_number":2331,"context_line":"            guest \u003d vconfig.LibvirtConfigGuest()"},{"line_number":2332,"context_line":"            drvr._create_serial_console_devices(guest, instance\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_113414dd","line":2329,"in_reply_to":"da86d52c_010f63e2","updated":"2015-02-09 17:23:13.000000000","message":"Done","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d29bfd40a2595175314b8168ed1f8b1bde2037a0","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"            guest \u003d vconfig.LibvirtConfigGuest()"},{"line_number":2332,"context_line":"            drvr._create_serial_console_devices(guest, instance\u003dNone,"},{"line_number":2333,"context_line":"                                                flavor\u003d{}, image_meta\u003d{})"},{"line_number":2334,"context_line":"            console_device \u003d guest.devices[0]"},{"line_number":2335,"context_line":"            self.assertIsInstance(console_device, device_type)"},{"line_number":2336,"context_line":"            self.assertEqual(\"tcp\", console_device.type)"},{"line_number":2337,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_a1edb7f1","line":2334,"updated":"2015-02-09 17:00:00.000000000","message":"nit: could have an assertIsEqual(1, len(guest.devices)) before this but not a huge deal.","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"eb0f826560db6e3c0943b6c716c3ef23fefcdaee","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"            guest \u003d vconfig.LibvirtConfigGuest()"},{"line_number":2332,"context_line":"            drvr._create_serial_console_devices(guest, instance\u003dNone,"},{"line_number":2333,"context_line":"                                                flavor\u003d{}, image_meta\u003d{})"},{"line_number":2334,"context_line":"            console_device \u003d guest.devices[0]"},{"line_number":2335,"context_line":"            self.assertIsInstance(console_device, device_type)"},{"line_number":2336,"context_line":"            self.assertEqual(\"tcp\", console_device.type)"},{"line_number":2337,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_312f588a","line":2334,"in_reply_to":"da86d52c_a1edb7f1","updated":"2015-02-09 17:23:13.000000000","message":"Done","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7c310375302ba8bef2ce9839cfca2cfe14d149","unresolved":false,"context_lines":[{"line_number":3657,"context_line":"            num_ports \u003d hardware.get_number_of_serial_ports("},{"line_number":3658,"context_line":"                flavor, image_meta)"},{"line_number":3659,"context_line":"            for port in six.moves.range(num_ports):"},{"line_number":3660,"context_line":"                if caps.host.cpu.arch in (arch.S390, arch.S390X):"},{"line_number":3661,"context_line":"                    console \u003d vconfig.LibvirtConfigGuestConsole()"},{"line_number":3662,"context_line":"                else:"},{"line_number":3663,"context_line":"                    console \u003d vconfig.LibvirtConfigGuestSerial()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1e5d39ed","line":3660,"updated":"2015-02-06 20:35:43.000000000","message":"At some point (arch.S390, arch.S390X) should probably just become a constant somewhere since it\u0027s copy/pasted in many places, not just this driver module but also the volume stuff.\n\nTo be clear, I\u0027m not asking for that here in this change, just later once the zKVM stuff is all merged we can do that as a cleanup change.","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e2b66e36e860ed9265efc29e2fb08b1ce4af4a82","unresolved":false,"context_lines":[{"line_number":3657,"context_line":"            num_ports \u003d hardware.get_number_of_serial_ports("},{"line_number":3658,"context_line":"                flavor, image_meta)"},{"line_number":3659,"context_line":"            for port in six.moves.range(num_ports):"},{"line_number":3660,"context_line":"                if caps.host.cpu.arch in (arch.S390, arch.S390X):"},{"line_number":3661,"context_line":"                    console \u003d vconfig.LibvirtConfigGuestConsole()"},{"line_number":3662,"context_line":"                else:"},{"line_number":3663,"context_line":"                    console \u003d vconfig.LibvirtConfigGuestSerial()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_130a6ad2","line":3660,"in_reply_to":"da86d52c_1e5d39ed","updated":"2015-02-09 13:34:25.000000000","message":"Yes, I observed that too. The many IFs for hypervisor and architecture made me think about some kind of \"template method pattern\" approach. Maybe I will make a blueprint for that to discuss it.","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d29bfd40a2595175314b8168ed1f8b1bde2037a0","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        xml \u003d virt_dom.XMLDesc(0)"},{"line_number":850,"context_line":"        tree \u003d etree.fromstring(xml)"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        xpath_mode \u003d \"[@mode\u003d\u0027%s\u0027]\" % mode if mode else \"\""},{"line_number":853,"context_line":"        serial_tcp \u003d \"./devices/serial[@type\u003d\u0027tcp\u0027]/source\" + xpath_mode"},{"line_number":854,"context_line":"        console_tcp \u003d \"./devices/console[@type\u003d\u0027tcp\u0027]/source\" + xpath_mode"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_21aaa7d4","line":852,"updated":"2015-02-09 17:00:00.000000000","message":"A bit confusing at first read but overall a nicer change than patch set 3 since this avoids the arch check.","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"eb0f826560db6e3c0943b6c716c3ef23fefcdaee","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        xml \u003d virt_dom.XMLDesc(0)"},{"line_number":850,"context_line":"        tree \u003d etree.fromstring(xml)"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        xpath_mode \u003d \"[@mode\u003d\u0027%s\u0027]\" % mode if mode else \"\""},{"line_number":853,"context_line":"        serial_tcp \u003d \"./devices/serial[@type\u003d\u0027tcp\u0027]/source\" + xpath_mode"},{"line_number":854,"context_line":"        console_tcp \u003d \"./devices/console[@type\u003d\u0027tcp\u0027]/source\" + xpath_mode"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_11e7b441","line":852,"in_reply_to":"da86d52c_21aaa7d4","updated":"2015-02-09 17:23:13.000000000","message":"Right, I wanted to avoid another \u0027arch\u0027 check. This approach is more open for other platforms.","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d29bfd40a2595175314b8168ed1f8b1bde2037a0","unresolved":false,"context_lines":[{"line_number":3691,"context_line":"            # client app is connected. Thus we can\u0027t get away"},{"line_number":3692,"context_line":"            # with a single type\u003dpty console. Instead we have"},{"line_number":3693,"context_line":"            # to configure two separate consoles."},{"line_number":3694,"context_line":"            if guest_arch in (arch.S390, arch.S390X):"},{"line_number":3695,"context_line":"                consolelog \u003d vconfig.LibvirtConfigGuestConsole()"},{"line_number":3696,"context_line":"                consolelog.target_type \u003d \"sclplm\""},{"line_number":3697,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_e1edef26","line":3694,"updated":"2015-02-09 17:00:00.000000000","message":"Ah we were already using libvirt_utils.get_arch(image_meta) here so yeah, changing to use it above for the arch check is nicer than adding the new host and caps stuff from patch set 3.","commit_id":"289b6cc9934e2c29f5463895505a75ab53eba392"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb7c310375302ba8bef2ce9839cfca2cfe14d149","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if secret is not None:"},{"line_number":719,"context_line":"            secret.undefine()"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def get_arch(self):"},{"line_number":722,"context_line":"        \"\"\"Returns the CPU architecture of the host.\"\"\""},{"line_number":723,"context_line":"        return self.get_capabilities().host.cpu.arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_9ec20985","line":721,"updated":"2015-02-06 20:35:43.000000000","message":"This made me remember another get_arch in libvirt.utils, but it\u0027s getting the arch from the image metadata so not the same:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/utils.py#n542\n\nI\u0027m not sure if the arch in the host caps is every different from the arch in the image_meta though.","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b8f9e266b5bf66e2c55e57332db1a31e6904edc2","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if secret is not None:"},{"line_number":719,"context_line":"            secret.undefine()"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def get_arch(self):"},{"line_number":722,"context_line":"        \"\"\"Returns the CPU architecture of the host.\"\"\""},{"line_number":723,"context_line":"        return self.get_capabilities().host.cpu.arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_9b8f11cc","line":721,"updated":"2015-02-03 16:13:29.000000000","message":"please add tests for this method","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dc169337335632ec513ac2080795b21e62142e74","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if secret is not None:"},{"line_number":719,"context_line":"            secret.undefine()"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def get_arch(self):"},{"line_number":722,"context_line":"        \"\"\"Returns the CPU architecture of the host.\"\"\""},{"line_number":723,"context_line":"        return self.get_capabilities().host.cpu.arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2f6edb2f","line":721,"in_reply_to":"da86d52c_1e0eaf34","updated":"2015-02-03 17:02:20.000000000","message":"Sorry i missed that","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"066be7a32b5cf5dada0559bfb312af24d166bcef","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if secret is not None:"},{"line_number":719,"context_line":"            secret.undefine()"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def get_arch(self):"},{"line_number":722,"context_line":"        \"\"\"Returns the CPU architecture of the host.\"\"\""},{"line_number":723,"context_line":"        return self.get_capabilities().host.cpu.arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1e0eaf34","line":721,"in_reply_to":"da86d52c_9b8f11cc","updated":"2015-02-03 16:15:14.000000000","message":"There is one added in \"test_host.py\". Should that test look differently?","commit_id":"c00887397536056f9675ce16638bed43e620c758"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e2b66e36e860ed9265efc29e2fb08b1ce4af4a82","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if secret is not None:"},{"line_number":719,"context_line":"            secret.undefine()"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def get_arch(self):"},{"line_number":722,"context_line":"        \"\"\"Returns the CPU architecture of the host.\"\"\""},{"line_number":723,"context_line":"        return self.get_capabilities().host.cpu.arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_bc1c0b6c","line":721,"in_reply_to":"da86d52c_9ec20985","updated":"2015-02-09 13:34:25.000000000","message":"The next patch set will use the libvirt utils to query the architecture. The possibility that the image_meta architecture will differ to the host architecture is low but it exists (in case of qemu on s390).\nThis means I will remove this conveniance method.","commit_id":"c00887397536056f9675ce16638bed43e620c758"}]}