)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"c305376fb061efac80707b08cb15a0e9e9d676e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ShaoHe Feng \u003cshaohe.feng@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-01 04:06:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove db layer hard-code permission checks for floating_ip_allocate_address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patches removes db layer hard-code permission checks for"},{"line_number":10,"context_line":"floating_ip_allocate_address."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba7be1f8_3c08f7d8","line":7,"updated":"2015-03-01 19:39:23.000000000","message":"this is for fixed_ip_associate","commit_id":"39a4d959a5213f90c4055a4ac07296d4be0b90ac"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c2ccd9283badfb24f9a012c8d45f328f5f1c4fe8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"fixed_ip_associate_*"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"the follow functions call db fixed_ip_associate_* API"},{"line_number":13,"context_line":"1. allocate_for_instance, contex has been elevated."},{"line_number":14,"context_line":"2. add_fixed_ip_to_instance, it does not need to require admin previlege."},{"line_number":15,"context_line":"   and bug 1432455 was filed for it."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a50d1a3_6dfccc72","line":13,"updated":"2015-07-31 02:45:29.000000000","message":"The entry point is server create","commit_id":"a57fae105452e26684406b59ff6b2128698479e9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c2ccd9283badfb24f9a012c8d45f328f5f1c4fe8","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"the follow functions call db fixed_ip_associate_* API"},{"line_number":13,"context_line":"1. allocate_for_instance, contex has been elevated."},{"line_number":14,"context_line":"2. add_fixed_ip_to_instance, it does not need to require admin previlege."},{"line_number":15,"context_line":"   and bug 1432455 was filed for it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"the follow functions call db fixed_ip_associate_pool API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a50d1a3_4d3b1039","line":14,"updated":"2015-07-31 02:45:29.000000000","message":"The entry point is multinic api","commit_id":"a57fae105452e26684406b59ff6b2128698479e9"}],"nova/api/openstack/compute/contrib/multinic.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5f69c441074e4a3864f3736b308ecde4d9f0fab7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # NOTE(shaohe-feng): back-compatible with db layer hard-code"},{"line_number":48,"context_line":"        # admin permission checks."},{"line_number":49,"context_line":"        if not utils.is_neutron():"},{"line_number":50,"context_line":"            nova_context.require_admin_context(context)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Validate the input entity"},{"line_number":53,"context_line":"        if \u0027networkId\u0027 not in body[\u0027addFixedIp\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_fc1988d1","line":50,"updated":"2015-03-14 08:03:24.000000000","message":"Emm, a little strange. I think this should be allowed to be normal user call. But I have test the code, it only allow to be called by admin user. But let me verify that first.","commit_id":"d6c4462c9a0b5ad664d5a74cc40e5f6e71df9003"}],"nova/tests/unit/api/openstack/compute/contrib/test_multinic.py":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"aefb4118ac40df528aa2a7986116124bcf49ba7b","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def test_add_fixed_ip_with_non_admin(self):"},{"line_number":172,"context_line":"        body \u003d dict(addFixedIp\u003ddict(networkId\u003d\u0027test_net\u0027))"},{"line_number":173,"context_line":"        # self.controller._add_fixed_ip(self.non_admin_req, UUID, body\u003dbody)"},{"line_number":174,"context_line":"        self.assertRaises(exception.AdminRequired,"},{"line_number":175,"context_line":"                          self.controller._add_fixed_ip,"},{"line_number":176,"context_line":"                          self.non_admin_req, UUID, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_70ba9de2","line":173,"updated":"2015-02-28 12:09:29.000000000","message":"remove this comment.","commit_id":"6e98c62a562150962043a15afbb7eb4d1de36be1"}]}