)]}'
{"nova/api/openstack/compute/contrib/admin_actions.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"58673294290dfb70373108c554b2c47daa4bb57f","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            msg \u003d _(\"createBackup attribute \u0027rotation\u0027 must be an integer\")"},{"line_number":234,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":235,"context_line":"        if rotation \u003c 0:"},{"line_number":236,"context_line":"            msg \u003d _(\"createBackup attribute \u0027rotation\u0027 must be positive\")"},{"line_number":237,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        props \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F3W4%3D","line":236,"updated":"2012-10-31 17:58:34.000000000","message":"This message is not entirely correct, because it can be zero as well, right?","commit_id":"768314440c52df3138e3f72883c2026b0d43845b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2ba3bf5d95dada637a20f2698220d48c6fda943d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":235,"context_line":"        if rotation \u003c 0:"},{"line_number":236,"context_line":"            msg \u003d _(\"createBackup attribute \u0027rotation\u0027 must be greater \""},{"line_number":237,"context_line":"                    \"than zero\")"},{"line_number":238,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        props \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F3RQ%3D","line":237,"updated":"2012-10-31 18:51:37.000000000","message":"This message is still not quite correct - it should read somehting like:\n\n\"createBackup attribute \u0027rotation\u0027 must be greater than or equal to zero\" \n\nsince zero is a valid value here.","commit_id":"a920cd5be1c577b6fad48dc627245d5cec458d69"},{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"2a6b300fa3b3fabe8c1f955f14c0f19d6d0caff6","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            image_id \u003d str(image[\u0027id\u0027])"},{"line_number":263,"context_line":"            image_ref \u003d os.path.join(req.application_url, \u0027images\u0027, image_id)"},{"line_number":264,"context_line":"            resp.headers[\u0027Location\u0027] \u003d image_ref"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        return resp"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @wsgi.action(\u0027os-migrateLive\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F%2BxM%3D","line":265,"updated":"2012-11-13 04:34:26.000000000","message":"could you explain why we need this only for rotation \u003e 0?","commit_id":"6eac65a8e13d3040c0c6561709f59b3d9bab5435"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"d7e576eea71a88dce1e2586b10f0aff53cc6b98e","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            image_id \u003d str(image[\u0027id\u0027])"},{"line_number":263,"context_line":"            image_ref \u003d os.path.join(req.application_url, \u0027images\u0027, image_id)"},{"line_number":264,"context_line":"            resp.headers[\u0027Location\u0027] \u003d image_ref"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        return resp"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @wsgi.action(\u0027os-migrateLive\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F%2Bmo%3D","line":265,"in_reply_to":"AAAAMH%2F%2F%2BxM%3D","updated":"2012-11-13 09:21:43.000000000","message":"If the rotation is zero, the backuped image doesn\u0027t exist so we cannot return an image ref in the response.","commit_id":"6eac65a8e13d3040c0c6561709f59b3d9bab5435"}]}