)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4b739089d4f6885f03f51debb4666b438a2ccad7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove useless NotFound exception catching for v2/v2.1 fping"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is useless NotFound exception catching, this patch removes"},{"line_number":10,"context_line":"those useless code."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib980ad6e2932f90c93a2144e5b8711abd468b9be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_a46137aa","line":10,"updated":"2015-02-09 22:28:41.000000000","message":"necessary to describe the reason of useless.\nmaybe _get_instance_ips() doesn\u0027t raise it, I guess.","commit_id":"438d9a4b09b836b35fdc06ad4a74b0b698d86580"}],"nova/api/openstack/compute/contrib/fping.py":[{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"1605c3a792e8a5bc43d3e31b7ebe6e8acd65709d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if uuid in exclude or (include is not None and"},{"line_number":108,"context_line":"                                   uuid not in include):"},{"line_number":109,"context_line":"                continue"},{"line_number":110,"context_line":"            ips \u003d [str(ip) for ip in self._get_instance_ips(context, instance)]"},{"line_number":111,"context_line":"            instance_ips[uuid] \u003d ips"},{"line_number":112,"context_line":"            instance_projects[uuid] \u003d instance[\"project_id\"]"},{"line_number":113,"context_line":"            ip_list +\u003d ips"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_fefdc5b2","line":110,"updated":"2015-02-13 11:33:57.000000000","message":"Here, and...","commit_id":"db5af317f21d32cf3c43376ec7b2aee941ed6f0c"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"1605c3a792e8a5bc43d3e31b7ebe6e8acd65709d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        authorize(context)"},{"line_number":127,"context_line":"        self.check_fping()"},{"line_number":128,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":129,"context_line":"        ips \u003d [str(ip) for ip in self._get_instance_ips(context, instance)]"},{"line_number":130,"context_line":"        alive_ips \u003d self.fping(ips)"},{"line_number":131,"context_line":"        return {"},{"line_number":132,"context_line":"            \"server\": {"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_bef34de6","line":129,"updated":"2015-02-13 11:33:57.000000000","message":"...here, this is done in the only 2 places that _get_instance_ips is called. Maybe you could move the list comprehension it into the function itself, so the fn returns a list of strings?","commit_id":"db5af317f21d32cf3c43376ec7b2aee941ed6f0c"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"733eb41179f5a673acc7c66ec82ca2a0bef89517","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        authorize(context)"},{"line_number":127,"context_line":"        self.check_fping()"},{"line_number":128,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":129,"context_line":"        ips \u003d [str(ip) for ip in self._get_instance_ips(context, instance)]"},{"line_number":130,"context_line":"        alive_ips \u003d self.fping(ips)"},{"line_number":131,"context_line":"        return {"},{"line_number":132,"context_line":"            \"server\": {"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_1222e0b8","line":129,"in_reply_to":"da86d52c_bef34de6","updated":"2015-02-18 19:42:46.000000000","message":"Just my two cents, but I think that\u0027s a separate patch.","commit_id":"db5af317f21d32cf3c43376ec7b2aee941ed6f0c"}],"nova/api/openstack/compute/plugins/v3/fping.py":[{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"1605c3a792e8a5bc43d3e31b7ebe6e8acd65709d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        authorize(context)"},{"line_number":127,"context_line":"        self.check_fping()"},{"line_number":128,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":129,"context_line":"        ips \u003d [str(ip) for ip in self._get_instance_ips(context, instance)]"},{"line_number":130,"context_line":"        alive_ips \u003d self.fping(ips)"},{"line_number":131,"context_line":"        return {"},{"line_number":132,"context_line":"            \"server\": {"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5edb314f","line":129,"updated":"2015-02-13 11:33:57.000000000","message":"Same comment as in the other file.","commit_id":"db5af317f21d32cf3c43376ec7b2aee941ed6f0c"}]}