)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cb0d2773222c240ec1dad314322262925ee84cac","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def _get_agent(self, instance, vm_ref):"},{"line_number":164,"context_line":"        if self.agent_enabled:"},{"line_number":165,"context_line":"            return xapi_agent.XenAPIBasedAgent(self._session, instance, vm_ref)"},{"line_number":166,"context_line":"        raise Exception(\"Agent is disabled\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def list_instances(self):"},{"line_number":169,"context_line":"        \"\"\"List VM instances.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F2L4%3D","line":166,"updated":"2012-11-01 17:31:00.000000000","message":"I think this needs to be a more specific exception","commit_id":"19a2f9b3830e2f2242c45d437d7aa02640e02a74"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"82c06129e5b2c9bdc7bc1a264fb1e27e51f5883c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def _get_agent(self, instance, vm_ref):"},{"line_number":164,"context_line":"        if self.agent_enabled:"},{"line_number":165,"context_line":"            return xapi_agent.XenAPIBasedAgent(self._session, instance, vm_ref)"},{"line_number":166,"context_line":"        raise Exception(\"Agent is disabled\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def list_instances(self):"},{"line_number":169,"context_line":"        \"\"\"List VM instances.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F2KU%3D","line":166,"in_reply_to":"AAAALn%2F%2F2L4%3D","updated":"2012-11-01 17:52:44.000000000","message":"Normally, we should never hit this line, as we are always checking it it is enabled, so it is a sort of \"Programming Error\". What do you think, what type of exception would communicate this properly?","commit_id":"19a2f9b3830e2f2242c45d437d7aa02640e02a74"}]}