)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d6eebb43c3e0d919073fa1af20d3dd598f4a0d5b","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":1350,"context_line":"                network_name \u003d net[\u0027name\u0027]"},{"line_number":1351,"context_line":"                tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":1352,"context_line":"                vlan_id \u003d net.get(\u0027provider:segmentation_id\u0027)"},{"line_number":1353,"context_line":"                break"},{"line_number":1354,"context_line":"        else:"},{"line_number":1355,"context_line":"            tenant_id \u003d port[\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_4e91d545","line":1352,"updated":"2015-02-12 23:21:46.000000000","message":"This is only a vlan_id if the segmentation type is vlan. I think this variable should be renamed or you should check the segmentation type before assigning it to something called \u0027vlan_id\u0027.","commit_id":"273c036d44b96529e08484b1274108b7b7ef7c7e"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"e2c0eedaaf32453e0bda55a870d7be6e0f4ced4f","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"            if port[\u0027network_id\u0027] \u003d\u003d net[\u0027id\u0027]:"},{"line_number":1350,"context_line":"                network_name \u003d net[\u0027name\u0027]"},{"line_number":1351,"context_line":"                tenant_id \u003d net[\u0027tenant_id\u0027]"},{"line_number":1352,"context_line":"                vlan_id \u003d net.get(\u0027provider:segmentation_id\u0027)"},{"line_number":1353,"context_line":"                break"},{"line_number":1354,"context_line":"        else:"},{"line_number":1355,"context_line":"            tenant_id \u003d port[\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d45b6ff4","line":1352,"in_reply_to":"da86d52c_4e91d545","updated":"2015-02-13 20:25:39.000000000","message":"Ahh that\u0027s very true. It seems reasonable to support vxlan, gre (in the future), etc in the same way.","commit_id":"273c036d44b96529e08484b1274108b7b7ef7c7e"}],"nova/virt/netutils.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d6340dd9db51b2892d9fb6abcb4b82375616c861","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Create a VLAN link from this network if it exists"},{"line_number":212,"context_line":"        if network.get(\u0027meta\u0027, {}).get(\u0027network_type\u0027) in (\u0027vlan\u0027, \u0027vxlan\u0027):"},{"line_number":213,"context_line":"            vlan \u003d _create_vlan_link(vif, ifc_num, link[\u0027id\u0027])"},{"line_number":214,"context_line":"            if vlan:"},{"line_number":215,"context_line":"                # Set network to point to VLAN if it exists, otherwise,"},{"line_number":216,"context_line":"                # directly to NIC"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_18f7e8d5","line":213,"updated":"2015-02-14 22:10:30.000000000","message":"I think this should probably again be more generic sounding. _create_segmentation_link or something if we are going to include from different segmentation types.","commit_id":"693eefbb22062747ccd6520bb1f3133dc40ccd18"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"003e6579231d0955b021391062f68ef0175aa62d","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Create a VLAN link from this network if it exists"},{"line_number":212,"context_line":"        if network.get(\u0027meta\u0027, {}).get(\u0027network_type\u0027) in (\u0027vlan\u0027, \u0027vxlan\u0027):"},{"line_number":213,"context_line":"            vlan \u003d _create_vlan_link(vif, ifc_num, link[\u0027id\u0027])"},{"line_number":214,"context_line":"            if vlan:"},{"line_number":215,"context_line":"                # Set network to point to VLAN if it exists, otherwise,"},{"line_number":216,"context_line":"                # directly to NIC"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_b0ad9285","line":213,"in_reply_to":"da86d52c_18f7e8d5","updated":"2015-07-09 21:32:19.000000000","message":"Agreed, fixed.","commit_id":"693eefbb22062747ccd6520bb1f3133dc40ccd18"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d6340dd9db51b2892d9fb6abcb4b82375616c861","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # Create a VLAN link from this network if it exists"},{"line_number":212,"context_line":"        if network.get(\u0027meta\u0027, {}).get(\u0027network_type\u0027) in (\u0027vlan\u0027, \u0027vxlan\u0027):"},{"line_number":213,"context_line":"            vlan \u003d _create_vlan_link(vif, ifc_num, link[\u0027id\u0027])"},{"line_number":214,"context_line":"            if vlan:"},{"line_number":215,"context_line":"                # Set network to point to VLAN if it exists, otherwise,"},{"line_number":216,"context_line":"                # directly to NIC"},{"line_number":217,"context_line":"                links.append(vlan)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_786704b8","line":214,"updated":"2015-02-14 22:10:30.000000000","message":"Would this ever be false?","commit_id":"693eefbb22062747ccd6520bb1f3133dc40ccd18"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"003e6579231d0955b021391062f68ef0175aa62d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # Create a VLAN link from this network if it exists"},{"line_number":212,"context_line":"        if network.get(\u0027meta\u0027, {}).get(\u0027network_type\u0027) in (\u0027vlan\u0027, \u0027vxlan\u0027):"},{"line_number":213,"context_line":"            vlan \u003d _create_vlan_link(vif, ifc_num, link[\u0027id\u0027])"},{"line_number":214,"context_line":"            if vlan:"},{"line_number":215,"context_line":"                # Set network to point to VLAN if it exists, otherwise,"},{"line_number":216,"context_line":"                # directly to NIC"},{"line_number":217,"context_line":"                links.append(vlan)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_30abc276","line":214,"in_reply_to":"da86d52c_786704b8","updated":"2015-07-09 21:32:19.000000000","message":"Nope, I think that\u0027s a remnant from older code.","commit_id":"693eefbb22062747ccd6520bb1f3133dc40ccd18"}]}