)]}'
{"id":"openstack%2Fnova~15333","triplet_id":"openstack%2Fnova~master~If2cfe9e2541b435893017b0f56960d715761548b","project":"openstack/nova","branch":"master","topic":"shorten-rt","hashtags":[],"change_id":"If2cfe9e2541b435893017b0f56960d715761548b","subject":"Shorten self.compute.resource_tracker in test_compute.py","status":"MERGED","created":"2012-11-03 16:44:58.000000000","updated":"2012-11-06 09:03:05.000000000","submitted":"2012-11-06 09:03:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9bc4cf197b439a2167706b6a12927c8083c5468f","_number":15333,"virtual_id_number":15333,"owner":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-11-06 09:03:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"all":[{"value":0,"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"value":2,"date":"2012-11-05 13:18:05.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":2,"date":"2012-11-06 07:15:21.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":1,"date":"2012-11-05 21:34:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"value":0,"date":"2012-11-05 13:18:05.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":1,"date":"2012-11-06 07:15:21.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-03 17:10:45.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-11-05 03:23:27.000000000","updated_by":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"reviewer":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"state":"REVIEWER"},{"updated":"2012-11-05 13:18:05.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2012-11-05 21:34:32.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2012-11-06 07:15:21.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2012-11-06 09:03:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ffc0398eb4f22f5ba3b2297d7a9832701cc0d5e0","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-03 17:10:45.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/43839\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/43837\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/43838\n","accounts_in_message":[],"_revision_number":1},{"id":"f884686f3eff9c3200cc1d846670b73f15c29742","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-03 17:42:06.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/15333/1/check/gate-nova-merge/11216 : SUCCESS\n- http://logs.openstack.org/15333/1/check/gate-nova-docs/6957 : SUCCESS\n- http://logs.openstack.org/15333/1/check/gate-nova-pep8/12267 : SUCCESS\n- http://logs.openstack.org/15333/1/check/gate-nova-python26/8410 : SUCCESS\n- http://logs.openstack.org/15333/1/check/gate-nova-python27/8477 : SUCCESS\n- http://logs.openstack.org/15333/1/check/gate-tempest-devstack-vm/16819 : FAILURE\n- http://logs.openstack.org/15333/1/check/gate-nova-pylint/2383 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"8b8551a3f52ef0c6756249ab50b4cea5e487ced1","author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"date":"2012-11-05 09:55:54.000000000","message":"Patch Set 1: Rebased","accounts_in_message":[],"_revision_number":1},{"id":"35fa4261765bf1321e1e8d66f24a794a6a46adca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-05 10:15:40.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15333/2/check/gate-nova-merge/11277 : SUCCESS\n- http://logs.openstack.org/15333/2/check/gate-nova-docs/7018 : SUCCESS\n- http://logs.openstack.org/15333/2/check/gate-nova-pep8/12328 : SUCCESS\n- http://logs.openstack.org/15333/2/check/gate-nova-python26/8470 : SUCCESS\n- http://logs.openstack.org/15333/2/check/gate-nova-python27/8538 : SUCCESS\n- http://logs.openstack.org/15333/2/check/gate-tempest-devstack-vm/16913 : SUCCESS\n- http://logs.openstack.org/15333/2/check/gate-nova-pylint/2432 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"cd7855193142c87e71015588776ef33424a927ad","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-11-05 13:18:05.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"89cccdb60f28b759fe128005a24e5c7bf9499609","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-11-05 19:59:58.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\ngoing from resource_tracker to rt in only part of the code leads will result in harder to read (and grep) code, and I am not clear what this patch provides in return.\n\nWhy is this patch needed in preparation for you later patch that provides multiple resource_trackers?","accounts_in_message":[],"_revision_number":2},{"id":"6862b433ce33e7f2cb31d2ac8102c3c7f2a4481d","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-11-05 20:47:59.000000000","message":"Patch Set 2:\n\nJoe, see https://review.openstack.org/#/c/13920/16/nova/tests/compute/test_compute.py","accounts_in_message":[],"_revision_number":2},{"id":"e681f86c9846d0c87cf4487131dbdf16f4bb362c","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2012-11-05 21:34:32.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nMark, Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"051687737b34327358093d50e497dfa32b2e4863","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-06 07:15:21.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"efda0547574f6dd72af3d48678e524308e18b8c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 07:16:11.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"91394cb0b711bc5c7dfa142eddd00c04e352b913","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 09:03:03.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15333/2/gate/gate-nova-merge/11410 : SUCCESS\n- http://logs.openstack.org/15333/2/gate/gate-nova-docs/7146 : SUCCESS\n- http://logs.openstack.org/15333/2/gate/gate-nova-pep8/12456 : SUCCESS\n- http://logs.openstack.org/15333/2/gate/gate-nova-python26/8598 : SUCCESS\n- http://logs.openstack.org/15333/2/gate/gate-nova-python27/8666 : SUCCESS\n- http://logs.openstack.org/15333/2/gate/gate-tempest-devstack-vm/17170 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"febe4297f1a9372465f17d60a19c3a1bd722b28a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 09:03:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b36f54593fcb8a262658682f847d1e90c667866e","revisions":{"9f3869bfeed53e9b6437fa2da9587e63cca97ebe":{"kind":"REWORK","_number":1,"created":"2012-11-03 16:44:58.000000000","uploader":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"ref":"refs/changes/33/15333/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/15333/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/15333/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/15333/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/15333/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/15333/1"}}},"commit":{"parents":[{"commit":"3a6a67f6a374142cece7190b5ddfa4444208c13e","subject":"Merge \"Fix unused variables and wrong indent in test_compute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3a6a67f6a374142cece7190b5ddfa4444208c13e"}]}],"author":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2012-11-03 15:55:45.000000000","tz":540},"committer":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2012-11-03 16:41:38.000000000","tz":540},"subject":"Shorten self.compute.resource_tracker in test_compute.py","message":"Shorten self.compute.resource_tracker in test_compute.py\n\nReplace \"self.compute.resource_tracker\" with \"self.rt\" to make\nlong lines short. This is only a clean-up. This is not intended\na functional change, though it implies that\nself.compute.resource_tracker is not re-assigned during each test.\n\nThis is a preparation for a later patch that implements multiple\nresource_trackers in a compute manager. It will use\n\"self.compute._get_resource_tracker(None)\" or something instead of\n\"self.compute.resource_tracker\".\n\nChange-Id: If2cfe9e2541b435893017b0f56960d715761548b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9f3869bfeed53e9b6437fa2da9587e63cca97ebe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9f3869bfeed53e9b6437fa2da9587e63cca97ebe"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3a6a67f6a374142cece7190b5ddfa4444208c13e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"b36f54593fcb8a262658682f847d1e90c667866e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2012-11-03 16:44:58.000000000","uploader":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"ref":"refs/changes/33/15333/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/15333/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/15333/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/15333/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/15333/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/15333/2"}}},"commit":{"parents":[{"commit":"5495b50a4182b60744d6d6937beb5cb338d89293","subject":"Merge \"Make session.py reusable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5495b50a4182b60744d6d6937beb5cb338d89293"}]}],"author":{"name":"Arata Notsu","email":"notsu@virtualtech.jp","date":"2012-11-03 15:55:45.000000000","tz":540},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2012-11-05 09:55:53.000000000","tz":0},"subject":"Shorten self.compute.resource_tracker in test_compute.py","message":"Shorten self.compute.resource_tracker in test_compute.py\n\nReplace \"self.compute.resource_tracker\" with \"self.rt\" to make\nlong lines short. This is only a clean-up. This is not intended\na functional change, though it implies that\nself.compute.resource_tracker is not re-assigned during each test.\n\nThis is a preparation for a later patch that implements multiple\nresource_trackers in a compute manager. It will use\n\"self.compute._get_resource_tracker(None)\" or something instead of\n\"self.compute.resource_tracker\".\n\nChange-Id: If2cfe9e2541b435893017b0f56960d715761548b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b36f54593fcb8a262658682f847d1e90c667866e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b36f54593fcb8a262658682f847d1e90c667866e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5495b50a4182b60744d6d6937beb5cb338d89293","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}