)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"758c32b773bf73c4850af76ad885f6dca74a6cfd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"volume_snapshot_delete, volume_snapshot_create,"},{"line_number":12,"context_line":"get_console_topic and get_console_pool_info are rpc calls"},{"line_number":13,"context_line":"but not wrapped with @wrap_exception(), so rpc call will"},{"line_number":14,"context_line":"time out in case exception occurs in the 4 functions."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5ce5c73b1d8d159496a1382cc182c9c9a27f01b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_49c41440","line":14,"updated":"2015-02-09 22:07:23.000000000","message":"Two of those are RPC casts, not calls (the volume_snapshot ones). I\u0027m not sure what you mean about the \"reply rpc call\" and \"rpc call will time out\". That\u0027s not what wrap_exception does -- it just fires a notification before re-raising the same exception.\n\nCan you reference a bug with more detail about the \"time out\" you\u0027re seeing? Otherwise, please remove that from this commit message. While I think this is probably a reasonable thing to do (notify on these error cases), I don\u0027t think this commit message is correct.","commit_id":"dd23c2f6207d30cb9c32e14b8883cdea1393f83c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0ee2e9cf7f497a8987fc186dbff06702c3d5536c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add @wrap_exception() for 3 compute functions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"@wrap_exception() is a function that will handle exception"},{"line_number":10,"context_line":"and reply rpc call in case fail. currently"},{"line_number":11,"context_line":"volume_snapshot_delete, volume_snapshot_create,"},{"line_number":12,"context_line":"get_console_pool_info are rpc calls"},{"line_number":13,"context_line":"but not wrapped with @wrap_exception()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da86d52c_a5570759","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":18},"updated":"2015-02-11 23:23:30.000000000","message":"AFAIK, this is just not true.","commit_id":"21c3ac03c6aba85dcc997ff8486a3efc76fe3a28"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"fc41d5dd947369f448d4b57dc75848d4a44b944b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When analyzing bug 1412279 , noticed that rpc call\u0027s"},{"line_number":14,"context_line":"exception will lead to time out if it\u0027s not wrapped"},{"line_number":15,"context_line":"by this function (because no rpc response),"},{"line_number":16,"context_line":"get_console_pool_info are those kind"},{"line_number":17,"context_line":"of calls."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba7be1f8_3971fb44","line":15,"updated":"2015-02-28 01:14:46.000000000","message":"I don\u0027t see how wrap_exception helps with this.\n\nfrom nova.exception:wrap_exception\n\n    \"\"\"This decorator wraps a method to catch any exceptions that may\n    get thrown. It also optionally sends the exception to the notification\n    system.\n   \"\"\"\n\nIt looks like all we use this for is to send a notification that an exception happened for monitoring systems to collect, which is very useful. but that isn\u0027t what this commit message is saying you are trying to do.","commit_id":"585445b42437b465daf062818eb6f1702c3e21d9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"faaf6857c17eb89fa95899b9631310b06dacf14d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When analyzing bug 1412279 , noticed that rpc call\u0027s"},{"line_number":14,"context_line":"exception will lead to time out if it\u0027s not wrapped"},{"line_number":15,"context_line":"by this function (because no rpc response),"},{"line_number":16,"context_line":"get_console_pool_info are those kind"},{"line_number":17,"context_line":"of calls."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_6956f75d","line":15,"in_reply_to":"ba7be1f8_3971fb44","updated":"2015-03-06 15:41:48.000000000","message":"ok .let me remove those parts first from the commit message, thanks","commit_id":"585445b42437b465daf062818eb6f1702c3e21d9"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"b08e1ed8326fe8815a63385cd8dd2628af6d3fd0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently volume_snapshot_delete, volume_snapshot_create,"},{"line_number":10,"context_line":"get_console_pool_info are rpc calls"},{"line_number":11,"context_line":"but not wrapped with @wrap_exception()"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5ce5c73b1d8d159496a1382cc182c9c9a27f01b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_ccf7f157","line":11,"updated":"2015-03-06 15:59:45.000000000","message":"Please indicate why adding @wrap_exception is useful or needed.","commit_id":"091c10a41806f354b56206f3c1767c2a6860c7a7"}],"nova/compute/manager.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"abfdde1caddba998ee42b08f2b7b43cd615ddb98","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"        except exception.InstanceNotFound:"},{"line_number":1189,"context_line":"            return power_state.NOSTATE"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    @wrap_exception()"},{"line_number":1192,"context_line":"    def get_console_topic(self, context):"},{"line_number":1193,"context_line":"        \"\"\"Retrieves the console host for a project on this host."},{"line_number":1194,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_fefe3b6a","line":1191,"updated":"2015-02-10 14:58:30.000000000","message":"I don\u0027t understand why we would wrap_exception on a concatinate","commit_id":"da9f813478d40ac52b45deccd0a7bf00c4e340f9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fc7b7273676bbe9854c76cf783f2e06f5b081477","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"        except exception.InstanceNotFound:"},{"line_number":1189,"context_line":"            return power_state.NOSTATE"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    @wrap_exception()"},{"line_number":1192,"context_line":"    def get_console_topic(self, context):"},{"line_number":1193,"context_line":"        \"\"\"Retrieves the console host for a project on this host."},{"line_number":1194,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_ea44b175","line":1191,"in_reply_to":"da86d52c_fefe3b6a","updated":"2015-02-10 16:33:08.000000000","message":"oops, I thought it might be helpful if it change later \nand someone might forget to do so...\nand you are right ,let me remove it","commit_id":"da9f813478d40ac52b45deccd0a7bf00c4e340f9"}]}