)]}'
{"nova/tests/test_imagecache.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5515790a5371f7356a3384c89e8b0c611754231c","unresolved":false,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"            fname, info_fname, testdata \u003d self._make_checksum(tmpdir)"},{"line_number":469,"context_line":"            print fname"},{"line_number":470,"context_line":"            print info_fname"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            # Checksum file missing"},{"line_number":473,"context_line":"            image_cache_manager \u003d imagecache.ImageCacheManager()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fzy4%3D","line":470,"updated":"2012-11-05 15:22:46.000000000","message":"I think we should avoid adding new print statements to tests. If these were intended to be left in, can we LOG them?","commit_id":"182ed50f1dd61dd56681d735bd93585ef3d8f529"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f6fda61c34ce104235f3569b3753ccb091573ea5","unresolved":false,"context_lines":[{"line_number":467,"context_line":""},{"line_number":468,"context_line":"            fname, info_fname, testdata \u003d self._make_checksum(tmpdir)"},{"line_number":469,"context_line":"            print fname"},{"line_number":470,"context_line":"            print info_fname"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            # Checksum file missing"},{"line_number":473,"context_line":"            image_cache_manager \u003d imagecache.ImageCacheManager()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fy8Q%3D","line":470,"in_reply_to":"AAAALn%2F%2Fzy4%3D","updated":"2012-11-06 02:44:07.000000000","message":"Damn. I thought I\u0027d removed those. Sorry.","commit_id":"182ed50f1dd61dd56681d735bd93585ef3d8f529"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7c135f1192f332264fdd78e9f12abd17c7dee4a2","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_read_stored_checksum_missing(self):"},{"line_number":55,"context_line":"        self.stubs.Set(os.path, \u0027exists\u0027, lambda x: False)"},{"line_number":56,"context_line":"        csum \u003d imagecache.read_stored_checksum(\u0027/tmp/foo\u0027, timestamped\u003dFalse)"},{"line_number":57,"context_line":"        self.assertEquals(csum, None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_read_stored_checksum(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F18k%3D","line":56,"updated":"2012-11-20 15:03:45.000000000","message":"given that the default is timestamped\u003dFalse, is there as reason to pass this as an explicit param?","commit_id":"8d763888189f1555b5fc4851db369a98c4755522"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"16fca0b6d9621b50fe55fec9f38cdaf4d7583fef","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_read_stored_checksum_missing(self):"},{"line_number":55,"context_line":"        self.stubs.Set(os.path, \u0027exists\u0027, lambda x: False)"},{"line_number":56,"context_line":"        csum \u003d imagecache.read_stored_checksum(\u0027/tmp/foo\u0027, timestamped\u003dFalse)"},{"line_number":57,"context_line":"        self.assertEquals(csum, None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_read_stored_checksum(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F1bY%3D","line":56,"in_reply_to":"AAAAMH%2F%2F18k%3D","updated":"2012-11-20 20:15:44.000000000","message":"It just makes the test more explicit in case the default changes later?","commit_id":"8d763888189f1555b5fc4851db369a98c4755522"}],"nova/virt/libvirt/imagecache.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5515790a5371f7356a3384c89e8b0c611754231c","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"                f \u003d open(base_file, \u0027r\u0027)"},{"line_number":255,"context_line":"                current_checksum \u003d utils.hash_file(f)"},{"line_number":256,"context_line":"                f.close()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"                if current_checksum !\u003d stored_checksum:"},{"line_number":259,"context_line":"                    LOG.error(_(\u0027%(id)s (%(base_file)s): image verification \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fzz0%3D","line":256,"updated":"2012-11-05 15:22:46.000000000","message":"Another opportunity to clean this up using \u0027with\u0027 ?","commit_id":"182ed50f1dd61dd56681d735bd93585ef3d8f529"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f6fda61c34ce104235f3569b3753ccb091573ea5","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"                f \u003d open(base_file, \u0027r\u0027)"},{"line_number":255,"context_line":"                current_checksum \u003d utils.hash_file(f)"},{"line_number":256,"context_line":"                f.close()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"                if current_checksum !\u003d stored_checksum:"},{"line_number":259,"context_line":"                    LOG.error(_(\u0027%(id)s (%(base_file)s): image verification \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fy8I%3D","line":256,"in_reply_to":"AAAALn%2F%2Fzz0%3D","updated":"2012-11-06 02:44:07.000000000","message":"Done","commit_id":"182ed50f1dd61dd56681d735bd93585ef3d8f529"}]}