)]}'
{"nova/virt/libvirt/connection.py":[{"author":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"change_message_id":"c823a9364af3a457db898f530f2ee35e044bbd39","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                    None,"},{"line_number":151,"context_line":"                    \u0027The disk prefix for the devices attached to a server\u0027"},{"line_number":152,"context_line":"                    \u0027(valid options are: sd, xv, uvd, vd)\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def get_connection(read_only):"},{"line_number":156,"context_line":"    # These are loaded late so that there\u0027s no need to install these"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Buk%3D","line":153,"updated":"2011-11-12 17:16:40.000000000","message":"At the very least, this should be called libvirt_disk_prefix. \n\nThis setting will have no effect for XenServer or any of the other hypervisors that don\u0027t use libvirt, so it\u0027s very important to not present this flag in a way that is confusing to configure.  I would argue that this is already too confusing.\n\nWhat is the use case for needing to set this anyway?","commit_id":"122a3e706cdefa141558a2e4a92f6f9b86efde65"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"14e1268df9785de23632171caf2a683e107a86ea","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                    None,"},{"line_number":151,"context_line":"                    \u0027The disk prefix for the devices attached to a server\u0027"},{"line_number":152,"context_line":"                    \u0027(valid options are: sd, xv, uvd, vd)\u0027)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def get_connection(read_only):"},{"line_number":156,"context_line":"    # These are loaded late so that there\u0027s no need to install these"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Btw%3D","line":153,"in_reply_to":"AAAACn%2F%2F%2Buk%3D","updated":"2011-11-12 20:44:11.000000000","message":"I agree that the name is misleading and that it might be confusing. However, the disk prefix might vary from \u0027sd\u0027 (that is hardcoded right now) to \u0027xvd\u0027 (that is for example our case).\n\nI opened a question some time ago about this fact, since it was configurable in the libvirt XML template, but then it was hardcoded. See  https://answers.launchpad.net/nova/+question/176978","commit_id":"122a3e706cdefa141558a2e4a92f6f9b86efde65"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3aeca82546be8e854f05cf8dcdfdd0ff51d28a2","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"        if FLAGS.libvirt_type \u003d\u003d \u0027uml\u0027:"},{"line_number":1069,"context_line":"            utils.execute(\u0027chown\u0027, \u0027root\u0027, basepath(\u0027disk\u0027), run_as_root\u003dTrue)"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    if FLAGS.disk_prefix:"},{"line_number":1072,"context_line":"        _disk_prefix \u003d FLAGS.libvirt_disk_prefix"},{"line_number":1073,"context_line":"    elif FLAGS.libvirt_type \u003d\u003d \u0027uml\u0027:"},{"line_number":1074,"context_line":"        _disk_prefix \u003d \u0027ubd\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F98U%3D","line":1071,"updated":"2011-11-16 17:31:14.000000000","message":"You missed one use.","commit_id":"39ef29b7063f459c7d9012501e16f1d362426eec"}]}