)]}'
{"id":"openstack%2Fnova~154567","triplet_id":"openstack%2Fnova~master~Ia4d204df233fd40a9008e6cc010446c62e18a3b9","project":"openstack/nova","branch":"master","topic":"bug/1420322","hashtags":[],"change_id":"Ia4d204df233fd40a9008e6cc010446c62e18a3b9","subject":"libvirt: remove _destroy_instance_files shim","status":"MERGED","created":"2015-02-10 17:05:45.000000000","updated":"2015-02-13 07:00:36.000000000","submitted":"2015-02-13 03:52:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7566c4f5955d54fcc6e93018991f9b10c12b1546","_number":154567,"virtual_id_number":154567,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2015-02-10 21:27:39.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":1,"date":"2015-02-10 21:02:18.000000000","_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":2,"date":"2015-02-13 03:52:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-02-10 21:12:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"date":"2015-02-12 21:35:08.000000000","_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"date":"2015-02-11 14:44:32.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2015-02-10 20:52:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"date":"2015-02-10 22:54:14.000000000","_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-02-11 14:57:53.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-02-11 16:50:02.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2015-02-11 00:21:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-02-11 16:50:02.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-10 17:06:31.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2015-02-10 20:52:35.000000000","updated_by":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-10 21:02:18.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-10 21:12:25.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-10 21:27:39.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-10 22:54:14.000000000","updated_by":{"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]},"reviewer":{"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-02-11 00:21:06.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2015-02-11 14:57:53.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2015-02-11 16:50:02.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2015-02-12 21:35:08.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2015-02-13 03:52:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"346aa84a2cbf7ceffea1b0d5a51214581379ae25","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-02-10 17:05:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1acf1235530f9477a9cfe5c8df2020eef500b444","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2015-02-10 17:32:14.000000000","message":"Patch Set 1: Verified+1\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/67/154567/1/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/4a69dfbab36347ca95b7acccc942fd7e/index.html : SUCCESS in 19m 26s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/67/154567/1/check/real-db-upgrade_nova_mysql_user_001:th-mysql/02a85fb148c24c07bef92e1f04c0e794/index.html : SUCCESS in 23m 27s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/67/154567/1/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/1a5467c980de4b179c8d414d5d11e811/index.html : SUCCESS in 19m 13s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/67/154567/1/check/real-db-upgrade_nova_percona_user_001:th-percona/bd4909561a5547a1836e128a44f98638/index.html : SUCCESS in 24m 10s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/67/154567/1/check/real-db-upgrade_nova_mysql_user_002:th-mysql/304afa2b1f2f4dfe9d0afafd529ff5f4/index.html : SUCCESS in 16m 45s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/67/154567/1/check/real-db-upgrade_nova_percona_user_002:th-percona/80f679f2e47342a8bb1123c2a93725af/index.html : SUCCESS in 20m 58s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/ThirdPartySystems/DB_Datasets_CI","accounts_in_message":[],"_revision_number":1},{"id":"c6588cff1f710e1706bf866e49c5e89ac665147d","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2015-02-10 17:46:27.000000000","message":"Patch Set 1:\n\nBuild failed. For rechecking only on the Hyper-V CI, add a review comment with check hyper-v\n\n- http://64.119.130.115/154567/1/ : Test run failed. in 10m 37s","accounts_in_message":[],"_revision_number":1},{"id":"c9d0ccb25f625d874cff0caae511faaa6308d7a8","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2015-02-10 17:49:08.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with recheck-pkvm. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/154567/1/check-ibm-tempest-dsvm-full/0576cb8 : SUCCESS in 33m 25s (non-voting)\n- check-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/154567/1/check-ibm-tempest-dsvm-postgres-full/83204bb : SUCCESS in 41m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f6e5f27ca0add55ebc5ca9c30ba7f0948969f483","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-02-10 17:53:55.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks reasonable to me.  Would like to see what Michael thinks.","accounts_in_message":[],"_revision_number":1},{"id":"260c4a8c31d85c08a85344d4d6a36a6073466191","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-02-10 18:33:34.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/154567/1/8724/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"6965cd4347ff0af62b9626e82e2829066f0b8437","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-10 18:50:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-nova-pep8 http://logs.openstack.org/67/154567/1/check/gate-nova-pep8/7e1f9e0/ : SUCCESS in 8m 09s\n- gate-nova-docs http://docs-draft.openstack.org/67/154567/1/check/gate-nova-docs/a14f620//doc/build/html/ : SUCCESS in 8m 54s\n- gate-nova-python27 http://logs.openstack.org/67/154567/1/check/gate-nova-python27/d943864/ : FAILURE in 15m 39s\n- check-tempest-dsvm-full http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-full/b439081/ : SUCCESS in 48m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-postgres-full/58dcf5d/ : SUCCESS in 52m 35s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-neutron-full/3519595/ : SUCCESS in 1h 07m 29s\n- check-grenade-dsvm http://logs.openstack.org/67/154567/1/check/check-grenade-dsvm/21ebad1/ : SUCCESS in 41m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/154567/1/check/gate-tempest-dsvm-large-ops/0e178e4/ : SUCCESS in 26m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/154567/1/check/gate-tempest-dsvm-neutron-large-ops/b13397f/ : SUCCESS in 24m 01s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/154567/1/check/check-devstack-dsvm-cells/fed8733/ : SUCCESS in 18m 51s\n- gate-nova-tox-functional http://logs.openstack.org/67/154567/1/check/gate-nova-tox-functional/0135d44/ : SUCCESS in 13m 35s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/154567/1/check/check-grenade-dsvm-partial-ncpu/7753ae8/ : SUCCESS in 45m 08s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-ironic-pxe_ssh/177cc0a/ : SUCCESS in 38m 27s\n- check-tempest-dsvm-nova-v21-full http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-nova-v21-full/41078b2/ : SUCCESS in 50m 30s\n- check-tempest-dsvm-cells http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-cells/861b212/ : FAILURE in 38m 03s (non-voting)\n- check-tempest-dsvm-full-ceph http://logs.openstack.org/67/154567/1/check/check-tempest-dsvm-full-ceph/3987771/ : SUCCESS in 50m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"16607f5b634d3dfcbe3a2a9a84cf1d0828a8c150","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-02-10 20:17:38.000000000","message":"Patch Set 1:\n\nFoiled by the tests","accounts_in_message":[],"_revision_number":1},{"id":"dddc875d3ffc61f66b1bb3a69d4b7661a829d8a2","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-02-10 20:17:43.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"86fc479dd30b50f35015ca40df9db4c9f6590e5d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-02-10 20:28:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e40093865a5eb72c5ca780a3b5854698721dac7e","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2015-02-10 20:52:35.000000000","message":"Patch Set 2: Verified+1\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/67/154567/2/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/b628b2bf55a54b5195a06ab6aecfb80b/index.html : SUCCESS in 16m 31s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/67/154567/2/check/real-db-upgrade_nova_mysql_user_001:th-mysql/b5da635b84b64628ba3a0219ab5243df/index.html : SUCCESS in 21m 46s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/67/154567/2/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/a7f9f767737341a9af73fa97246d27dd/index.html : SUCCESS in 16m 20s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/67/154567/2/check/real-db-upgrade_nova_percona_user_001:th-percona/9491a4b694f249b0a59cfa5b524fed4c/index.html : SUCCESS in 23m 10s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/67/154567/2/check/real-db-upgrade_nova_mysql_user_002:th-mysql/29a8640dbc204bb78e49c7d66e916da4/index.html : SUCCESS in 19m 25s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/67/154567/2/check/real-db-upgrade_nova_percona_user_002:th-percona/c6152721db1340a0b8575dab720907be/index.html : SUCCESS in 20m 35s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/ThirdPartySystems/DB_Datasets_CI","accounts_in_message":[],"_revision_number":2},{"id":"1663c816212edb49a6844a399be5d53d05be10bf","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2015-02-10 21:02:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- http://64.119.130.115/154567/2/ : Looks good to me in 33m 35s","accounts_in_message":[],"_revision_number":2},{"id":"d20430969aebc08b05bfc0dc88c9fb3c058291fd","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2015-02-10 21:12:25.000000000","message":"Patch Set 2:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with recheck-pkvm. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/154567/2/check-ibm-tempest-dsvm-full/b2fa894 : SUCCESS in 43m 56s (non-voting)\n- check-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/154567/2/check-ibm-tempest-dsvm-postgres-full/e5ac060 : SUCCESS in 32m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a358be77d630f8ed65a1e3df737d1aeea07e6116","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-02-10 21:27:39.000000000","message":"Patch Set 2: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/67/154567/2/8752/results.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"2b9e8ff90d2f7255e978a6b810735c85079eca52","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-10 21:34:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/67/154567/2/check/gate-nova-pep8/35f0004/ : SUCCESS in 11m 16s\n- gate-nova-docs http://docs-draft.openstack.org/67/154567/2/check/gate-nova-docs/16b1e91//doc/build/html/ : SUCCESS in 8m 32s\n- gate-nova-python27 http://logs.openstack.org/67/154567/2/check/gate-nova-python27/8adba08/ : SUCCESS in 11m 10s\n- check-tempest-dsvm-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-full/9f7255c/ : SUCCESS in 49m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-postgres-full/31c7fe7/ : SUCCESS in 48m 12s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-neutron-full/a015fb5/ : SUCCESS in 50m 42s\n- check-grenade-dsvm http://logs.openstack.org/67/154567/2/check/check-grenade-dsvm/ba2c3d2/ : SUCCESS in 44m 43s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/154567/2/check/gate-tempest-dsvm-large-ops/371dd8f/ : SUCCESS in 26m 29s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/154567/2/check/gate-tempest-dsvm-neutron-large-ops/7f799c0/ : SUCCESS in 24m 37s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/154567/2/check/check-devstack-dsvm-cells/96a4f45/ : SUCCESS in 19m 06s\n- gate-nova-tox-functional http://logs.openstack.org/67/154567/2/check/gate-nova-tox-functional/7bb6073/ : SUCCESS in 14m 53s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/154567/2/check/check-grenade-dsvm-partial-ncpu/75f77ba/ : SUCCESS in 43m 08s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-ironic-pxe_ssh/7bf05c4/ : SUCCESS in 37m 44s\n- check-tempest-dsvm-nova-v21-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-nova-v21-full/82147a4/ : SUCCESS in 50m 29s\n- check-tempest-dsvm-cells http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-cells/b9eecd8/ : FAILURE in 33m 52s (non-voting)\n- check-tempest-dsvm-full-ceph http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-full-ceph/dddda1c/ : SUCCESS in 53m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"eac11f06d511784d90fce7d4fba3023d7cf74f32","author":{"_account_id":11103,"name":"Intel PCI CI","email":"otc_cloud@163.com","username":"intelotccloud","inactive":true,"tags":["SERVICE_USER"]},"date":"2015-02-10 22:54:14.000000000","message":"Patch Set 2:\n\nBuild Failed. Logs at http://198.175.100.33/154567/2","accounts_in_message":[],"_revision_number":2},{"id":"6f98b58c58f80bf2ed8fd4df6675fedabb6da5e4","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2015-02-11 00:21:06.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\n+1 with a comment inside","accounts_in_message":[],"_revision_number":2},{"id":"6ac8630edb2cbfa176bb1a5382d67419c22370a6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-02-11 14:44:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8ea3258ec613a03f606f62d16b3bb17acabf1bcb","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-02-11 14:57:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5c00f4253ac5f351e962a936341ccf99c2563900","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2015-02-11 16:50:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\nlgtm","accounts_in_message":[],"_revision_number":2},{"id":"7674241f1656765d8d3d024982ada3f079a7451a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-12 17:35:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c16b228312aaff6ee45fa27ebdbfc6780dd6c0b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-12 21:28:24.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-nova-docs http://docs-draft.openstack.org/67/154567/2/gate/gate-nova-docs/7981e5b//doc/build/html/ : SUCCESS in 10m 17s\n- gate-nova-pep8 http://logs.openstack.org/67/154567/2/gate/gate-nova-pep8/2c7e7cb/ : SUCCESS in 10m 53s\n- gate-nova-python27 http://logs.openstack.org/67/154567/2/gate/gate-nova-python27/89b5bbb/ : SUCCESS in 15m 19s\n- gate-tempest-dsvm-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-full/e31c711/ : SUCCESS in 49m 49s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-postgres-full/ac38ae2/ : SUCCESS in 47m 07s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-neutron-full/c455af0/ : SUCCESS in 1h 02m 14s\n- gate-grenade-dsvm http://logs.openstack.org/67/154567/2/gate/gate-grenade-dsvm/c5756ae/ : FAILURE in 30m 05s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-large-ops/9870337/ : SUCCESS in 21m 46s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-neutron-large-ops/692f5b7/ : SUCCESS in 23m 43s\n- gate-nova-tox-functional http://logs.openstack.org/67/154567/2/gate/gate-nova-tox-functional/361f6b1/ : SUCCESS in 14m 50s\n- gate-devstack-dsvm-cells http://logs.openstack.org/67/154567/2/gate/gate-devstack-dsvm-cells/5e2579a/ : SUCCESS in 18m 04s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/154567/2/gate/gate-grenade-dsvm-partial-ncpu/0477c74/ : SUCCESS in 42m 29s\n- gate-tempest-dsvm-nova-v21-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-nova-v21-full/8e771d2/ : SUCCESS in 41m 44s","accounts_in_message":[],"_revision_number":2},{"id":"d4b4d9306a6e6c95eccac71e74f4a9afb3b67374","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2015-02-12 21:35:08.000000000","message":"Patch Set 2:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-grenade-dsvm: https://bugs.launchpad.net/bugs/1285323\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":2},{"id":"b28e0ebede8a01137bac0abb8d6f3a71f0f17e05","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2015-02-13 01:21:15.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"84f0ba398fe59a5b729105c2f53e4043861d6ac9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-13 02:22:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/67/154567/2/check/gate-nova-pep8/06f835b/ : SUCCESS in 12m 29s\n- gate-nova-docs http://docs-draft.openstack.org/67/154567/2/check/gate-nova-docs/e807df5//doc/build/html/ : SUCCESS in 10m 05s\n- gate-nova-python27 http://logs.openstack.org/67/154567/2/check/gate-nova-python27/11a8d44/ : SUCCESS in 16m 29s\n- check-tempest-dsvm-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-full/6c3af1d/ : SUCCESS in 47m 11s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-postgres-full/8a6a3b9/ : SUCCESS in 43m 10s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-neutron-full/8aa5775/ : SUCCESS in 57m 25s\n- check-grenade-dsvm http://logs.openstack.org/67/154567/2/check/check-grenade-dsvm/fbccbab/ : SUCCESS in 43m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/154567/2/check/gate-tempest-dsvm-large-ops/6c99aeb/ : SUCCESS in 27m 51s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/154567/2/check/gate-tempest-dsvm-neutron-large-ops/ba77171/ : SUCCESS in 18m 39s\n- check-devstack-dsvm-cells http://logs.openstack.org/67/154567/2/check/check-devstack-dsvm-cells/fb43756/ : SUCCESS in 16m 30s\n- gate-nova-tox-functional http://logs.openstack.org/67/154567/2/check/gate-nova-tox-functional/37709e0/ : SUCCESS in 16m 18s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/154567/2/check/check-grenade-dsvm-partial-ncpu/bb5fe62/ : SUCCESS in 44m 32s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-ironic-pxe_ssh/b3ec1d6/ : SUCCESS in 37m 05s\n- check-tempest-dsvm-nova-v21-full http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-nova-v21-full/9c3a8a3/ : SUCCESS in 42m 32s\n- check-tempest-dsvm-cells http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-cells/3218216/ : FAILURE in 36m 36s (non-voting)\n- check-tempest-dsvm-full-ceph http://logs.openstack.org/67/154567/2/check/check-tempest-dsvm-full-ceph/2476b71/ : SUCCESS in 39m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"971891e2a97ae90474dd2b1dee787e3f2ccd0148","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-13 02:22:52.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2f41fecd3785522c00c49beea416ebdac175d56a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-13 03:52:32.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-nova-docs http://docs-draft.openstack.org/67/154567/2/gate/gate-nova-docs/7cafa77//doc/build/html/ : SUCCESS in 8m 28s\n- gate-nova-pep8 http://logs.openstack.org/67/154567/2/gate/gate-nova-pep8/b00acbc/ : SUCCESS in 7m 47s\n- gate-nova-python27 http://logs.openstack.org/67/154567/2/gate/gate-nova-python27/ed4432b/ : SUCCESS in 11m 54s\n- gate-tempest-dsvm-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-full/911ac44/ : SUCCESS in 35m 41s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-postgres-full/0296e65/ : SUCCESS in 35m 46s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-neutron-full/3387660/ : SUCCESS in 1h 07m 44s\n- gate-grenade-dsvm http://logs.openstack.org/67/154567/2/gate/gate-grenade-dsvm/2fec13e/ : SUCCESS in 37m 24s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-large-ops/b813e8a/ : SUCCESS in 20m 21s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-neutron-large-ops/4a9b213/ : SUCCESS in 19m 42s\n- gate-nova-tox-functional http://logs.openstack.org/67/154567/2/gate/gate-nova-tox-functional/cddb6f6/ : SUCCESS in 11m 18s\n- gate-devstack-dsvm-cells http://logs.openstack.org/67/154567/2/gate/gate-devstack-dsvm-cells/d215ad7/ : SUCCESS in 13m 28s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/67/154567/2/gate/gate-grenade-dsvm-partial-ncpu/33912ec/ : SUCCESS in 38m 01s\n- gate-tempest-dsvm-nova-v21-full http://logs.openstack.org/67/154567/2/gate/gate-tempest-dsvm-nova-v21-full/eec05e2/ : SUCCESS in 45m 19s","accounts_in_message":[],"_revision_number":2},{"id":"16649d77a5b15f464b0b64c528687e2b24b55da3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-13 03:52:35.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"292980b381abe73c189d1a0d163b5c0ae3889994","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2015-02-13 07:00:36.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- http://64.119.130.115/154567/2/ : Looks good to me in 47m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9dafd17c8208a507d97c5aa3ca9f22062b521f07","revisions":{"c8e17de2e6aaf3c366ef8d3c8eb5a5ed3d00fdbb":{"kind":"REWORK","_number":1,"created":"2015-02-10 17:05:45.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/67/154567/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/67/154567/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/67/154567/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/67/154567/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/67/154567/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/67/154567/1"}}},"commit":{"parents":[{"commit":"0ff69b5660a22463915429911cc4cea53882f9db","subject":"Use dot notation on instance object fields in _delete_instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0ff69b5660a22463915429911cc4cea53882f9db"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-02-10 16:20:14.000000000","tz":-480},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-02-10 17:02:17.000000000","tz":-480},"subject":"libvirt: remove _destroy_instance_files shim","message":"libvirt: remove _destroy_instance_files shim\n\nThe instance parameter passed to _destroy_instance_files is a nova\nobject now so we can remove the shim and todo and move that code up to\nthe cleanup method. A note is added to clarify the usage of the\n\u0027clean_attempts\u0027 system_metadata.\n\nThe cleanup method is called by destroy and _create_domain_and_network\nwhich are also getting an instance object.\n\nAlso changes one remaining place in _create_domain_and_network where the\ninstance.uuid field was accessed like a dict (changed to use dot\nnotation to re-enforce that it\u0027s an object).\n\nPartial-Bug: #1420322\n\nChange-Id: Ia4d204df233fd40a9008e6cc010446c62e18a3b9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c8e17de2e6aaf3c366ef8d3c8eb5a5ed3d00fdbb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c8e17de2e6aaf3c366ef8d3c8eb5a5ed3d00fdbb"}]},"branch":"refs/heads/master"},"9dafd17c8208a507d97c5aa3ca9f22062b521f07":{"kind":"REWORK","_number":2,"created":"2015-02-10 20:28:03.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/67/154567/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/67/154567/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/67/154567/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/67/154567/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/67/154567/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/67/154567/2"}}},"commit":{"parents":[{"commit":"0ff69b5660a22463915429911cc4cea53882f9db","subject":"Use dot notation on instance object fields in _delete_instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0ff69b5660a22463915429911cc4cea53882f9db"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-02-10 16:20:14.000000000","tz":-480},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-02-10 20:26:13.000000000","tz":-480},"subject":"libvirt: remove _destroy_instance_files shim","message":"libvirt: remove _destroy_instance_files shim\n\nThe instance parameter passed to _destroy_instance_files is a nova\nobject now so we can remove the shim and todo and move that code up to\nthe cleanup method. A note is added to clarify the usage of the\n\u0027clean_attempts\u0027 system_metadata.\n\nThe cleanup method is called by destroy and _create_domain_and_network\nwhich are also getting an instance object.\n\nAlso changes one remaining place in _create_domain_and_network where the\ninstance.uuid field was accessed like a dict (changed to use dot\nnotation to re-enforce that it\u0027s an object).\n\nPartial-Bug: #1420322\n\nChange-Id: Ia4d204df233fd40a9008e6cc010446c62e18a3b9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9dafd17c8208a507d97c5aa3ca9f22062b521f07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9dafd17c8208a507d97c5aa3ca9f22062b521f07"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}