)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"989c391010f80e23b7794ccef44ae5c5aadc8124","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            version \u003d \u00273.0\u0027"},{"line_number":414,"context_line":"            instance \u003d jsonutils.to_primitive(instance)"},{"line_number":415,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(host, instance),"},{"line_number":416,"context_line":"                version\u003dversion)"},{"line_number":417,"context_line":"        return cctxt.call(ctxt, \u0027check_instance_shared_storage\u0027,"},{"line_number":418,"context_line":"                          instance\u003dinstance,"},{"line_number":419,"context_line":"                          data\u003ddata)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2ea32b9f","line":416,"updated":"2015-02-17 21:42:01.000000000","message":"I think it\u0027s a good fix , but I didn\u0027t difference between this and previous patch in rpc data, so why bump version?","commit_id":"cda4b7785974b13776ca728bab215c414786e905"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d70a93c56e2eabf9770bae2f6cbde937a5dd45b5","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            version \u003d \u00273.0\u0027"},{"line_number":414,"context_line":"            instance \u003d jsonutils.to_primitive(instance)"},{"line_number":415,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(host, instance),"},{"line_number":416,"context_line":"                version\u003dversion)"},{"line_number":417,"context_line":"        return cctxt.call(ctxt, \u0027check_instance_shared_storage\u0027,"},{"line_number":418,"context_line":"                          instance\u003dinstance,"},{"line_number":419,"context_line":"                          data\u003ddata)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c6b50533","line":416,"in_reply_to":"da86d52c_2ea32b9f","updated":"2015-02-18 09:24:42.000000000","message":"Yeah - I don\u0027t think we need to bump the version here at all... an interesting situation.","commit_id":"cda4b7785974b13776ca728bab215c414786e905"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b4b15310cc6cd83074f22acc90be994b7eb717b6","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                          instance\u003dinstance,"},{"line_number":404,"context_line":"                          dest_check_data\u003ddest_check_data)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def check_instance_shared_storage(self, ctxt, instance, data, host\u003dNone):"},{"line_number":407,"context_line":"        if self.client.can_send_version(\u00273.29\u0027):"},{"line_number":408,"context_line":"            version \u003d \u00273.29\u0027"},{"line_number":409,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_0155024f","line":406,"updated":"2015-03-20 18:03:09.000000000","message":"This change adds a new kwarg to the check_instance_shared_storage() RPC API method, and therefore an RPC API version bump needs to be done both here and in the compute manager.\n\nYou will also need to not send this new host parameter when the target compute node does not support the new RPC API version.","commit_id":"fde77d49ff550b73f5f1671edc7366c9b7646200"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1632157c3cb302e101e1751a08eea20f461e0d8","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                          instance\u003dinstance,"},{"line_number":404,"context_line":"                          dest_check_data\u003ddest_check_data)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def check_instance_shared_storage(self, ctxt, instance, data, host\u003dNone):"},{"line_number":407,"context_line":"        if self.client.can_send_version(\u00273.29\u0027):"},{"line_number":408,"context_line":"            version \u003d \u00273.29\u0027"},{"line_number":409,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_8793bd4d","line":406,"in_reply_to":"9a80dd14_0155024f","updated":"2015-03-20 21:05:59.000000000","message":"Earlier discussion in this review told the author that a version bump isn\u0027t needed because the rpc payload here isn\u0027t changing (host is already part of the payload, but was always None previously).","commit_id":"fde77d49ff550b73f5f1671edc7366c9b7646200"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a3bcb373c4b6b229fdb235c1f3f26ecdf9f4a931","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                          instance\u003dinstance,"},{"line_number":404,"context_line":"                          dest_check_data\u003ddest_check_data)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def check_instance_shared_storage(self, ctxt, instance, data, host\u003dNone):"},{"line_number":407,"context_line":"        if self.client.can_send_version(\u00273.29\u0027):"},{"line_number":408,"context_line":"            version \u003d \u00273.29\u0027"},{"line_number":409,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_2910e04d","line":406,"in_reply_to":"9a80dd14_8793bd4d","updated":"2015-03-23 16:48:37.000000000","message":"Right, this doesn\u0027t change the actual RPC call. The RPC args aren\u0027t touched here, just the determination of which host the call should be sent to. Previously, the code only sent to the host that the instance reports (i.e. instance.host). The changed code lets the caller override that behavior if desired. However, the RPC call itself is the same, which is why there is no corresponding manager change.","commit_id":"fde77d49ff550b73f5f1671edc7366c9b7646200"}]}