)]}'
{"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c6329b26eb824adcae9a80b3cdfa23b9a261cab","unresolved":false,"context_lines":[{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class Connection(object):"},{"line_number":658,"context_line":"    def __init__(self, uri\u003dNone, readonly\u003dFalse, version\u003dNone):"},{"line_number":659,"context_line":"        version \u003d version or FAKE_LIBVIRT_VERSION"},{"line_number":660,"context_line":"        if not uri or uri \u003d\u003d \u0027\u0027:"},{"line_number":661,"context_line":"            if allow_default_uri_connection:"},{"line_number":662,"context_line":"                uri \u003d \u0027qemu:///session\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c2976dea","line":659,"updated":"2015-02-12 16:30:09.000000000","message":"nit: Connection looks to be never call with version\u003dNone so why this code instead of set version\u003dFAKE_LIBVIRT_VERSION ?","commit_id":"7403a0463ca8be6558007d58cabcc3ee6a2d9841"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c30dcb50dbaaf27a02b37842c8351ad653eb9a61","unresolved":false,"context_lines":[{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class Connection(object):"},{"line_number":658,"context_line":"    def __init__(self, uri\u003dNone, readonly\u003dFalse, version\u003dNone):"},{"line_number":659,"context_line":"        version \u003d version or FAKE_LIBVIRT_VERSION"},{"line_number":660,"context_line":"        if not uri or uri \u003d\u003d \u0027\u0027:"},{"line_number":661,"context_line":"            if allow_default_uri_connection:"},{"line_number":662,"context_line":"                uri \u003d \u0027qemu:///session\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_12e0cd95","line":659,"in_reply_to":"da86d52c_1d92c756","updated":"2015-02-13 12:16:02.000000000","message":"That;s true but can cause issues only when we are using a mutable type, just an int should be fine here I think. Also not sure it\u0027s really related to what we are trying to do in this patch, but ok.","commit_id":"7403a0463ca8be6558007d58cabcc3ee6a2d9841"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"4cac3e857f520409ca95796956156f0a1feccff7","unresolved":false,"context_lines":[{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class Connection(object):"},{"line_number":658,"context_line":"    def __init__(self, uri\u003dNone, readonly\u003dFalse, version\u003dNone):"},{"line_number":659,"context_line":"        version \u003d version or FAKE_LIBVIRT_VERSION"},{"line_number":660,"context_line":"        if not uri or uri \u003d\u003d \u0027\u0027:"},{"line_number":661,"context_line":"            if allow_default_uri_connection:"},{"line_number":662,"context_line":"                uri \u003d \u0027qemu:///session\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_1d92c756","line":659,"in_reply_to":"da86d52c_c2976dea","updated":"2015-02-12 17:45:26.000000000","message":"Agree, that was my previous attempt.\nProblem is how python works, I think, the optional variable is being evaluated\nwhen the method is being created and not when it\u0027s being called.","commit_id":"7403a0463ca8be6558007d58cabcc3ee6a2d9841"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0f8e7a6e60f24c5d0fcfe227033738c9b3543c7b","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class Connection(object):"},{"line_number":701,"context_line":"    def __init__(self, uri\u003dNone, readonly\u003dFalse, version\u003d9011):"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        if not uri or uri \u003d\u003d \u0027\u0027:"},{"line_number":704,"context_line":"            if allow_default_uri_connection:"},{"line_number":705,"context_line":"                uri \u003d \u0027qemu:///session\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_20910547","line":702,"updated":"2015-03-16 16:39:56.000000000","message":";)","commit_id":"cd5faf895fcda67d8788fcd80ba5067855051f41"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0f8e7a6e60f24c5d0fcfe227033738c9b3543c7b","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        self._event_callbacks \u003d {}"},{"line_number":733,"context_line":"        self.fakeLibVersion \u003d version"},{"line_number":734,"context_line":"        self.fakeVersion \u003d version"},{"line_number":735,"context_line":"        self.host_info \u003d HostInfo()"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def _add_filter(self, nwfilter):"},{"line_number":738,"context_line":"        self._nwfilters[nwfilter._name] \u003d nwfilter"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_00708106","line":735,"updated":"2015-03-16 16:39:56.000000000","message":"So each instance of fakelibvirt can have a different hostinfo now","commit_id":"cd5faf895fcda67d8788fcd80ba5067855051f41"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8a3c5309c483429870d7554a2dca14760597957","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class Connection(object):"},{"line_number":701,"context_line":"    def __init__(self, uri\u003dNone, readonly\u003dFalse, version\u003d9011):"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        if not uri or uri \u003d\u003d \u0027\u0027:"},{"line_number":704,"context_line":"            if allow_default_uri_connection:"},{"line_number":705,"context_line":"                uri \u003d \u0027qemu:///session\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_b68330cc","line":702,"updated":"2015-04-07 14:09:42.000000000","message":"Random whitespace damage!","commit_id":"6a2f045908dd6d56ae973551ccebe304f5403eca"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"75f4b8d9ac119c0a1adbc53ee5c45fbe23586678","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class Connection(object):"},{"line_number":701,"context_line":"    def __init__(self, uri\u003dNone, readonly\u003dFalse, version\u003d9011):"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        if not uri or uri \u003d\u003d \u0027\u0027:"},{"line_number":704,"context_line":"            if allow_default_uri_connection:"},{"line_number":705,"context_line":"                uri \u003d \u0027qemu:///session\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_e3c5658e","line":702,"in_reply_to":"9aa53dc9_b68330cc","updated":"2015-04-07 21:18:30.000000000","message":"Done","commit_id":"6a2f045908dd6d56ae973551ccebe304f5403eca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a8a3c5309c483429870d7554a2dca14760597957","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        self._event_callbacks \u003d {}"},{"line_number":733,"context_line":"        self.fakeLibVersion \u003d version"},{"line_number":734,"context_line":"        self.fakeVersion \u003d version"},{"line_number":735,"context_line":"        self.host_info \u003d HostInfo()"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def _add_filter(self, nwfilter):"},{"line_number":738,"context_line":"        self._nwfilters[nwfilter._name] \u003d nwfilter"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_161e5cba","line":735,"updated":"2015-04-07 14:09:42.000000000","message":"This doesn\u0027t really help anything if it\u0027s not something we can pass in, does it? Seems like defining the base HostInfo is helpful so we can override it in complicated tests, but then we should be able to pass that in here instead of having to pile things onto the base HostInfo.","commit_id":"6a2f045908dd6d56ae973551ccebe304f5403eca"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"75f4b8d9ac119c0a1adbc53ee5c45fbe23586678","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        self._event_callbacks \u003d {}"},{"line_number":733,"context_line":"        self.fakeLibVersion \u003d version"},{"line_number":734,"context_line":"        self.fakeVersion \u003d version"},{"line_number":735,"context_line":"        self.host_info \u003d HostInfo()"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def _add_filter(self, nwfilter):"},{"line_number":738,"context_line":"        self._nwfilters[nwfilter._name] \u003d nwfilter"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_03ce09b4","line":735,"in_reply_to":"9aa53dc9_161e5cba","updated":"2015-04-07 21:18:30.000000000","message":"Done","commit_id":"6a2f045908dd6d56ae973551ccebe304f5403eca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d47624ac39ffa028349cfdf175a82d259617ddc","unresolved":false,"context_lines":[{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def getInfo(self):"},{"line_number":763,"context_line":"        return [node_arch,"},{"line_number":764,"context_line":"                node_kB_mem,"},{"line_number":765,"context_line":"                node_cpus,"},{"line_number":766,"context_line":"                node_mhz,"},{"line_number":767,"context_line":"                node_nodes,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_0fb4e8ce","side":"PARENT","line":764,"updated":"2015-04-07 23:31:55.000000000","message":"Looks like this was the impetus for the difference that Jay mentions above (and to the right). Agree that we should shoot for consistency overall.","commit_id":"6b5e064ee40a16de61fbae7c9e9a66fdb3d7c851"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b56155b38d12bf414d295fa09af27f9e7ef40771","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        \"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.arch \u003d arch"},{"line_number":177,"context_line":"        self.kB_mem \u003d kB_mem"},{"line_number":178,"context_line":"        self.cpus \u003d cpus"},{"line_number":179,"context_line":"        self.cpu_mhz \u003d cpu_mhz"},{"line_number":180,"context_line":"        self.cpu_nodes \u003d cpu_nodes"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_d926cecd","line":177,"updated":"2015-04-07 22:43:04.000000000","message":"nit: would be best to make this kb_mem or even mem_kb. We keep variable names lowercased with underscores.","commit_id":"dc9b09238ff2699b7b7ea2878c8facc40855c6ca"}]}