)]}'
{"id":"openstack%2Fnova~15510","triplet_id":"openstack%2Fnova~master~I260c96b6aa4bbab694b74087f704b6405360b0bf","project":"openstack/nova","branch":"master","topic":"bp/no-db-compute","hashtags":[],"change_id":"I260c96b6aa4bbab694b74087f704b6405360b0bf","subject":"Move security groups and firewall ops to VirtAPI","status":"MERGED","created":"2012-11-06 16:30:32.000000000","updated":"2012-11-12 18:12:45.000000000","submitted":"2012-11-12 18:12:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"73dc2b768ed5ba2564640f18e7b41d6467888bdc","_number":15510,"virtual_id_number":15510,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":2,"date":"2012-11-12 18:12:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":2,"date":"2012-11-11 11:33:20.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2012-11-09 20:11:19.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":1,"date":"2012-11-11 11:33:20.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2012-11-09 20:11:19.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-06 17:52:13.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-11-08 19:24:18.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2012-11-09 20:11:19.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2012-11-11 11:33:20.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2012-11-12 18:12:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"68e8efa133eb8b1e535bb742bf52852f6ca19ed6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 16:58:57.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15510/1/check/gate-nova-merge/11449 : SUCCESS\n- http://logs.openstack.org/15510/1/check/gate-nova-docs/7185 : SUCCESS\n- http://logs.openstack.org/15510/1/check/gate-nova-pep8/12495 : SUCCESS\n- http://logs.openstack.org/15510/1/check/gate-nova-python26/8637 : SUCCESS\n- http://logs.openstack.org/15510/1/check/gate-nova-python27/8705 : SUCCESS\n- http://logs.openstack.org/15510/1/check/gate-tempest-devstack-vm/17247 : SUCCESS\n- http://logs.openstack.org/15510/1/check/gate-nova-pylint/2517 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"940c0e040711e2bdfd54ea16fd81bdcc2acca1d2","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2012-11-06 17:03:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6f4f335bc9c0f42fb4ce72ccdf0ada3d25e57b41","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2012-11-06 17:03:41.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"6e734c3c94b4e79a04b5ccf9d98883ae5115e2d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 17:47:25.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15510/2/check/gate-nova-merge/11458 : SUCCESS\n- http://logs.openstack.org/15510/2/check/gate-nova-docs/7193 : SUCCESS\n- http://logs.openstack.org/15510/2/check/gate-nova-pep8/12503 : SUCCESS\n- http://logs.openstack.org/15510/2/check/gate-nova-python26/8645 : SUCCESS\n- http://logs.openstack.org/15510/2/check/gate-nova-python27/8713 : SUCCESS\n- http://logs.openstack.org/15510/2/check/gate-tempest-devstack-vm/17263 : SUCCESS\n- http://logs.openstack.org/15510/2/check/gate-nova-pylint/2520 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"6cff71301104dbab226bb7a539251ebe537f2b59","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-06 17:52:13.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/44590\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/44588\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/44589\n","accounts_in_message":[],"_revision_number":2},{"id":"c61a1817cf7b30c0fa3cf34a98107e6a37e3b1a5","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-11-07 22:32:34.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"867463014f2f17aea2ae73201d13e39bf95f233d","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2012-11-08 15:13:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"348b27a5d5bbbb5f1fda5c54f21cdcb1cae81a26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-08 16:01:40.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/15510/3/check/gate-nova-merge/11647 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-docs/7381 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-pep8/12691 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-python26/8832 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-python27/8901 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-tempest-devstack-vm/17685 : FAILURE\n- http://logs.openstack.org/15510/3/check/gate-nova-pylint/2609 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"a2711353d39aabdaceb662b0d1fec93b7821665f","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2012-11-08 16:56:10.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"9d1832f259e681fc1484407018169cefef3afde8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-08 17:14:55.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15510/3/check/gate-nova-merge/11655 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-docs/7389 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-pep8/12699 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-python26/8840 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-python27/8909 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-tempest-devstack-vm/17703 : SUCCESS\n- http://logs.openstack.org/15510/3/check/gate-nova-pylint/2617 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"c16a5a0f353becf1688552509030de9257895fd5","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-11-08 19:24:18.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nnits inline... but I think the NoopFirewallDriver issue is real.","accounts_in_message":[],"_revision_number":3},{"id":"b8a3820f0b0558c958999036b05e0ea074e11197","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2012-11-08 19:53:09.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"060a65746a374111c97520a4dee74801353d9be8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-08 20:40:58.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15510/4/check/gate-nova-merge/11682 : SUCCESS\n- http://logs.openstack.org/15510/4/check/gate-nova-docs/7416 : SUCCESS\n- http://logs.openstack.org/15510/4/check/gate-nova-pep8/12726 : SUCCESS\n- http://logs.openstack.org/15510/4/check/gate-nova-python26/8867 : SUCCESS\n- http://logs.openstack.org/15510/4/check/gate-nova-python27/8936 : SUCCESS\n- http://logs.openstack.org/15510/4/check/gate-tempest-devstack-vm/17749 : SUCCESS\n- http://logs.openstack.org/15510/4/check/gate-nova-pylint/2640 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"c65a413be6e054454ed96ca9e2f1308110d8bf66","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-11-09 20:11:19.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"9d672b8e6fc8916544ebcb5c1ddf9b705c654b46","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-11 11:33:20.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"d9d21451f647a79f8ba6039418b721cbdc5da4ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-12 16:25:33.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":4},{"id":"0fff118f344cf3f9143a59f15d4dab22da1050fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-12 16:47:59.000000000","message":"Patch Set 4: Fails\n\nBuild failed\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":4},{"id":"d6540c4b544c3bce46e70e5bab780d4391b71d5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-12 17:14:36.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":4},{"id":"1ef063e924a56c13d08eb0fa07b6ed1d96d8a77e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-12 18:12:43.000000000","message":"Patch Set 4: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15510/4/gate/gate-nova-merge/11868 : SUCCESS\n- http://logs.openstack.org/15510/4/gate/gate-nova-docs/7602 : SUCCESS\n- http://logs.openstack.org/15510/4/gate/gate-nova-pep8/12912 : SUCCESS\n- http://logs.openstack.org/15510/4/gate/gate-nova-python26/9053 : SUCCESS\n- http://logs.openstack.org/15510/4/gate/gate-nova-python27/9122 : SUCCESS\n- http://logs.openstack.org/15510/4/gate/gate-tempest-devstack-vm/18155 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"e77632251b00fe11ae99db1b3e5e6ce7cbc967e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-12 18:12:45.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"83225883eb27ad520b7fb942c129cae5cae17362","revisions":{"8e57fbb0d6636c290590eb24a585c8daf9663b1a":{"kind":"REWORK","_number":1,"created":"2012-11-06 16:30:32.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/10/15510/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/15510/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/15510/1"}}},"commit":{"parents":[{"commit":"ed5763b8d3bde9e31091ca290701e4745fb907b4","subject":"Move host aggregate operations to VirtAPI","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ed5763b8d3bde9e31091ca290701e4745fb907b4"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-06 16:25:00.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-06 16:28:51.000000000","tz":-480},"subject":"Move security groups and firewall ops to VirtAPI","message":"Move security groups and firewall ops to VirtAPI\n\nThis patch moves the following network security-related\nmethods to VirtAPI:\n\n  security_group_get_by_instance()\n  security_group_rule_get_by_security_group()\n  provider_fw_rule_get_all()\n\nIn order to make this change, the _provider_rules() method\nof the FirewallDriver was changed from being a staticmethod\nto a regular instance method. All uses of it were in the\ncontext of an actual instance, so I saw no reason to keep\nit static, which would have complicated the use of the VirtAPI\nmethods.\n\nChange-Id: I260c96b6aa4bbab694b74087f704b6405360b0bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8e57fbb0d6636c290590eb24a585c8daf9663b1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8e57fbb0d6636c290590eb24a585c8daf9663b1a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"ed5763b8d3bde9e31091ca290701e4745fb907b4","is_merged_in_target_branch":false,"change_id":"I006665bfb27774d2eeb713b79c188ca53f6fb00b","change_number":15440,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"6232fa4f31067ad1f07c98c205e53df21af1d2fa":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-11-06 17:03:31.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/10/15510/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/15510/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/15510/2"}}},"commit":{"parents":[{"commit":"ed5763b8d3bde9e31091ca290701e4745fb907b4","subject":"Move host aggregate operations to VirtAPI","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ed5763b8d3bde9e31091ca290701e4745fb907b4"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-06 16:25:00.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-06 17:03:05.000000000","tz":-480},"subject":"Move security groups and firewall ops to VirtAPI","message":"Move security groups and firewall ops to VirtAPI\n\nThis patch moves the following network security-related\nmethods to VirtAPI:\n\n  security_group_get_by_instance()\n  security_group_rule_get_by_security_group()\n  provider_fw_rule_get_all()\n\nIn order to make this change, the _provider_rules() method\nof the FirewallDriver was changed from being a staticmethod\nto a regular instance method. All uses of it were in the\ncontext of an actual instance, so I saw no reason to keep\nit static, which would have complicated the use of the VirtAPI\nmethods.\n\nRelated to bp:no-db-compute\n\nChange-Id: I260c96b6aa4bbab694b74087f704b6405360b0bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6232fa4f31067ad1f07c98c205e53df21af1d2fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6232fa4f31067ad1f07c98c205e53df21af1d2fa"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"ed5763b8d3bde9e31091ca290701e4745fb907b4","is_merged_in_target_branch":false,"change_id":"I006665bfb27774d2eeb713b79c188ca53f6fb00b","change_number":15440,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"3b4a39db36d8044b6392a960a6a892aabdd7c4c3":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2012-11-08 15:13:59.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/10/15510/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/15510/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/15510/3"}}},"commit":{"parents":[{"commit":"cd8ee56f4f8015d39eb9c78639cc769fe1b15d8e","subject":"Move host aggregate operations to VirtAPI","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd8ee56f4f8015d39eb9c78639cc769fe1b15d8e"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-06 16:25:00.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-08 14:41:29.000000000","tz":-480},"subject":"Move security groups and firewall ops to VirtAPI","message":"Move security groups and firewall ops to VirtAPI\n\nThis patch moves the following network security-related\nmethods to VirtAPI:\n\n  security_group_get_by_instance()\n  security_group_rule_get_by_security_group()\n  provider_fw_rule_get_all()\n\nIn order to make this change, the _provider_rules() method\nof the FirewallDriver was changed from being a staticmethod\nto a regular instance method. All uses of it were in the\ncontext of an actual instance, so I saw no reason to keep\nit static, which would have complicated the use of the VirtAPI\nmethods.\n\nRelated to bp:no-db-compute\n\nChange-Id: I260c96b6aa4bbab694b74087f704b6405360b0bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3b4a39db36d8044b6392a960a6a892aabdd7c4c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3b4a39db36d8044b6392a960a6a892aabdd7c4c3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cd8ee56f4f8015d39eb9c78639cc769fe1b15d8e","is_merged_in_target_branch":false,"change_id":"I006665bfb27774d2eeb713b79c188ca53f6fb00b","change_number":15440,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"83225883eb27ad520b7fb942c129cae5cae17362":{"kind":"REWORK","_number":4,"created":"2012-11-08 19:53:09.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/10/15510/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/15510/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/15510/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/15510/4"}}},"commit":{"parents":[{"commit":"a51d60f2ba557926f982d7f6c735ed12e5deb5e9","subject":"Move host aggregate operations to VirtAPI","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a51d60f2ba557926f982d7f6c735ed12e5deb5e9"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-06 16:25:00.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2012-11-08 19:38:30.000000000","tz":-480},"subject":"Move security groups and firewall ops to VirtAPI","message":"Move security groups and firewall ops to VirtAPI\n\nThis patch moves the following network security-related\nmethods to VirtAPI:\n\n  security_group_get_by_instance()\n  security_group_rule_get_by_security_group()\n  provider_fw_rule_get_all()\n\nIn order to make this change, the _provider_rules() method\nof the FirewallDriver was changed from being a staticmethod\nto a regular instance method. All uses of it were in the\ncontext of an actual instance, so I saw no reason to keep\nit static, which would have complicated the use of the VirtAPI\nmethods.\n\nRelated to bp:no-db-compute\n\nChange-Id: I260c96b6aa4bbab694b74087f704b6405360b0bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/83225883eb27ad520b7fb942c129cae5cae17362"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/83225883eb27ad520b7fb942c129cae5cae17362"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a51d60f2ba557926f982d7f6c735ed12e5deb5e9","is_merged_in_target_branch":true,"change_id":"I006665bfb27774d2eeb713b79c188ca53f6fb00b","change_number":15440,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}