)]}'
{"nova/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9972d2ce76c77cb9ac850cf0f9a2ae6288cc8ab8","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \u0027public_key\u0027: \u0027ssh-rsa[ a-zA-Z0-9/+\u003d]*\u0027"},{"line_number":271,"context_line":"                          \u0027Generated-by-Nova\u0027,"},{"line_number":272,"context_line":"            \u0027fingerprint\u0027: \u0027([0-9a-f]{2}:){15}[0-9a-f]{2}\u0027,"},{"line_number":273,"context_line":"            \u0027keypair_type\u0027: \u0027ssh|x509\u0027,"},{"line_number":274,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":275,"context_line":"            \u0027host_name\u0027: \u0027[0-9a-z]{32}\u0027,"},{"line_number":276,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_189bc366","line":273,"updated":"2015-02-12 13:13:36.000000000","message":"I think this should have been left in my keypair api change, since there is introduced the idea of \u0027keypair_type\u0027 in the api. This isn\u0027t breaking anyting, and I\u0027m fine either way. :)","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"72f0ba606a3e4b314f3f74cbda560f6bcbb16d06","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \u0027public_key\u0027: \u0027ssh-rsa[ a-zA-Z0-9/+\u003d]*\u0027"},{"line_number":271,"context_line":"                          \u0027Generated-by-Nova\u0027,"},{"line_number":272,"context_line":"            \u0027fingerprint\u0027: \u0027([0-9a-f]{2}:){15}[0-9a-f]{2}\u0027,"},{"line_number":273,"context_line":"            \u0027keypair_type\u0027: \u0027ssh|x509\u0027,"},{"line_number":274,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":275,"context_line":"            \u0027host_name\u0027: \u0027[0-9a-z]{32}\u0027,"},{"line_number":276,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_eee36902","line":273,"in_reply_to":"da86d52c_0bda7077","updated":"2015-02-12 23:19:29.000000000","message":"ok, will fix","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e0fa474ebb5a253382a9072bcf5b4d54bb676556","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \u0027public_key\u0027: \u0027ssh-rsa[ a-zA-Z0-9/+\u003d]*\u0027"},{"line_number":271,"context_line":"                          \u0027Generated-by-Nova\u0027,"},{"line_number":272,"context_line":"            \u0027fingerprint\u0027: \u0027([0-9a-f]{2}:){15}[0-9a-f]{2}\u0027,"},{"line_number":273,"context_line":"            \u0027keypair_type\u0027: \u0027ssh|x509\u0027,"},{"line_number":274,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":275,"context_line":"            \u0027host_name\u0027: \u0027[0-9a-z]{32}\u0027,"},{"line_number":276,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_0bda7077","line":273,"in_reply_to":"da86d52c_189bc366","updated":"2015-02-12 22:35:35.000000000","message":"yes, this is out of the scope","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"}],"nova/tests/functional/v3/api_sample_base.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e0fa474ebb5a253382a9072bcf5b4d54bb676556","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApiSampleTestBaseV3(api_samples_test_base.ApiSampleTestBase):"},{"line_number":29,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":30,"context_line":"    sample_dir \u003d None"},{"line_number":31,"context_line":"    extra_extensions_to_load \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2bd9f421","line":30,"updated":"2015-02-12 22:35:35.000000000","message":"should we define request_api_version here?","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"72f0ba606a3e4b314f3f74cbda560f6bcbb16d06","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApiSampleTestBaseV3(api_samples_test_base.ApiSampleTestBase):"},{"line_number":29,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":30,"context_line":"    sample_dir \u003d None"},{"line_number":31,"context_line":"    extra_extensions_to_load \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2e13c101","line":30,"in_reply_to":"da86d52c_2bd9f421","updated":"2015-02-12 23:19:29.000000000","message":"No, the value for request_api_version that it inherits from ApiSampleTestBase is fine","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a3df533198e326510b6c2b671ac7a198f848f5fb","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApiSampleTestBaseV3(api_samples_test_base.ApiSampleTestBase):"},{"line_number":29,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":30,"context_line":"    sample_dir \u003d None"},{"line_number":31,"context_line":"    extra_extensions_to_load \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2e42e1aa","line":30,"in_reply_to":"da86d52c_2e13c101","updated":"2015-02-12 23:26:22.000000000","message":"Then it\u0027s None now? \n\nbut this class is v3, we don\u0027t need to make something like \n/v22 ? I remember Claudiu\u0027s patch used to have this","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"a820cce995ed4d666cd91245ab291ef12019d3e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApiSampleTestBaseV3(api_samples_test_base.ApiSampleTestBase):"},{"line_number":29,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":30,"context_line":"    sample_dir \u003d None"},{"line_number":31,"context_line":"    extra_extensions_to_load \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f1926e9d","line":30,"in_reply_to":"da86d52c_2e42e1aa","updated":"2015-02-12 23:43:38.000000000","message":"No, so at least for now we\u0027re leaving the v2.1 (no microversions and equivalent to v2) where they are. So they\u0027ll remain in\n\nnova/doc/v3/api_samples/keypairs/\u003csample_file)\n\nwhereas the microversioned - say v2.2 will end up in:\n\nnova/doc/v3/api_samples/keypairs/v2.2/\u003csanple_file\u003e\n\nWe could eventually put the v2.1 ones in:\n\nnova/doc/v3/api_samples/keypairs/v2.1/\u003csample_file\u003e\n\nbut its not necessary and it will be a huge megapatch which we don\u0027t need to do now.\nWe have loads of renaming to do in the future to remove v3 prefixes at some point.","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"26c357dde8e785961ab73069e8e35e52f17bbc88","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ApiSampleTestBaseV3(api_samples_test_base.ApiSampleTestBase):"},{"line_number":29,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":30,"context_line":"    sample_dir \u003d None"},{"line_number":31,"context_line":"    extra_extensions_to_load \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_15019706","line":30,"in_reply_to":"da86d52c_f1926e9d","updated":"2015-02-13 12:38:52.000000000","message":"ok, make sense to me , thanks","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a3df533198e326510b6c2b671ac7a198f848f5fb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        elif cls.extension_name:"},{"line_number":65,"context_line":"            parts.append(cls.extension_name)"},{"line_number":66,"context_line":"        if api_version:"},{"line_number":67,"context_line":"            parts.append(\u0027v\u0027 + api_version)"},{"line_number":68,"context_line":"        parts.append(name + \".\" + cls.ctype + suffix)"},{"line_number":69,"context_line":"        return os.path.join(*parts)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_6e305956","line":67,"updated":"2015-02-12 23:26:22.000000000","message":"here","commit_id":"111bc2b5ab03c5ae2a89093d538d8ebb1eac185a"}]}