)]}'
{"nova/compute/claims.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        msg \u003d _(\"Attempting claim: memory %(memory_mb)d MB, disk %(disk_gb)d \""},{"line_number":115,"context_line":"                \"GB, VCPUs %(vcpus)d\") % dict(memory_mb\u003dself.memory_mb,"},{"line_number":116,"context_line":"                        disk_gb\u003dself.disk_gb, vcpus\u003dself.vcpus)"},{"line_number":117,"context_line":"        LOG.audit(msg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Test for resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxzs%3D","line":116,"updated":"2012-11-06 23:47:19.000000000","message":"This line is aligned strangely.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        msg \u003d _(\"Attempting claim: memory %(memory_mb)d MB, disk %(disk_gb)d \""},{"line_number":115,"context_line":"                \"GB, VCPUs %(vcpus)d\") % dict(memory_mb\u003dself.memory_mb,"},{"line_number":116,"context_line":"                        disk_gb\u003dself.disk_gb, vcpus\u003dself.vcpus)"},{"line_number":117,"context_line":"        LOG.audit(msg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Test for resources:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxog%3D","line":116,"in_reply_to":"AAAALn%2F%2Fxzs%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        msg \u003d _(\"Attempting claim: memory %(memory_mb)d MB, disk %(disk_gb)d \""},{"line_number":115,"context_line":"                \"GB, VCPUs %(vcpus)d\") % dict(memory_mb\u003dself.memory_mb,"},{"line_number":116,"context_line":"                        disk_gb\u003dself.disk_gb, vcpus\u003dself.vcpus)"},{"line_number":117,"context_line":"        LOG.audit(msg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Test for resources:"},{"line_number":120,"context_line":"        return (self._test_memory(resources, memory_mb_limit) and"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxzo%3D","line":117,"updated":"2012-11-06 23:47:19.000000000","message":"Is there a good reason to not include the instance UUID in this message? I would think instance\u003dself.instance would be a good idea here.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        msg \u003d _(\"Attempting claim: memory %(memory_mb)d MB, disk %(disk_gb)d \""},{"line_number":115,"context_line":"                \"GB, VCPUs %(vcpus)d\") % dict(memory_mb\u003dself.memory_mb,"},{"line_number":116,"context_line":"                        disk_gb\u003dself.disk_gb, vcpus\u003dself.vcpus)"},{"line_number":117,"context_line":"        LOG.audit(msg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Test for resources:"},{"line_number":120,"context_line":"        return (self._test_memory(resources, memory_mb_limit) and"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxoU%3D","line":117,"in_reply_to":"AAAALn%2F%2Fxzo%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # Test for resources:"},{"line_number":120,"context_line":"        return (self._test_memory(resources, memory_mb_limit) and"},{"line_number":121,"context_line":"                self._test_disk(resources, disk_gb_limit) and"},{"line_number":122,"context_line":"                self._test_cpu(resources, vcpu_limit))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def _test_memory(self, resources, memory_mb_limit):"},{"line_number":125,"context_line":"        \"\"\"Test if memory needed for a claim can be safely allocated\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxzg%3D","line":122,"updated":"2012-11-06 23:47:19.000000000","message":"Surely we should log the result of the claim as well? Perhaps in a single log message?","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # Test for resources:"},{"line_number":120,"context_line":"        return (self._test_memory(resources, memory_mb_limit) and"},{"line_number":121,"context_line":"                self._test_disk(resources, disk_gb_limit) and"},{"line_number":122,"context_line":"                self._test_cpu(resources, vcpu_limit))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def _test_memory(self, resources, memory_mb_limit):"},{"line_number":125,"context_line":"        \"\"\"Test if memory needed for a claim can be safely allocated\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxoc%3D","line":122,"in_reply_to":"AAAALn%2F%2Fxzg%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        msg \u003d _(\"Total memory: %(total_mem)d MB, used: %(used_mem)d MB\") \\"},{"line_number":128,"context_line":"                % dict(total_mem\u003dresources[\u0027memory_mb\u0027],"},{"line_number":129,"context_line":"                       used_mem\u003dresources[\u0027memory_mb_used\u0027])"},{"line_number":130,"context_line":"        LOG.audit(msg)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if memory_mb_limit is None:"},{"line_number":133,"context_line":"            # treat memory as unlimited:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxzc%3D","line":130,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        msg \u003d _(\"Total memory: %(total_mem)d MB, used: %(used_mem)d MB\") \\"},{"line_number":128,"context_line":"                % dict(total_mem\u003dresources[\u0027memory_mb\u0027],"},{"line_number":129,"context_line":"                       used_mem\u003dresources[\u0027memory_mb_used\u0027])"},{"line_number":130,"context_line":"        LOG.audit(msg)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if memory_mb_limit is None:"},{"line_number":133,"context_line":"            # treat memory as unlimited:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxoY%3D","line":130,"in_reply_to":"AAAALn%2F%2Fxzc%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if memory_mb_limit is None:"},{"line_number":133,"context_line":"            # treat memory as unlimited:"},{"line_number":134,"context_line":"            LOG.audit(_(\"Memory limit not specified, defaulting to unlimited\"))"},{"line_number":135,"context_line":"            return True"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        free_ram_mb \u003d memory_mb_limit - resources[\u0027memory_mb_used\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxzY%3D","line":134,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if memory_mb_limit is None:"},{"line_number":133,"context_line":"            # treat memory as unlimited:"},{"line_number":134,"context_line":"            LOG.audit(_(\"Memory limit not specified, defaulting to unlimited\"))"},{"line_number":135,"context_line":"            return True"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        free_ram_mb \u003d memory_mb_limit - resources[\u0027memory_mb_used\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxoM%3D","line":134,"in_reply_to":"AAAALn%2F%2FxzY%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # Oversubscribed memory policy info:"},{"line_number":140,"context_line":"        msg \u003d _(\"Memory limit: %(memory_mb_limit)d MB, free: \""},{"line_number":141,"context_line":"                \"%(free_ram_mb)d MB\") % locals()"},{"line_number":142,"context_line":"        LOG.audit(msg)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        can_claim_mem \u003d self.memory_mb \u003c\u003d free_ram_mb"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxzQ%3D","line":142,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # Oversubscribed memory policy info:"},{"line_number":140,"context_line":"        msg \u003d _(\"Memory limit: %(memory_mb_limit)d MB, free: \""},{"line_number":141,"context_line":"                \"%(free_ram_mb)d MB\") % locals()"},{"line_number":142,"context_line":"        LOG.audit(msg)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        can_claim_mem \u003d self.memory_mb \u003c\u003d free_ram_mb"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxoI%3D","line":142,"in_reply_to":"AAAALn%2F%2FxzQ%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free memory %(free_ram_mb)d \""},{"line_number":148,"context_line":"                    \"MB \u003c requested memory %(memory_mb)d MB\") % dict("},{"line_number":149,"context_line":"                            free_ram_mb\u003dfree_ram_mb, memory_mb\u003dself.memory_mb)"},{"line_number":150,"context_line":"            LOG.info(msg)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return can_claim_mem"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxzM%3D","line":150,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free memory %(free_ram_mb)d \""},{"line_number":148,"context_line":"                    \"MB \u003c requested memory %(memory_mb)d MB\") % dict("},{"line_number":149,"context_line":"                            free_ram_mb\u003dfree_ram_mb, memory_mb\u003dself.memory_mb)"},{"line_number":150,"context_line":"            LOG.info(msg)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return can_claim_mem"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxoE%3D","line":150,"in_reply_to":"AAAALn%2F%2FxzM%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                \"%(free_disk)d GB\") % dict("},{"line_number":159,"context_line":"                        total_disk\u003dresources[\u0027local_gb\u0027],"},{"line_number":160,"context_line":"                        used_disk\u003dresources[\u0027local_gb_used\u0027],"},{"line_number":161,"context_line":"                        free_disk\u003dresources[\u0027free_disk_gb\u0027])"},{"line_number":162,"context_line":"        LOG.audit(msg)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if disk_gb_limit is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxzI%3D","line":161,"updated":"2012-11-06 23:47:19.000000000","message":"Why is this block formatted like this?","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                \"%(free_disk)d GB\") % dict("},{"line_number":159,"context_line":"                        total_disk\u003dresources[\u0027local_gb\u0027],"},{"line_number":160,"context_line":"                        used_disk\u003dresources[\u0027local_gb_used\u0027],"},{"line_number":161,"context_line":"                        free_disk\u003dresources[\u0027free_disk_gb\u0027])"},{"line_number":162,"context_line":"        LOG.audit(msg)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if disk_gb_limit is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxn0%3D","line":161,"in_reply_to":"AAAALn%2F%2FxzI%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                        total_disk\u003dresources[\u0027local_gb\u0027],"},{"line_number":160,"context_line":"                        used_disk\u003dresources[\u0027local_gb_used\u0027],"},{"line_number":161,"context_line":"                        free_disk\u003dresources[\u0027free_disk_gb\u0027])"},{"line_number":162,"context_line":"        LOG.audit(msg)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if disk_gb_limit is None:"},{"line_number":165,"context_line":"            # treat disk as unlimited:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxzE%3D","line":162,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                        total_disk\u003dresources[\u0027local_gb\u0027],"},{"line_number":160,"context_line":"                        used_disk\u003dresources[\u0027local_gb_used\u0027],"},{"line_number":161,"context_line":"                        free_disk\u003dresources[\u0027free_disk_gb\u0027])"},{"line_number":162,"context_line":"        LOG.audit(msg)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if disk_gb_limit is None:"},{"line_number":165,"context_line":"            # treat disk as unlimited:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxnw%3D","line":162,"in_reply_to":"AAAALn%2F%2FxzE%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if disk_gb_limit is None:"},{"line_number":165,"context_line":"            # treat disk as unlimited:"},{"line_number":166,"context_line":"            LOG.audit(_(\"Disk limit not specified, defaulting to unlimited\"))"},{"line_number":167,"context_line":"            return True"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        free_disk_gb \u003d disk_gb_limit - resources[\u0027local_gb_used\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxy8%3D","line":166,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if disk_gb_limit is None:"},{"line_number":165,"context_line":"            # treat disk as unlimited:"},{"line_number":166,"context_line":"            LOG.audit(_(\"Disk limit not specified, defaulting to unlimited\"))"},{"line_number":167,"context_line":"            return True"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        free_disk_gb \u003d disk_gb_limit - resources[\u0027local_gb_used\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxns%3D","line":166,"in_reply_to":"AAAALn%2F%2Fxy8%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # Oversubscribed disk policy info:"},{"line_number":172,"context_line":"        msg \u003d _(\"Disk limit: %(disk_gb_limit)d GB, free: \""},{"line_number":173,"context_line":"                \"%(free_disk_gb)d GB\") % locals()"},{"line_number":174,"context_line":"        LOG.audit(msg)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        can_claim_disk \u003d self.disk_gb \u003c\u003d free_disk_gb"},{"line_number":177,"context_line":"        if not can_claim_disk:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxy4%3D","line":174,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # Oversubscribed disk policy info:"},{"line_number":172,"context_line":"        msg \u003d _(\"Disk limit: %(disk_gb_limit)d GB, free: \""},{"line_number":173,"context_line":"                \"%(free_disk_gb)d GB\") % locals()"},{"line_number":174,"context_line":"        LOG.audit(msg)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        can_claim_disk \u003d self.disk_gb \u003c\u003d free_disk_gb"},{"line_number":177,"context_line":"        if not can_claim_disk:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxno%3D","line":174,"in_reply_to":"AAAALn%2F%2Fxy4%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        if not can_claim_disk:"},{"line_number":178,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free disk %(free_disk_gb)d GB\""},{"line_number":179,"context_line":"                    \" \u003c requested disk %(disk_gb)d GB\") % dict("},{"line_number":180,"context_line":"                            free_disk_gb\u003dfree_disk_gb, disk_gb\u003dself.disk_gb)"},{"line_number":181,"context_line":"            LOG.info(msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return can_claim_disk"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxy0%3D","line":180,"updated":"2012-11-06 23:47:19.000000000","message":"This could be better formatted.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        if not can_claim_disk:"},{"line_number":178,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free disk %(free_disk_gb)d GB\""},{"line_number":179,"context_line":"                    \" \u003c requested disk %(disk_gb)d GB\") % dict("},{"line_number":180,"context_line":"                            free_disk_gb\u003dfree_disk_gb, disk_gb\u003dself.disk_gb)"},{"line_number":181,"context_line":"            LOG.info(msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return can_claim_disk"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxng%3D","line":180,"in_reply_to":"AAAALn%2F%2Fxy0%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free disk %(free_disk_gb)d GB\""},{"line_number":179,"context_line":"                    \" \u003c requested disk %(disk_gb)d GB\") % dict("},{"line_number":180,"context_line":"                            free_disk_gb\u003dfree_disk_gb, disk_gb\u003dself.disk_gb)"},{"line_number":181,"context_line":"            LOG.info(msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return can_claim_disk"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxyw%3D","line":181,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free disk %(free_disk_gb)d GB\""},{"line_number":179,"context_line":"                    \" \u003c requested disk %(disk_gb)d GB\") % dict("},{"line_number":180,"context_line":"                            free_disk_gb\u003dfree_disk_gb, disk_gb\u003dself.disk_gb)"},{"line_number":181,"context_line":"            LOG.info(msg)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return can_claim_disk"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxnc%3D","line":181,"in_reply_to":"AAAALn%2F%2Fxyw%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        msg \u003d _(\"Total VCPUs: %(total_vcpus)d, used: %(used_vcpus)d\") \\"},{"line_number":189,"context_line":"                % dict(total_vcpus\u003dresources[\u0027vcpus\u0027],"},{"line_number":190,"context_line":"                       used_vcpus\u003dresources[\u0027vcpus_used\u0027])"},{"line_number":191,"context_line":"        LOG.audit(msg)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if vcpu_limit is None:"},{"line_number":194,"context_line":"            # treat cpu as unlimited:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxys%3D","line":191,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        msg \u003d _(\"Total VCPUs: %(total_vcpus)d, used: %(used_vcpus)d\") \\"},{"line_number":189,"context_line":"                % dict(total_vcpus\u003dresources[\u0027vcpus\u0027],"},{"line_number":190,"context_line":"                       used_vcpus\u003dresources[\u0027vcpus_used\u0027])"},{"line_number":191,"context_line":"        LOG.audit(msg)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if vcpu_limit is None:"},{"line_number":194,"context_line":"            # treat cpu as unlimited:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxnY%3D","line":191,"in_reply_to":"AAAALn%2F%2Fxys%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if vcpu_limit is None:"},{"line_number":194,"context_line":"            # treat cpu as unlimited:"},{"line_number":195,"context_line":"            LOG.audit(_(\"VCPU limit not specified, defaulting to unlimited\"))"},{"line_number":196,"context_line":"            return True"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Oversubscribed disk policy info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxyo%3D","line":195,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if vcpu_limit is None:"},{"line_number":194,"context_line":"            # treat cpu as unlimited:"},{"line_number":195,"context_line":"            LOG.audit(_(\"VCPU limit not specified, defaulting to unlimited\"))"},{"line_number":196,"context_line":"            return True"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Oversubscribed disk policy info:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxnQ%3D","line":195,"in_reply_to":"AAAALn%2F%2Fxyo%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Oversubscribed disk policy info:"},{"line_number":199,"context_line":"        msg \u003d _(\"CPU limit: %(vcpu_limit)d\") % locals()"},{"line_number":200,"context_line":"        LOG.audit(msg)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        free_vcpus \u003d vcpu_limit - resources[\u0027vcpus_used\u0027]"},{"line_number":203,"context_line":"        can_claim_cpu \u003d self.vcpus \u003c\u003d free_vcpus"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxyk%3D","line":200,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Oversubscribed disk policy info:"},{"line_number":199,"context_line":"        msg \u003d _(\"CPU limit: %(vcpu_limit)d\") % locals()"},{"line_number":200,"context_line":"        LOG.audit(msg)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        free_vcpus \u003d vcpu_limit - resources[\u0027vcpus_used\u0027]"},{"line_number":203,"context_line":"        can_claim_cpu \u003d self.vcpus \u003c\u003d free_vcpus"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxnU%3D","line":200,"in_reply_to":"AAAALn%2F%2Fxyk%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if not can_claim_cpu:"},{"line_number":206,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free CPU %(free_vcpus)d \u003c \""},{"line_number":207,"context_line":"                    \"requested CPU %(vcpus)d\") % dict(free_vcpus\u003dfree_vcpus,"},{"line_number":208,"context_line":"                            vcpus\u003dself.vcpus)"},{"line_number":209,"context_line":"            LOG.info(msg)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        return can_claim_cpu"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxyc%3D","line":208,"updated":"2012-11-06 23:47:19.000000000","message":"Strangely formatted.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if not can_claim_cpu:"},{"line_number":206,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free CPU %(free_vcpus)d \u003c \""},{"line_number":207,"context_line":"                    \"requested CPU %(vcpus)d\") % dict(free_vcpus\u003dfree_vcpus,"},{"line_number":208,"context_line":"                            vcpus\u003dself.vcpus)"},{"line_number":209,"context_line":"            LOG.info(msg)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        return can_claim_cpu"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxnI%3D","line":208,"in_reply_to":"AAAALn%2F%2Fxyc%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free CPU %(free_vcpus)d \u003c \""},{"line_number":207,"context_line":"                    \"requested CPU %(vcpus)d\") % dict(free_vcpus\u003dfree_vcpus,"},{"line_number":208,"context_line":"                            vcpus\u003dself.vcpus)"},{"line_number":209,"context_line":"            LOG.info(msg)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        return can_claim_cpu"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxyg%3D","line":209,"updated":"2012-11-06 23:47:19.000000000","message":"Ditto on including instance.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            msg \u003d _(\"Unable to claim resources.  Free CPU %(free_vcpus)d \u003c \""},{"line_number":207,"context_line":"                    \"requested CPU %(vcpus)d\") % dict(free_vcpus\u003dfree_vcpus,"},{"line_number":208,"context_line":"                            vcpus\u003dself.vcpus)"},{"line_number":209,"context_line":"            LOG.info(msg)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        return can_claim_cpu"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxnM%3D","line":209,"in_reply_to":"AAAALn%2F%2Fxyg%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"32e831e8ee8feedafcd1de1732ea6a046e7679c5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            LOG.audit(_(\"Claim successful\"), instance\u003dself.instance)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            LOG.audit(_(\"Claim failed\"), instance\u003dself.instance)"},{"line_number":129,"context_line":"        "},{"line_number":130,"context_line":"        return can_claim"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _test_memory(self, resources, memory_mb_limit):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALn%2F%2FxKQ%3D","line":129,"updated":"2012-11-07 16:21:27.000000000","message":"PEP8 error","commit_id":"d309ecf9a15b84fcf15c3591278e439da28fe69c"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"287a5f169424bd5e2bb8c969e49b1bf3c40dac04","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            LOG.audit(_(\"Claim successful\"), instance\u003dself.instance)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            LOG.audit(_(\"Claim failed\"), instance\u003dself.instance)"},{"line_number":129,"context_line":"        "},{"line_number":130,"context_line":"        return can_claim"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _test_memory(self, resources, memory_mb_limit):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALn%2F%2FxJU%3D","line":129,"in_reply_to":"AAAALn%2F%2FxKQ%3D","updated":"2012-11-07 16:33:14.000000000","message":"Done","commit_id":"d309ecf9a15b84fcf15c3591278e439da28fe69c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d31a5663b383783877117511041d4f222ea83414","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return can_claim"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _test_memory(self, resources, memory_mb_limit):"},{"line_number":133,"context_line":"        \"\"\"Test if memory needed for a claim can be safely allocated\"\"\""},{"line_number":134,"context_line":"        # Installed memory and usage info:"},{"line_number":135,"context_line":"        msg \u003d _(\"Total memory: %(total_mem)d MB, used: %(used_mem)d MB\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2FxIs%3D","line":132,"updated":"2012-11-07 16:46:26.000000000","message":"You know, these _test_*() methods all look very similar to me; makes me wonder if there\u0027s any way to collapse them down to reduce the repetition?  Probably not easily, but thought I\u0027d raise the comment, at least.","commit_id":"1109fcc597def142155f7206ceaaf410b2ee43cc"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"f7de44c22e50643de9b4fb61622ddf78fdc9951e","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return can_claim"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _test_memory(self, resources, memory_mb_limit):"},{"line_number":133,"context_line":"        \"\"\"Test if memory needed for a claim can be safely allocated\"\"\""},{"line_number":134,"context_line":"        # Installed memory and usage info:"},{"line_number":135,"context_line":"        msg \u003d _(\"Total memory: %(total_mem)d MB, used: %(used_mem)d MB\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2Fw80%3D","line":132,"in_reply_to":"AAAALn%2F%2FxIs%3D","updated":"2012-11-07 19:45:14.000000000","message":"Done","commit_id":"1109fcc597def142155f7206ceaaf410b2ee43cc"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03932dd0580e41cccebbedb223d6c64bb3f1826f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"model."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from contextlib import contextmanager"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from nova.compute import claims"},{"line_number":25,"context_line":"from nova.compute import vm_states"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2FyAY%3D","line":22,"updated":"2012-11-06 20:50:43.000000000","message":"Importing an object rather than a module…","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"dfbfedbc7d80a2f31bf88952a4785f531d91baf2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"model."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from contextlib import contextmanager"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from nova.compute import claims"},{"line_number":25,"context_line":"from nova.compute import vm_states"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2Bw%3D","line":22,"in_reply_to":"AAAALn%2F%2FyAY%3D","updated":"2012-11-06 21:20:23.000000000","message":"Done","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03932dd0580e41cccebbedb223d6c64bb3f1826f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        :param limits: Dict of oversubscription limits for memory, disk,"},{"line_number":77,"context_line":"                       and CPUs."},{"line_number":78,"context_line":"        :returns: A Claim ticket representing the reserved resources.  This"},{"line_number":79,"context_line":"                  should be turned into finalize  a resource claim or free"},{"line_number":80,"context_line":"                  resources after the compute operation is finished."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        if self.disabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2FyAI%3D","line":79,"updated":"2012-11-06 20:50:43.000000000","message":"Do you mean, \"should be turned in to finalize…\"?","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"dfbfedbc7d80a2f31bf88952a4785f531d91baf2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        :param limits: Dict of oversubscription limits for memory, disk,"},{"line_number":77,"context_line":"                       and CPUs."},{"line_number":78,"context_line":"        :returns: A Claim ticket representing the reserved resources.  This"},{"line_number":79,"context_line":"                  should be turned into finalize  a resource claim or free"},{"line_number":80,"context_line":"                  resources after the compute operation is finished."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        if self.disabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2Bg%3D","line":79,"in_reply_to":"AAAALn%2F%2FyAI%3D","updated":"2012-11-06 21:20:23.000000000","message":"This is old, I\u0027ll fix it up...","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"}],"nova/tests/compute/test_claims.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03932dd0580e41cccebbedb223d6c64bb3f1826f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            resources.update(values)"},{"line_number":59,"context_line":"        return resources"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def testCpuUnlimited(self):"},{"line_number":62,"context_line":"        \"\"\"Test default of unlimited CPU\"\"\""},{"line_number":63,"context_line":"        instance \u003d self._fake_instance(vcpus\u003d100000)"},{"line_number":64,"context_line":"        claim \u003d claims.Claim(instance, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2F8%3D","line":61,"updated":"2012-11-06 20:50:43.000000000","message":"Eh.  I\u0027d prefer snake_case to camelCase here.","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"dfbfedbc7d80a2f31bf88952a4785f531d91baf2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            resources.update(values)"},{"line_number":59,"context_line":"        return resources"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def testCpuUnlimited(self):"},{"line_number":62,"context_line":"        \"\"\"Test default of unlimited CPU\"\"\""},{"line_number":63,"context_line":"        instance \u003d self._fake_instance(vcpus\u003d100000)"},{"line_number":64,"context_line":"        claim \u003d claims.Claim(instance, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2Bc%3D","line":61,"in_reply_to":"AAAALn%2F%2Fx%2F8%3D","updated":"2012-11-06 21:20:23.000000000","message":"Yeah brain fart, remnant of old Java days.  Mea culpa.","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0c0d4356a3770e552ed7b5471678bab4c1efe01a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return resources"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_cpu_unlimited(self):"},{"line_number":62,"context_line":"        \"\"\"Test default of unlimited CPU\"\"\""},{"line_number":63,"context_line":"        instance \u003d self._fake_instance(vcpus\u003d100000)"},{"line_number":64,"context_line":"        claim \u003d claims.Claim(instance, None)"},{"line_number":65,"context_line":"        self.assertTrue(claim.test(self.resources))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fx6Q%3D","line":62,"updated":"2012-11-06 22:12:15.000000000","message":"femtonit: I don\u0027t like having docstrings on test methods, because nose reports that docstring instead of the name of the test in the failures summary…","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return resources"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_cpu_unlimited(self):"},{"line_number":62,"context_line":"        \"\"\"Test default of unlimited CPU\"\"\""},{"line_number":63,"context_line":"        instance \u003d self._fake_instance(vcpus\u003d100000)"},{"line_number":64,"context_line":"        claim \u003d claims.Claim(instance, None)"},{"line_number":65,"context_line":"        self.assertTrue(claim.test(self.resources))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxyY%3D","line":62,"in_reply_to":"AAAALn%2F%2Fx6Q%3D","updated":"2012-11-06 23:47:19.000000000","message":"Agreed. I\u0027d ask you to strip out all of these doc strings.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return resources"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_cpu_unlimited(self):"},{"line_number":62,"context_line":"        \"\"\"Test default of unlimited CPU\"\"\""},{"line_number":63,"context_line":"        instance \u003d self._fake_instance(vcpus\u003d100000)"},{"line_number":64,"context_line":"        claim \u003d claims.Claim(instance, None)"},{"line_number":65,"context_line":"        self.assertTrue(claim.test(self.resources))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxow%3D","line":62,"in_reply_to":"AAAALn%2F%2Fx6Q%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return resources"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_cpu_unlimited(self):"},{"line_number":62,"context_line":"        \"\"\"Test default of unlimited CPU\"\"\""},{"line_number":63,"context_line":"        instance \u003d self._fake_instance(vcpus\u003d100000)"},{"line_number":64,"context_line":"        claim \u003d claims.Claim(instance, None)"},{"line_number":65,"context_line":"        self.assertTrue(claim.test(self.resources))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxos%3D","line":62,"in_reply_to":"AAAALn%2F%2FxyY%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"}],"nova/tests/compute/test_resource_tracker.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03932dd0580e41cccebbedb223d6c64bb3f1826f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class UnsupportedVirtDriver(driver.ComputeDriver):"},{"line_number":42,"context_line":"    \"\"\"Pretend version of a lame virt driver\"\"\""},{"line_number":43,"context_line":"    def __init__(self):"},{"line_number":44,"context_line":"        pass"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_available_resource(self):"},{"line_number":47,"context_line":"        # no support for getting resource usage info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2F4%3D","line":44,"updated":"2012-11-06 20:50:43.000000000","message":"Hmmm, do you need to include a call to super() here, i.e.,\n\n    super(UnsupportedVirtDriver, self).__init__(None)","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"dfbfedbc7d80a2f31bf88952a4785f531d91baf2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class UnsupportedVirtDriver(driver.ComputeDriver):"},{"line_number":42,"context_line":"    \"\"\"Pretend version of a lame virt driver\"\"\""},{"line_number":43,"context_line":"    def __init__(self):"},{"line_number":44,"context_line":"        pass"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_available_resource(self):"},{"line_number":47,"context_line":"        # no support for getting resource usage info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2BY%3D","line":44,"in_reply_to":"AAAALn%2F%2Fx%2F4%3D","updated":"2012-11-06 21:20:23.000000000","message":"Yeah, I suppose I could add one, doesn\u0027t really matter since the super class init doesn\u0027t actually do anything.","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"03932dd0580e41cccebbedb223d6c64bb3f1826f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.vcpus \u003d FAKE_VIRT_VCPUS"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.memory_mb_used \u003d 0"},{"line_number":59,"context_line":"        self.local_gb_used \u003d 0"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_available_resource(self):"},{"line_number":62,"context_line":"        d \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2Fw%3D","line":59,"updated":"2012-11-06 20:50:43.000000000","message":"Similarly, do you need a super() call here?","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"dfbfedbc7d80a2f31bf88952a4785f531d91baf2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.vcpus \u003d FAKE_VIRT_VCPUS"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.memory_mb_used \u003d 0"},{"line_number":59,"context_line":"        self.local_gb_used \u003d 0"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_available_resource(self):"},{"line_number":62,"context_line":"        d \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fx%2BU%3D","line":59,"in_reply_to":"AAAALn%2F%2Fx%2Fw%3D","updated":"2012-11-06 21:20:23.000000000","message":"Done","commit_id":"b8097cec06671b980b7ad764bf4a2dd9acc8b3c0"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a68962257605c6530db51e33259e870acdb53124","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def testUpdateUseOnlyForTracked(self):"},{"line_number":282,"context_line":"        \"\"\"Only update usage is a previous claim has added instance to"},{"line_number":283,"context_line":"        list of tracked instances."},{"line_number":284,"context_line":"        \"\"\""},{"line_number":285,"context_line":"        instance \u003d self._fake_instance(memory_mb\u003d3, root_gb\u003d1, ephemeral_gb\u003d1,"},{"line_number":286,"context_line":"                task_state\u003dNone)"},{"line_number":287,"context_line":"        self.tracker.update_usage(self.context, instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FxyU%3D","line":284,"updated":"2012-11-06 23:47:19.000000000","message":"Please remove this doc string as well.","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"472bd3cef8545075a947b82ec69e376d931a8953","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    def testUpdateUseOnlyForTracked(self):"},{"line_number":282,"context_line":"        \"\"\"Only update usage is a previous claim has added instance to"},{"line_number":283,"context_line":"        list of tracked instances."},{"line_number":284,"context_line":"        \"\"\""},{"line_number":285,"context_line":"        instance \u003d self._fake_instance(memory_mb\u003d3, root_gb\u003d1, ephemeral_gb\u003d1,"},{"line_number":286,"context_line":"                task_state\u003dNone)"},{"line_number":287,"context_line":"        self.tracker.update_usage(self.context, instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fxo4%3D","line":284,"in_reply_to":"AAAALn%2F%2FxyU%3D","updated":"2012-11-07 04:55:51.000000000","message":"Done","commit_id":"6f2e5a09726d85845b8103616d7609494096f6a8"}]}