)]}'
{"nova/virt/libvirt/config.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b2a7b815aa5ee6b768267cd187e3eafc0ba4549e","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        if self.model:"},{"line_number":461,"context_line":"            dev.append(etree.Element(\"model\", type\u003dself.model))"},{"line_number":462,"context_line":"        if self.net_type \u003d\u003d \"ethernet\":"},{"line_number":463,"context_line":"            if self.script is not None and CONF.libvirt_type !\u003d \"xen\":"},{"line_number":464,"context_line":"                dev.append(etree.Element(\"script\", path\u003dself.script))"},{"line_number":465,"context_line":"            dev.append(etree.Element(\"target\", dev\u003dself.target_dev))"},{"line_number":466,"context_line":"        elif self.net_type \u003d\u003d \"direct\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F%2Fc4%3D","line":463,"updated":"2012-11-12 16:51:04.000000000","message":"No, please don\u0027t do this here. The code in config.py should *ONLY* concern itself with correctly translating  XML \u003c-\u003e Python objects. It should never include any kind of policy based logic such as this. If the \"script\" attribute should not be set for Xen, then the *caller* of this API should be updated to not set this property in the first place.","commit_id":"6312f4c76fdd1eb894fdcea6b1ad3af2f3c54982"}]}