)]}'
{"id":"openstack%2Fnova~15607","triplet_id":"openstack%2Fnova~master~Icc510a55282b479b3ba673ac68aee793da1714fb","project":"openstack/nova","branch":"master","topic":"yield-during-hashing","hashtags":[],"change_id":"Icc510a55282b479b3ba673ac68aee793da1714fb","subject":"Yield in between hash runs for the image cache manager.","status":"MERGED","created":"2012-11-08 01:13:34.000000000","updated":"2012-11-19 22:22:08.000000000","submitted":"2012-11-19 22:22:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76d7d3a8b87175eed4cf3d33d01107eba9138b4c","_number":15607,"virtual_id_number":15607,"owner":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2012-11-19 22:22:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":1,"date":"2012-11-08 03:34:30.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"date":"2012-11-15 07:34:23.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2012-11-08 09:12:04.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-11-08 09:34:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":-1,"date":"2012-11-14 03:07:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2012-11-14 05:31:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":2,"date":"2012-11-19 21:58:18.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"date":"2012-11-08 09:12:04.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-11-08 09:34:19.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-11-14 03:07:48.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2012-11-14 05:31:27.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":1,"date":"2012-11-19 21:58:18.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-08 03:34:30.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-11-08 09:12:04.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-11-08 09:34:19.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-11-14 03:07:48.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2012-11-15 07:34:23.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2012-11-19 21:58:18.000000000","updated_by":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"reviewer":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"state":"REVIEWER"},{"updated":"2012-11-19 22:22:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c5aed20c3a5468ac716065cab8990d3d5f6c2a6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-08 01:35:56.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15607/1/check/gate-nova-merge/11611 : SUCCESS\n- http://logs.openstack.org/15607/1/check/gate-nova-docs/7345 : SUCCESS\n- http://logs.openstack.org/15607/1/check/gate-nova-pep8/12655 : SUCCESS\n- http://logs.openstack.org/15607/1/check/gate-nova-python26/8796 : SUCCESS\n- http://logs.openstack.org/15607/1/check/gate-nova-python27/8865 : SUCCESS\n- http://logs.openstack.org/15607/1/check/gate-tempest-devstack-vm/17606 : SUCCESS\n- http://logs.openstack.org/15607/1/check/gate-nova-pylint/2587 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"ebf7d2a50a18892ffee450525e4ce60113719dab","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-08 03:34:30.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/45048\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/45019\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/45047\n","accounts_in_message":[],"_revision_number":1},{"id":"aed048eca6a99074da9034b1d9d451a6f6e98d3f","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-11-08 09:12:04.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b4d6eab2180a7bc35ef8478c02f8d574f1e34294","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-11-08 09:34:19.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nYou could have a 100G image on a 20MB/s disk, and so still block nova for long periods of time, so this gets a +1 for being better but not a +2 because it doesn\u0027t actually solve anything I think.\n\nThe idea of calling out to sha1sum was better I think as\nit allowed nova to run concurrently with all the hashing?\n\nOn a general note, I\u0027m wondering if this additional \nchecksumming is warranted at all given the overhead.\nIf its used for functional advantage for image id or\nsomething then maybe, but if only used for verification\nit seems like overkill?\n\nAnother general note is it would be cool if qcow could \ncache checksums internally that would be invalidated on write.\nEven better would be if it cached checksums for portions\nof the file so that only portions would need to be rehashed.\nThis could all (well apart from the invalidate on write bit)\nbe encapsulated in `qemu-img checksum` which would just\nreturn the cached checksum or reshash the portions of the \nfile as needed.","accounts_in_message":[],"_revision_number":1},{"id":"248f47f0a1fcedbeba80d395523fb51e7eb87372","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-11-14 03:07:48.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nWhile this change is relatively harmless, I think pbrady\u0027s point of pushing the hashing to another process is a better solution.","accounts_in_message":[],"_revision_number":1},{"id":"9fd1baeaf256efe981d2eb03768111962fa494c7","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2012-11-14 05:31:27.000000000","message":"Patch Set 1:\n\nI assert that this doesn\u0027t do any harm and therefore should go in. I suspect I\u0027m not going to win that fight though.","accounts_in_message":[],"_revision_number":1},{"id":"34345372c7f1ce9446d724314e6c01c00ebe2a36","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2012-11-15 07:34:23.000000000","message":"Patch Set 1:\n\nOut of process would be great, and possibly even allow simpler algos to be used (not always sha1/md5 would be useful in making the whole hashing go quicker).","accounts_in_message":[],"_revision_number":1},{"id":"58bbbc193c3751786bc9dcd8e265f4cb3a334dde","author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"date":"2012-11-19 21:58:18.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nI agree that there are much better solutions than this one, like what draigbrady and russellb suggested. But it shouldn\u0027t hold this one off because it does seem to make the problem slightly better. So I\u0027m +2 this. :)","accounts_in_message":[],"_revision_number":1},{"id":"16a28b813c0527798e4c777372d810d20ccad27f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-19 21:58:38.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"ce817241b125654d54bae4f1c46ed3ba46f45f60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-19 22:22:06.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15607/1/gate/gate-nova-merge/12447 : SUCCESS\n- http://logs.openstack.org/15607/1/gate/gate-nova-docs/8178 : SUCCESS\n- http://logs.openstack.org/15607/1/gate/gate-nova-pep8/13488 : SUCCESS\n- http://logs.openstack.org/15607/1/gate/gate-nova-python26/9629 : SUCCESS\n- http://logs.openstack.org/15607/1/gate/gate-nova-python27/9698 : SUCCESS\n- http://logs.openstack.org/15607/1/gate/gate-tempest-devstack-vm/19185 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"3aadb9cc93c79095e9c0c8c4968c5c2ded728e8a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-19 22:22:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f2d5869d8c83cf420fc29cecbefc42d2d2f65839","revisions":{"f2d5869d8c83cf420fc29cecbefc42d2d2f65839":{"kind":"REWORK","_number":1,"created":"2012-11-08 01:13:34.000000000","uploader":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"ref":"refs/changes/07/15607/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/07/15607/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/15607/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/15607/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/07/15607/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/07/15607/1"}}},"commit":{"parents":[{"commit":"7f1f2ef86855d436bf7ff9ce7194eb90b857d518","subject":"Merge \"Refactor resource tracker claims and test logic.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7f1f2ef86855d436bf7ff9ce7194eb90b857d518"}]}],"author":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-08 01:12:30.000000000","tz":660},"committer":{"name":"Michael Still","email":"mikal@stillhq.com","date":"2012-11-08 01:12:30.000000000","tz":660},"subject":"Yield in between hash runs for the image cache manager.","message":"Yield in between hash runs for the image cache manager.\n\nThis should stop the cache manager from locking up nova-compute for\nlong periods of time.\n\nChange-Id: Icc510a55282b479b3ba673ac68aee793da1714fb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2d5869d8c83cf420fc29cecbefc42d2d2f65839"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2d5869d8c83cf420fc29cecbefc42d2d2f65839"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}