)]}'
{"nova/filters.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"21d2109c75c5d1d9508f60f36f09d1d74a22f81a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class BaseFilterPlugin(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for all filter plugin classes.\"\"\""},{"line_number":25,"context_line":"    def _filter_one(self, obj, filter_properties):"},{"line_number":26,"context_line":"        \"\"\"Return True if it passes the filter, False overwise."},{"line_number":27,"context_line":"        Override this in a subclass."},{"line_number":28,"context_line":"        \"\"\""},{"line_number":29,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fu94%3D","line":26,"updated":"2012-11-09 14:44:07.000000000","message":"should be \"otherwise\"","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"30e6f0c8c4d76424b7bf0d8a31723d48b2f2021c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class BaseFilterPlugin(object):"},{"line_number":24,"context_line":"    \"\"\"Base class for all filter plugin classes.\"\"\""},{"line_number":25,"context_line":"    def _filter_one(self, obj, filter_properties):"},{"line_number":26,"context_line":"        \"\"\"Return True if it passes the filter, False overwise."},{"line_number":27,"context_line":"        Override this in a subclass."},{"line_number":28,"context_line":"        \"\"\""},{"line_number":29,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F9sU%3D","line":26,"in_reply_to":"AAAALn%2F%2Fu94%3D","updated":"2012-11-13 23:27:52.000000000","message":"Fixed.","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b0d3e2091240613fae2da13d0ee2518aff92dcc4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        return True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def filter_all(self, filter_obj_list, filter_properties):"},{"line_number":32,"context_line":"        \"\"\"Return a list of objects that pass all filters.\"\"\""},{"line_number":33,"context_line":"        for obj in filter_obj_list:"},{"line_number":34,"context_line":"            if self._filter_one(obj, filter_properties):"},{"line_number":35,"context_line":"                yield obj"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F80M%3D","line":32,"updated":"2012-11-14 16:53:16.000000000","message":"Return a generator....","commit_id":"53c0c0f3ac0cb89db950a1dd25a6f5fee5ca7444"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"83d2b316954dddd5a96d361f4d9e39c0c2c9427a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        return True"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def filter_all(self, filter_obj_list, filter_properties):"},{"line_number":32,"context_line":"        \"\"\"Return a list of objects that pass all filters.\"\"\""},{"line_number":33,"context_line":"        for obj in filter_obj_list:"},{"line_number":34,"context_line":"            if self._filter_one(obj, filter_properties):"},{"line_number":35,"context_line":"                yield obj"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F8jk%3D","line":32,"in_reply_to":"AAAAMH%2F%2F80M%3D","updated":"2012-11-14 19:15:36.000000000","message":"Thanks... changed it and gave a little more info.","commit_id":"53c0c0f3ac0cb89db950a1dd25a6f5fee5ca7444"}],"nova/plugins.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"21d2109c75c5d1d9508f60f36f09d1d74a22f81a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        classes \u003d []"},{"line_number":43,"context_line":"        module \u003d importutils.import_module(module_name)"},{"line_number":44,"context_line":"        for obj_name in dir(module):"},{"line_number":45,"context_line":"            itm \u003d getattr(module, obj_name)"},{"line_number":46,"context_line":"            if self._is_plugin_class(itm):"},{"line_number":47,"context_line":"                classes.append(itm)"},{"line_number":48,"context_line":"        return classes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fu9o%3D","line":45,"updated":"2012-11-09 14:44:07.000000000","message":"was this supposed to be \"item\"?","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"30e6f0c8c4d76424b7bf0d8a31723d48b2f2021c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        classes \u003d []"},{"line_number":43,"context_line":"        module \u003d importutils.import_module(module_name)"},{"line_number":44,"context_line":"        for obj_name in dir(module):"},{"line_number":45,"context_line":"            itm \u003d getattr(module, obj_name)"},{"line_number":46,"context_line":"            if self._is_plugin_class(itm):"},{"line_number":47,"context_line":"                classes.append(itm)"},{"line_number":48,"context_line":"        return classes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F9sg%3D","line":45,"in_reply_to":"AAAALn%2F%2Fu1s%3D","updated":"2012-11-13 23:27:52.000000000","message":"This was just copied from the nova/scheduler/filters/__init__.py code.  I can change it if you really want. :)","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6d895e83b8b3821b1712f3fa1ee3cdad097fb6f6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        classes \u003d []"},{"line_number":43,"context_line":"        module \u003d importutils.import_module(module_name)"},{"line_number":44,"context_line":"        for obj_name in dir(module):"},{"line_number":45,"context_line":"            itm \u003d getattr(module, obj_name)"},{"line_number":46,"context_line":"            if self._is_plugin_class(itm):"},{"line_number":47,"context_line":"                classes.append(itm)"},{"line_number":48,"context_line":"        return classes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fu1s%3D","line":45,"in_reply_to":"AAAALn%2F%2Fu9o%3D","updated":"2012-11-09 16:08:00.000000000","message":"Well, since it\u0027s consistently used within the loop, I don\u0027t see that it really matters…that said, \"item\" would probably be a little clearer.","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"}],"nova/tests/scheduler/test_host_manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6d895e83b8b3821b1712f3fa1ee3cdad097fb6f6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.assertEqual(len(filter_classes), 1)"},{"line_number":62,"context_line":"        self.assertEqual(filter_classes[0].__name__, \u0027ComputeFilterClass2\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#    def test_filter_hosts(self):"},{"line_number":65,"context_line":"#        topic \u003d \u0027fake_topic\u0027"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"#        filters \u003d [\u0027fake-filter1\u0027, \u0027fake-filter2\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fu1g%3D","line":64,"updated":"2012-11-09 16:08:00.000000000","message":"I would rather we remove code than comment it out.  We can always pull it out of the git history if it turns out we need it again.","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6d895e83b8b3821b1712f3fa1ee3cdad097fb6f6","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    # update_from_compute_node() and consume_from_instance() are tested"},{"line_number":166,"context_line":"    # in HostManagerTestCase.test_get_all_host_states()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"#    def test_host_state_passes_filters_passes(self):"},{"line_number":169,"context_line":"#        fake_host \u003d host_manager.HostState(\u0027host1\u0027, \u0027compute\u0027)"},{"line_number":170,"context_line":"#        filter_properties \u003d {}"},{"line_number":171,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Fu1Y%3D","line":168,"updated":"2012-11-09 16:08:00.000000000","message":"Again, remove instead of comment…","commit_id":"32bb290c2865b81e27a50c2b657204a56fd62819"}]}