)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b3a1216576d67fa689ef12b74fbbab4728c5f6c0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        host \u003d hosts.pop(0)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        self._post_select_populate_filter_properties(filter_properties,"},{"line_number":112,"context_line":"                host.obj)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # context is not serializable"},{"line_number":115,"context_line":"        filter_properties.pop(\u0027context\u0027, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F85k%3D","line":112,"updated":"2012-11-14 16:21:25.000000000","message":"This would be a little easier to read if it was \u0027weighed_host\u0027 instead of just \u0027host\u0027.  The \u0027obj\u0027 is the actual host_state right?\n\nCould also use \u0027best_host\u0027 like in _schedule below.","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b3a1216576d67fa689ef12b74fbbab4728c5f6c0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                        payload)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # TODO(NTTdocomo): Combine the next two updates into one"},{"line_number":134,"context_line":"        driver.db_instance_node_set(context,"},{"line_number":135,"context_line":"                instance_uuid, weighted_host.obj.nodename)"},{"line_number":136,"context_line":"        updated_instance \u003d driver.instance_update_db(context,"},{"line_number":137,"context_line":"                instance_uuid)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F85I%3D","line":134,"updated":"2012-11-14 16:21:25.000000000","message":"weighed_host?  (vs weighted)  just looking for consistency, i think it might be different on L273 below.","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b3a1216576d67fa689ef12b74fbbab4728c5f6c0","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        return self.filter_handler.get_filtered_objects(filter_classes,"},{"line_number":324,"context_line":"                hosts, filter_properties)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def get_weighed_hosts(self, hosts, weigh_properties):"},{"line_number":327,"context_line":"        \"\"\"Weigh the hosts\"\"\""},{"line_number":328,"context_line":"        return self.weight_handler.get_weighed_objects(self.weight_classes,"},{"line_number":329,"context_line":"                hosts, weigh_properties)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F84o%3D","line":326,"updated":"2012-11-14 16:21:25.000000000","message":"Annoying nits...:0\n\nweight_properties?","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"}],"nova/scheduler/least_cost.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c8d5f27d8d97f25aaf5356306aeba2a58556dabb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"\"\"Higher weights win, so we should return a lower weight"},{"line_number":47,"context_line":"    when there\u0027s more free ram available."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Note: the weight modify for this function in default configuration"},{"line_number":50,"context_line":"    is -1.0. With a -1.0 this function runs in reverse, so systems"},{"line_number":51,"context_line":"    with the most free memory will be preferred."},{"line_number":52,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2Fu1I%3D","line":49,"updated":"2012-11-09 16:12:54.000000000","message":"\"weight modifier\" maybe?","commit_id":"c31bc5111a181868c088f91bcfb18cc47cc6cf58"}],"nova/scheduler/weights/__init__.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b3a1216576d67fa689ef12b74fbbab4728c5f6c0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class WeightedHost(weights.WeighedObject):"},{"line_number":31,"context_line":"    def to_dict(self):"},{"line_number":32,"context_line":"        x \u003d dict(weight\u003dself.weight)"},{"line_number":33,"context_line":"        x[\u0027host\u0027] \u003d self.obj.host"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F840%3D","line":30,"updated":"2012-11-14 16:21:25.000000000","message":"WeighedHost? (consistency with super class)","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b3a1216576d67fa689ef12b74fbbab4728c5f6c0","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if (CONF.least_cost_functions is not None or"},{"line_number":57,"context_line":"            CONF.compute_fill_first_cost_fn_weight is not None):"},{"line_number":58,"context_line":"        LOG.deprecated(_(\u0027least_cost has been deprecated in favor of \u0027"},{"line_number":59,"context_line":"                \u0027the RAM Weigher.\u0027))"},{"line_number":60,"context_line":"        return least_cost.get_least_cost_weighers()"},{"line_number":61,"context_line":"    return HostWeightHandler().get_all_classes()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F848%3D","line":58,"updated":"2012-11-14 16:21:25.000000000","message":"So what is the actual policy on deprecation?  This gets kept until when?","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d0eeb0d85918eebf5b046ce576b0e92cf9a23019","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if (CONF.least_cost_functions is not None or"},{"line_number":57,"context_line":"            CONF.compute_fill_first_cost_fn_weight is not None):"},{"line_number":58,"context_line":"        LOG.deprecated(_(\u0027least_cost has been deprecated in favor of \u0027"},{"line_number":59,"context_line":"                \u0027the RAM Weigher.\u0027))"},{"line_number":60,"context_line":"        return least_cost.get_least_cost_weighers()"},{"line_number":61,"context_line":"    return HostWeightHandler().get_all_classes()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F8ug%3D","line":58,"in_reply_to":"AAAAMH%2F%2F81Y%3D","updated":"2012-11-14 17:38:45.000000000","message":"Yeah... until H.","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2a315d4542390d9653aed9754b05813ab0045784","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if (CONF.least_cost_functions is not None or"},{"line_number":57,"context_line":"            CONF.compute_fill_first_cost_fn_weight is not None):"},{"line_number":58,"context_line":"        LOG.deprecated(_(\u0027least_cost has been deprecated in favor of \u0027"},{"line_number":59,"context_line":"                \u0027the RAM Weigher.\u0027))"},{"line_number":60,"context_line":"        return least_cost.get_least_cost_weighers()"},{"line_number":61,"context_line":"    return HostWeightHandler().get_all_classes()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAMH%2F%2F81Y%3D","line":58,"in_reply_to":"AAAAMH%2F%2F848%3D","updated":"2012-11-14 16:41:28.000000000","message":"I\u0027d say, until the \u0027H\u0027 release…","commit_id":"debc48a400531385d59ee6dfbbadf5ced54e33c8"}]}