)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3b4a295b73e9a87925c4299a984393d03c0dd622","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tony Breeds \u003ctony@bakeyournoodle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-19 14:03:47 +1100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Chnage utils.vpn_ping() to return a Boolean."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vpn_ping() is used exlusively to tell if a vpn server is actually"},{"line_number":10,"context_line":"listening. The session_id it picks is not sensitive. It is just using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_95086c2e","line":7,"updated":"2015-02-19 03:29:39.000000000","message":"*sigh* Of course I\u0027ll fix \u0027Chnage\u0027 after I\u0027ve collected a few review comments","commit_id":"909949c0d86ddc596db52f05d6e70ec0e04be21a"}],"nova/tests/unit/test_utils.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"522963041866a7187a14d7a36a2389d8580bb416","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        self.assertEqual(False, rc)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":238,"context_line":"    def test_vpn_ping_bad_len(self, mock_socket):"},{"line_number":239,"context_line":"        \"\"\"Test a short/invalid server reply.\"\"\""},{"line_number":240,"context_line":"        socket_obj \u003d mock.MagicMock()"},{"line_number":241,"context_line":"        socket_obj.recv.return_value \u003d \u0027fake_reply\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8a0da240","line":238,"updated":"2015-02-19 06:53:55.000000000","message":"suggestion : You can move the common code to a helper function since all the test functions share some common code.","commit_id":"909949c0d86ddc596db52f05d6e70ec0e04be21a"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e053ebc99093aad288b582f4c405bffc220dea7d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        self.assertEqual(False, rc)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":238,"context_line":"    def test_vpn_ping_bad_len(self, mock_socket):"},{"line_number":239,"context_line":"        \"\"\"Test a short/invalid server reply.\"\"\""},{"line_number":240,"context_line":"        socket_obj \u003d mock.MagicMock()"},{"line_number":241,"context_line":"        socket_obj.recv.return_value \u003d \u0027fake_reply\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_91391edb","line":238,"in_reply_to":"da86d52c_8a0da240","updated":"2015-02-19 23:22:36.000000000","message":"Done","commit_id":"909949c0d86ddc596db52f05d6e70ec0e04be21a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d73d221e2fc6014b7b2007bf3e29e06fc0ea49f","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.setup_socket(mock_socket, None, socket.timeout)"},{"line_number":238,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":239,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":240,"context_line":"        self.assertEqual(False, rc)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":243,"context_line":"    def test_vpn_ping_bad_len(self, mock_socket):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_02a04542","line":240,"updated":"2015-02-22 10:20:31.000000000","message":"please use self.assertFalse","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0316e6c7d55aa8f4f002d9e492387079c45d040a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.setup_socket(mock_socket, None, socket.timeout)"},{"line_number":238,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":239,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":240,"context_line":"        self.assertEqual(False, rc)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":243,"context_line":"    def test_vpn_ping_bad_len(self, mock_socket):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_192197fb","line":240,"in_reply_to":"ba7be1f8_02a04542","updated":"2015-02-22 22:28:54.000000000","message":"Done","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d73d221e2fc6014b7b2007bf3e29e06fc0ea49f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.setup_socket(mock_socket, \u0027fake_reply\u0027)"},{"line_number":246,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":247,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":248,"context_line":"        self.assertEqual(False, rc)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":251,"context_line":"    def test_vpn_ping_bad_id(self, mock_socket):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_22a54953","line":248,"updated":"2015-02-22 10:20:31.000000000","message":"ditto","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0316e6c7d55aa8f4f002d9e492387079c45d040a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.setup_socket(mock_socket, \u0027fake_reply\u0027)"},{"line_number":246,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":247,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":248,"context_line":"        self.assertEqual(False, rc)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":251,"context_line":"    def test_vpn_ping_bad_id(self, mock_socket):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_391c9bc1","line":248,"in_reply_to":"ba7be1f8_22a54953","updated":"2015-02-22 22:28:54.000000000","message":"Done","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d73d221e2fc6014b7b2007bf3e29e06fc0ea49f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self.setup_socket(mock_socket, self.fake_reply_packet(pkt_id\u003d0x41))"},{"line_number":254,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":255,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":256,"context_line":"        self.assertEqual(False, rc)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":259,"context_line":"    def test_vpn_ping_ok(self, mock_socket):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_42895dc9","line":256,"updated":"2015-02-22 10:20:31.000000000","message":"ditto","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0316e6c7d55aa8f4f002d9e492387079c45d040a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self.setup_socket(mock_socket, self.fake_reply_packet(pkt_id\u003d0x41))"},{"line_number":254,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":255,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":256,"context_line":"        self.assertEqual(False, rc)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @mock.patch.object(socket, \u0027socket\u0027)"},{"line_number":259,"context_line":"    def test_vpn_ping_ok(self, mock_socket):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_597a2ff2","line":256,"in_reply_to":"ba7be1f8_42895dc9","updated":"2015-02-22 22:28:54.000000000","message":"Done","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d73d221e2fc6014b7b2007bf3e29e06fc0ea49f","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        self.setup_socket(mock_socket, self.fake_reply_packet())"},{"line_number":261,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":262,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":263,"context_line":"        self.assertEqual(True, rc)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"class MonkeyPatchTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_628661bb","line":263,"updated":"2015-02-22 10:20:31.000000000","message":"please use self.assertTrue","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0316e6c7d55aa8f4f002d9e492387079c45d040a","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        self.setup_socket(mock_socket, self.fake_reply_packet())"},{"line_number":261,"context_line":"        rc \u003d utils.vpn_ping(self.address, self.port,"},{"line_number":262,"context_line":"                            session_id\u003dself.session_id)"},{"line_number":263,"context_line":"        self.assertEqual(True, rc)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"class MonkeyPatchTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_797d33e7","line":263,"in_reply_to":"ba7be1f8_628661bb","updated":"2015-02-22 22:28:54.000000000","message":"Done","commit_id":"15e010d2ec3c93c6ce931445173542745e9e1245"}],"nova/utils.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"522963041866a7187a14d7a36a2389d8580bb416","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                    dict(exp\u003dstruct.calcsize(fmt), act\u003dlen(received)))"},{"line_number":182,"context_line":"        return False"},{"line_number":183,"context_line":"    (identifier, server_sess, client_sess) \u003d struct.unpack(fmt, received)"},{"line_number":184,"context_line":"    if identifier \u003d\u003d 0x40 and client_sess \u003d\u003d session_id:"},{"line_number":185,"context_line":"        return True"},{"line_number":186,"context_line":"    return False"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8a5f6240","line":184,"updated":"2015-02-19 06:53:55.000000000","message":"I think you can just have one statement :\nreturn (identifier \u003d\u003d 0x40 and client_sess \u003d\u003d session_id)","commit_id":"909949c0d86ddc596db52f05d6e70ec0e04be21a"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e053ebc99093aad288b582f4c405bffc220dea7d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                    dict(exp\u003dstruct.calcsize(fmt), act\u003dlen(received)))"},{"line_number":182,"context_line":"        return False"},{"line_number":183,"context_line":"    (identifier, server_sess, client_sess) \u003d struct.unpack(fmt, received)"},{"line_number":184,"context_line":"    if identifier \u003d\u003d 0x40 and client_sess \u003d\u003d session_id:"},{"line_number":185,"context_line":"        return True"},{"line_number":186,"context_line":"    return False"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d13396f4","line":184,"in_reply_to":"da86d52c_8a5f6240","updated":"2015-02-19 23:22:36.000000000","message":"Done","commit_id":"909949c0d86ddc596db52f05d6e70ec0e04be21a"}]}