)]}'
{"nova/scheduler/attestation/client.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class BaseClient(object):"},{"line_number":68,"context_line":"    \"\"\"A base client class\"\"\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def __init__(self, host, port, use_ssl, auth_user, auth_passwd,"},{"line_number":71,"context_line":"                 key_file\u003dNone, cert_file\u003dNone, ca_file\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BnU%3D","line":68,"updated":"2011-11-14 17:57:09.000000000","message":"Need better description here.","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def __init__(self, host, port, use_ssl, auth_user, auth_passwd,"},{"line_number":71,"context_line":"                 key_file\u003dNone, cert_file\u003dNone, ca_file\u003dNone):"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        Creates a new client to some service."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        :param host: The host where service resides"},{"line_number":76,"context_line":"        :param port: The port where service resides"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BnM%3D","line":73,"updated":"2011-11-14 17:57:09.000000000","message":"\"some\" service?","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                             key_file\u003dself.key_file,"},{"line_number":103,"context_line":"                                             cert_file\u003dself.cert_file,"},{"line_number":104,"context_line":"                                             ca_file\u003dself.ca_file)"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            return httplib.HTTPConnection(self.host, self.port)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def do_request(self, method, action, body\u003dNone, headers\u003dNone, params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BnQ%3D","line":105,"updated":"2011-11-14 17:57:09.000000000","message":"no else required since alternative returns","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        if type(params) is dict:"},{"line_number":113,"context_line":"            # remove any params that are None"},{"line_number":114,"context_line":"            for (key, value) in params.items():"},{"line_number":115,"context_line":"                if value is None:"},{"line_number":116,"context_line":"                    del params[key]"},{"line_number":117,"context_line":"            action +\u003d \u0027?\u0027 + urllib.urlencode(params)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bnc%3D","line":115,"updated":"2011-11-14 17:57:09.000000000","message":"if not value:","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"}],"nova/scheduler/attestation/service_client.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    \u0027attestation access user - must change\u0027)"},{"line_number":45,"context_line":"flags.DEFINE_string(\u0027attestation_auth_passwd\u0027, \u0027MustChangeThisPasswd\u0027,"},{"line_number":46,"context_line":"                    \u0027attestation access passwd - must change\u0027)"},{"line_number":47,"context_line":"TrustDict \u003d {\u0027trusted\u0027: \u0027LVL10\u0027,"},{"line_number":48,"context_line":"             \u0027untrusted\u0027: \u0027LVL01\u0027,"},{"line_number":49,"context_line":"             \u0027unknown\u0027: \u0027LVL01\u0027}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bno%3D","line":47,"updated":"2011-11-14 17:57:09.000000000","message":"TRUST_DICT","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                index \u003d FLAGS.attestation_index_register"},{"line_number":193,"context_line":"                entry[\u0027geo_tag\u0027] \u003d state.get(index, None)"},{"line_number":194,"context_line":"            report[host] \u003d entry"},{"line_number":195,"context_line":"            count \u003d count - 1"},{"line_number":196,"context_line":"        if count:"},{"line_number":197,"context_line":"            LOG.warning(_(\"Get hosts missed count %(count)s\" % locals()))"},{"line_number":198,"context_line":"    return report"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bng%3D","line":195,"updated":"2011-11-14 17:57:09.000000000","message":"count -\u003d 1","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"}],"nova/scheduler/filters/json_filter_integrity.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import nova.scheduler"},{"line_number":23,"context_line":"from nova.scheduler.filters import abstract_filter"},{"line_number":24,"context_line":"from nova.scheduler.filters import json_filter"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":27,"context_line":"flags.DEFINE_string(\u0027default_post_filter_driver\u0027, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bnw%3D","line":24,"updated":"2011-11-14 17:57:09.000000000","message":"Check with HACKING guide for import ordering and spacing rules.","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"}],"nova/scheduler/manager_integrity.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def cache_states_update(self, integrity_report):"},{"line_number":71,"context_line":"        for host, state in integrity_report.iteritems():"},{"line_number":72,"context_line":"            self.trust_cache[host] \u003d state"},{"line_number":73,"context_line":"            if self.inflight_hosts.get(host, None) is not None:"},{"line_number":74,"context_line":"                del self.inflight_hosts[host]"},{"line_number":75,"context_line":"            self.zone_manager.update_service_capabilities(\u0027trust_state\u0027,"},{"line_number":76,"context_line":"                                                          host, state)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BoI%3D","line":73,"updated":"2011-11-14 17:57:09.000000000","message":"if self.inflight_hosts.get(host, None):\n   ...","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                          host, state)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def post_hosts(self, hosts):"},{"line_number":79,"context_line":"        \"\"\"POST list list of hosts to attestation server\"\"\""},{"line_number":80,"context_line":"        lists \u003d []"},{"line_number":81,"context_line":"        now \u003d utils.utcnow()"},{"line_number":82,"context_line":"        for host in hosts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BoE%3D","line":79,"updated":"2011-11-14 17:57:09.000000000","message":"list list?","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        now \u003d utils.utcnow()"},{"line_number":82,"context_line":"        for host in hosts:"},{"line_number":83,"context_line":"            self.inflight_hosts[host] \u003d now"},{"line_number":84,"context_line":"            lists.append(host)"},{"line_number":85,"context_line":"        if lists:"},{"line_number":86,"context_line":"            self._do_attestation(\u0027POST_HOSTS\u0027, lists)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BoA%3D","line":84,"updated":"2011-11-14 17:57:09.000000000","message":"lists \u003d hosts[:]\nfor host in hosts:\n     self.inflight_hosts[hosts] \u003d now","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def get_hosts(self):"},{"line_number":89,"context_line":"        \"\"\"GET previously posted attestation results \"\"\""},{"line_number":90,"context_line":"        integrity_report \u003d self._do_attestation(\u0027GET_HOSTS\u0027, hosts\u003dNone)"},{"line_number":91,"context_line":"        if len(integrity_report):"},{"line_number":92,"context_line":"            self.cache_states_update(integrity_report)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def post_get_host(self, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bn8%3D","line":91,"updated":"2011-11-14 17:57:09.000000000","message":"if integrity_report:","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"}],"nova/tests/scheduler/test_json_integrity.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(\u0027nova.tests.scheduler.test_json_integrity\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class HostFilterTestCase(test.TestCase):"},{"line_number":35,"context_line":"    \"\"\"Test case for host filters.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _host_caps(self, multiplier):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BoU%3D","line":34,"updated":"2011-11-14 17:57:09.000000000","message":"Is this a HostFilterTestCase?\n\nThis looks largely like a copy-paste of test_host_filters ... why not just modify the existing test?","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"}],"nova/tests/scheduler/test_manager_integrity.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Tests For Scheduler"},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":"import datetime"},{"line_number":24,"context_line":"import mox"},{"line_number":25,"context_line":"import novaclient.exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bqc%3D","line":22,"updated":"2011-11-14 17:57:09.000000000","message":"Refer to HACKING guide on ordering of imports and spacing rules.","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import stubout"},{"line_number":27,"context_line":"import webob"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from mox import IgnoreArg"},{"line_number":30,"context_line":"from nova import context"},{"line_number":31,"context_line":"from nova import db"},{"line_number":32,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BqY%3D","line":29,"updated":"2011-11-14 17:57:09.000000000","message":"Import modules, not classes (as per HACKING)","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova.db.sqlalchemy import models"},{"line_number":45,"context_line":"from nova import log as logging"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"LOG \u003d logging.getLogger(\u0027nova.scheduler.manager_integrity\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BqU%3D","line":47,"updated":"2011-11-14 17:57:09.000000000","message":"Incorrect logging name (this is the test).","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        return \u0027named_host\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class SchedulerTestCase(test.TestCase):"},{"line_number":62,"context_line":"    \"\"\"Test case for scheduler\"\"\""},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(SchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Boo%3D","line":61,"updated":"2011-11-14 17:57:09.000000000","message":"Is it really a SchedulerTestCase or an IntegrityManager test case?","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class SchedulerTestCase(test.TestCase):"},{"line_number":62,"context_line":"    \"\"\"Test case for scheduler\"\"\""},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(SchedulerTestCase, self).setUp()"},{"line_number":65,"context_line":"        driver \u003d \u0027nova.tests.scheduler.test_scheduler.TestDriver\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bog%3D","line":62,"updated":"2011-11-14 17:57:09.000000000","message":"looks like copy-paste","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.old_down_flag \u003d FLAGS.service_down_time"},{"line_number":71,"context_line":"        FLAGS.service_down_time \u003d 4"},{"line_number":72,"context_line":"        self.rid \u003d []"},{"line_number":73,"context_line":"        self.count \u003d 0"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def tearDown(self):"},{"line_number":76,"context_line":"        self.stubs.UnsetAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BoY%3D","line":73,"updated":"2011-11-14 17:57:09.000000000","message":"What is this \"count\" that we\u0027re checking in the test?","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Create compute-manager(ComputeNode and Service record).\"\"\""},{"line_number":83,"context_line":"        self.hosts \u003d n"},{"line_number":84,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":85,"context_line":"        now \u003d utils.utcnow() - datetime.timedelta(0)"},{"line_number":86,"context_line":"        dic1 \u003d {\u0027host\u0027: \u0027dummy\u0027, \u0027binary\u0027: \u0027nova-compute\u0027, \u0027topic\u0027: \u0027compute\u0027,"},{"line_number":87,"context_line":"               \u0027report_count\u0027: 0, \u0027updated_at\u0027: 0, \u0027created_at\u0027: 0,"},{"line_number":88,"context_line":"               \u0027availability_zone\u0027: \u0027dummyzone\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BqQ%3D","line":85,"updated":"2011-11-14 17:57:09.000000000","message":"why subtract 0?","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"2395c0ddce62da5ad3af59b6329f24de59014689","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        scheduler.periodic_tasks(ctx)"},{"line_number":186,"context_line":"        self.assertEqual(10, self.count)"},{"line_number":187,"context_line":"        time.sleep(FLAGS.report_interval * 2)"},{"line_number":188,"context_line":"        self._update_ticks(ctx, 1, 2, 0)"},{"line_number":189,"context_line":"        scheduler.periodic_tasks(ctx)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2Bos%3D","line":187,"updated":"2011-11-14 17:57:09.000000000","message":"Tests shouldn\u0027t be dependent on sleep()\n\nInstead, put a stub function in the code for the elapsed time check and override it in the test. That way, you can remove all the tick code and just the right thing as fast as possible.","commit_id":"2cc5637fc97596935235ee8a76290d848d2385af"}]}