)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"72085522f7d28c9303203c9dfad3343617b6d7d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Link to devstack guide for appropriate serial_console instructions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"devstack now has an n-sproxy service that can be enabled as you\u0027d expect.  For"},{"line_number":10,"context_line":"those that want to test the serial console support link to the devstack"},{"line_number":11,"context_line":"configuration guide."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I401d94b2413c62bfae9b90d2214d77bd4cfc15d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_5a54da20","line":10,"updated":"2015-02-23 07:04:06.000000000","message":"The statement seems incomplete","commit_id":"f37851ef1a92aa9964507cc9871ba32e5981e6bd"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0bf84b8b7dd2a2bbb9d34ebc491d05c42d5ef2e9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Link to devstack guide for appropriate serial_console instructions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"devstack now has an n-sproxy service that can be enabled as you\u0027d expect.  For"},{"line_number":10,"context_line":"those that want to test the serial console support link to the devstack"},{"line_number":11,"context_line":"configuration guide."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I401d94b2413c62bfae9b90d2214d77bd4cfc15d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_6d13aab8","line":10,"in_reply_to":"ba7be1f8_5a54da20","updated":"2015-02-23 07:44:42.000000000","message":"Sorry that statement makes sense to me,  Perhaps if you drafted a version that makes more sense to you I\u0027d understand the deficiency.","commit_id":"f37851ef1a92aa9964507cc9871ba32e5981e6bd"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"8d7e967172b3397d8178adc33acca7d842b24902","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Link to devstack guide for appropriate serial_console instructions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"devstack now has an n-sproxy service that can be enabled as you\u0027d expect.  For"},{"line_number":10,"context_line":"those that want to test the serial console support link to the devstack"},{"line_number":11,"context_line":"configuration guide."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I401d94b2413c62bfae9b90d2214d77bd4cfc15d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_41ba2d24","line":10,"in_reply_to":"ba7be1f8_6d13aab8","updated":"2015-02-23 10:22:55.000000000","message":"It is a just a suggestion, may be a simple statement like \n \"This patch adds link to the serial console support in devstack configuration guide  which can now be enabled in devstack.\" \nor just \n\"Adds link to the serial console support in devstack configuration guide which can now be enabled in devstack.\"","commit_id":"f37851ef1a92aa9964507cc9871ba32e5981e6bd"}],"doc/source/devref/testing/serial-console.rst":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5ecb5729b829d1c466550310c521717f7be72273","unresolved":false,"context_lines":[{"line_number":8,"context_line":"This page describes how to test it from a devstack environement."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"---------------------------------"},{"line_number":11,"context_line":"Setting up a devstack environemnt"},{"line_number":12,"context_line":"---------------------------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstck with serial console support enabled"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba7be1f8_5a189384","line":11,"updated":"2015-02-20 09:24:48.000000000","message":"typo: environemnt -\u003e environment (not your typo but maybe you could change that too)","commit_id":"75efd04467d91a7f8c7d9240e510a06a1316c942"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ad4bb2fb1e7751d5899332163ba534aec7790a5b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"This page describes how to test it from a devstack environement."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"---------------------------------"},{"line_number":11,"context_line":"Setting up a devstack environemnt"},{"line_number":12,"context_line":"---------------------------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstck with serial console support enabled"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba7be1f8_9a63ce19","line":11,"in_reply_to":"ba7be1f8_5a189384","updated":"2015-02-20 21:36:10.000000000","message":"Done","commit_id":"75efd04467d91a7f8c7d9240e510a06a1316c942"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5ecb5729b829d1c466550310c521717f7be72273","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Setting up a devstack environemnt"},{"line_number":12,"context_line":"---------------------------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstck with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba7be1f8_3a7e7faf","line":14,"updated":"2015-02-20 09:24:48.000000000","message":"typo: devstck -\u003e devstack","commit_id":"75efd04467d91a7f8c7d9240e510a06a1316c942"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ad4bb2fb1e7751d5899332163ba534aec7790a5b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Setting up a devstack environemnt"},{"line_number":12,"context_line":"---------------------------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstck with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba7be1f8_ba6892f6","line":14,"in_reply_to":"ba7be1f8_3a7e7faf","updated":"2015-02-20 21:36:10.000000000","message":"Done","commit_id":"75efd04467d91a7f8c7d9240e510a06a1316c942"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"72085522f7d28c9303203c9dfad3343617b6d7d6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstack with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---------------"},{"line_number":19,"context_line":"Testing the API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_5a7dbab0","line":16,"updated":"2015-02-23 07:04:06.000000000","message":"The link does not work","commit_id":"f37851ef1a92aa9964507cc9871ba32e5981e6bd"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0bf84b8b7dd2a2bbb9d34ebc491d05c42d5ef2e9","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstack with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---------------"},{"line_number":19,"context_line":"Testing the API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_cd1016ab","line":16,"in_reply_to":"ba7be1f8_5a7dbab0","updated":"2015-02-23 07:44:42.000000000","message":"Correct.  As stated previously This review depends on a companion change landing in devstack.  Once that lands the linke above *should* work.","commit_id":"f37851ef1a92aa9964507cc9871ba32e5981e6bd"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"8d7e967172b3397d8178adc33acca7d842b24902","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstack with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---------------"},{"line_number":19,"context_line":"Testing the API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_66ed87ef","line":16,"in_reply_to":"ba7be1f8_cd1016ab","updated":"2015-02-23 10:22:55.000000000","message":"Oops sorry, i lost track of that.","commit_id":"f37851ef1a92aa9964507cc9871ba32e5981e6bd"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ff8de76620803c216c67be93587af3174eeb6e95","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstack with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---------------"},{"line_number":19,"context_line":"Testing the API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baa041b7_e804357f","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":79},"updated":"2015-04-02 16:48:09.000000000","message":"It seems really odd to have nova devref docs point to devstack for how to configure nova.","commit_id":"f1539152cfc96bbddad70ff0fb26fc997f6a0275"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b6b887dd90f82ee621212188a5ddd7c25171b4b6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstack with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---------------"},{"line_number":19,"context_line":"Testing the API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa53dc9_17f31f75","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":79},"in_reply_to":"baa041b7_c6e36832","updated":"2015-04-06 17:22:34.000000000","message":"I agree 3 is the best option. But I think the linking should be the other way around.","commit_id":"f1539152cfc96bbddad70ff0fb26fc997f6a0275"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3fb89c970106389593e0dcf1d738f626f88c54aa","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For instructions on how to setup devstack with serial console support enabled"},{"line_number":15,"context_line":"see `this guide"},{"line_number":16,"context_line":"\u003chttp://docs.openstack.org/developer/devstack/guides/nova.html#nova-serialproxy\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"---------------"},{"line_number":19,"context_line":"Testing the API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baa041b7_c6e36832","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":79},"in_reply_to":"baa041b7_e804357f","updated":"2015-04-05 06:12:27.000000000","message":"I understand your POV and it is a little strange but the text I\u0027m removing is talking about how to configure *devstack* not Nova.  I admit that the line is blury but that\u0027s how I see it. The text that is being removed is more complex than just \u0027enable_service n-spoxy\u0027.  Given that there is a documented way to do this in devstack we\u0027re faced with 3 options:\n1) Have different guides in nova and devstack [current situation]\n2) Duplicate the text of the 2 guides and keep them in sync/ customised [ probably not a huge amount of work but a pain none the less]\n3) Link to one from t\u0027other.\n\nIn my view option 3 is the best and hence this review.","commit_id":"f1539152cfc96bbddad70ff0fb26fc997f6a0275"}]}