)]}'
{"nova/service.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e8b61a07f1e9e2f25783251777d0ed8fe4bd69ad","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027report_count\u0027: 0,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        if not CONF.enable_new_services:"},{"line_number":230,"context_line":"            svc_values[\u0027disabled\u0027] \u003d True"},{"line_number":231,"context_line":"        service \u003d self.conductor_api.service_create(context, svc_values)"},{"line_number":232,"context_line":"        self.service_id \u003d service[\u0027id\u0027]"},{"line_number":233,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f2dbb84c","line":230,"updated":"2015-02-24 14:31:57.000000000","message":"sounds like it\u0027s not covered by tests or it would fail. Could you please add the missing test for the Service object ?","commit_id":"09ec805d4eeb63ce9ab75e138e8352e12613fc62"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0bf66de98fd9a59a7f150aae19be91720e1b7bf4","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027report_count\u0027: 0,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        if not CONF.enable_new_services:"},{"line_number":230,"context_line":"            svc_values[\u0027disabled\u0027] \u003d True"},{"line_number":231,"context_line":"        service \u003d self.conductor_api.service_create(context, svc_values)"},{"line_number":232,"context_line":"        self.service_id \u003d service[\u0027id\u0027]"},{"line_number":233,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_65f2b39b","line":230,"in_reply_to":"ba7be1f8_3d868366","updated":"2015-03-02 17:09:18.000000000","message":"Well, I understand that the high-level test covers this, but I think it\u0027s very risky to leave this test and assess it will be there forever. In general, unittests are colocated to where the conditional logic is, so I would even be in favor of moving the high-level test down to the object Service testcase so that it would be at the same level.","commit_id":"09ec805d4eeb63ce9ab75e138e8352e12613fc62"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"33b0ce85ff02ebb60b1413d786184f1902b81536","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027report_count\u0027: 0,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        if not CONF.enable_new_services:"},{"line_number":230,"context_line":"            svc_values[\u0027disabled\u0027] \u003d True"},{"line_number":231,"context_line":"        service \u003d self.conductor_api.service_create(context, svc_values)"},{"line_number":232,"context_line":"        self.service_id \u003d service[\u0027id\u0027]"},{"line_number":233,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_fc3ecab6","line":230,"in_reply_to":"ba7be1f8_d232345e","updated":"2015-02-26 11:48:04.000000000","message":"@Sylvain: The test you found covers this exact case explicitly, so I don\u0027t think we need another one.\n\n@Alex: Not sure about that... :)","commit_id":"09ec805d4eeb63ce9ab75e138e8352e12613fc62"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"220f69b637f647c6f68564221070a64d19b435c3","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027report_count\u0027: 0,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        if not CONF.enable_new_services:"},{"line_number":230,"context_line":"            svc_values[\u0027disabled\u0027] \u003d True"},{"line_number":231,"context_line":"        service \u003d self.conductor_api.service_create(context, svc_values)"},{"line_number":232,"context_line":"        self.service_id \u003d service[\u0027id\u0027]"},{"line_number":233,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3d868366","line":230,"in_reply_to":"ba7be1f8_f281f8c3","updated":"2015-02-26 22:08:25.000000000","message":"@Sylvain if I understood correctly you are suggesting to have another \"test_create\" with the flags in objects.test_service.\n\nIn my opinion since the change is at service.py level and not in the object seems more natural to keep the existing tests. I\u0027m not sure about the value in another test at object level.","commit_id":"09ec805d4eeb63ce9ab75e138e8352e12613fc62"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"feef0752dc95afa97c79a39c5d95862e4a33a7c1","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027report_count\u0027: 0,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        if not CONF.enable_new_services:"},{"line_number":230,"context_line":"            svc_values[\u0027disabled\u0027] \u003d True"},{"line_number":231,"context_line":"        service \u003d self.conductor_api.service_create(context, svc_values)"},{"line_number":232,"context_line":"        self.service_id \u003d service[\u0027id\u0027]"},{"line_number":233,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f281f8c3","line":230,"in_reply_to":"ba7be1f8_f2dbb84c","updated":"2015-02-24 14:35:57.000000000","message":"my bad, it\u0027s covered by an higher testcase https://github.com/openstack/nova/blob/master/nova/tests/unit/test_service.py#L97-L118\n\nThat said, I would prefer that we keep the high-level stuff but also that we would cover this conditional by adding the tests to nova.tests.unit.objects.test_service","commit_id":"09ec805d4eeb63ce9ab75e138e8352e12613fc62"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8dbfa2c255ba0fd728c40764e0b30cc212f16143","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027report_count\u0027: 0,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        if not CONF.enable_new_services:"},{"line_number":230,"context_line":"            svc_values[\u0027disabled\u0027] \u003d True"},{"line_number":231,"context_line":"        service \u003d self.conductor_api.service_create(context, svc_values)"},{"line_number":232,"context_line":"        self.service_id \u003d service[\u0027id\u0027]"},{"line_number":233,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d232345e","line":230,"in_reply_to":"ba7be1f8_f2dbb84c","updated":"2015-02-24 14:40:19.000000000","message":"nit,  we can just write like \"svc_values[\u0027disabled\u0027] \u003d CONF.enable_new_services\"","commit_id":"09ec805d4eeb63ce9ab75e138e8352e12613fc62"}]}