)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"bbfef693e3e996a7431e269f911e828a6a85e793","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"                host\u003dmigration_ref[\u0027dest_compute\u0027], reservations\u003dreservations)"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        self.db.migration_update(elevated, migration_ref[\u0027id\u0027],"},{"line_number":1571,"context_line":"                                 {\u0027status\u0027: \u0027reverting\u0027})"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    @wrap_check_policy"},{"line_number":1574,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F8so%3D","line":1571,"updated":"2012-11-14 17:58:22.000000000","message":"is there a race here?  what if \u0027revert_resize\u0027 finish extremely quickly!  Should this DB update go before the rpc cast?","commit_id":"f6e925d83f5246a500e84987409f944478db26fc"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"70839144febea52cc55710d81dd6057264064b53","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"                host\u003dmigration_ref[\u0027dest_compute\u0027], reservations\u003dreservations)"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        self.db.migration_update(elevated, migration_ref[\u0027id\u0027],"},{"line_number":1571,"context_line":"                                 {\u0027status\u0027: \u0027reverting\u0027})"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    @wrap_check_policy"},{"line_number":1574,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F8ow%3D","line":1571,"in_reply_to":"AAAAMH%2F%2F8so%3D","updated":"2012-11-14 18:28:19.000000000","message":"Yep, good point.  It\u0027s a remote possibility...","commit_id":"f6e925d83f5246a500e84987409f944478db26fc"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"bbfef693e3e996a7431e269f911e828a6a85e793","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"                reservations\u003dreservations)"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        self.db.migration_update(elevated, migration_ref[\u0027id\u0027],"},{"line_number":1596,"context_line":"                {\u0027status\u0027: \u0027confirming\u0027})"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    @staticmethod"},{"line_number":1599,"context_line":"    def _resize_quota_delta(context, new_instance_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F8sk%3D","line":1596,"updated":"2012-11-14 17:58:22.000000000","message":"Ditto","commit_id":"f6e925d83f5246a500e84987409f944478db26fc"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"70839144febea52cc55710d81dd6057264064b53","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"                reservations\u003dreservations)"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        self.db.migration_update(elevated, migration_ref[\u0027id\u0027],"},{"line_number":1596,"context_line":"                {\u0027status\u0027: \u0027confirming\u0027})"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    @staticmethod"},{"line_number":1599,"context_line":"    def _resize_quota_delta(context, new_instance_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F8os%3D","line":1596,"in_reply_to":"AAAAMH%2F%2F8sk%3D","updated":"2012-11-14 18:28:19.000000000","message":"Done","commit_id":"f6e925d83f5246a500e84987409f944478db26fc"}],"nova/compute/claims.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"878912fcf09b644c926ea477e45794e6798db994","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class NopClaim(object):"},{"line_number":30,"context_line":"    \"\"\"For use with compute drivers that do not support resource tracking\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, migration\u003dNone):"},{"line_number":33,"context_line":"        self.migration \u003d migration"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F6xA%3D","line":32,"updated":"2012-11-15 20:52:45.000000000","message":"I may have missed something but I didn\u0027t see where this was used.","commit_id":"5bc0ff6354a399f712c777fa43153f05a50a1ce3"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"171f3febaa27291df6194b514ebac90f9b55c3cc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class NopClaim(object):"},{"line_number":30,"context_line":"    \"\"\"For use with compute drivers that do not support resource tracking\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, migration\u003dNone):"},{"line_number":33,"context_line":"        self.migration \u003d migration"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5bs%3D","line":32,"in_reply_to":"AAAAMH%2F%2F5hI%3D","updated":"2012-11-16 16:35:17.000000000","message":"yeah, seems a little wonky to define self.migration without any rationale as to where/how/why it\u0027s used. So, I assume something is accessing foo.migration directly ... wouldn\u0027t a @property like disk_gb/memory_gb, etc be preferred (or a comment at the least)?","commit_id":"5bc0ff6354a399f712c777fa43153f05a50a1ce3"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"6c83692d7a67104d7225c3481381634353c037ed","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class NopClaim(object):"},{"line_number":30,"context_line":"    \"\"\"For use with compute drivers that do not support resource tracking\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, migration\u003dNone):"},{"line_number":33,"context_line":"        self.migration \u003d migration"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5hI%3D","line":32,"in_reply_to":"AAAAMH%2F%2F6xA%3D","updated":"2012-11-16 15:55:43.000000000","message":"It gets used in resource tracker resize_claim() when the virt driver doesn\u0027t support the get_available_resource method.  In that case resource tracker is just disabled and these no-op claims are returned.","commit_id":"5bc0ff6354a399f712c777fa43153f05a50a1ce3"}]}