)]}'
{"nova/virt/libvirt/volume.py":[{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"1a03691da21b65621fee88ef1ab5c88d4fb58b63","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":39,"context_line":"        \"\"\"Connect the volume. Returns xml for libvirt.\"\"\""},{"line_number":40,"context_line":"        hyperv \u003d self.connection.get_hypervisor_type().lower()"},{"line_number":41,"context_line":"        if hyperv \u003d\u003d \"xen\":"},{"line_number":42,"context_line":"            driver \u003d \"phy\""},{"line_number":43,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BlY%3D","line":40,"updated":"2011-11-14 18:19:38.000000000","message":"I would name \u0027hyperv\u0027 something different, since hyperv is an actual hypervisor that we support.","commit_id":"531110d3caeeec141c9d1f29335c3896e8b9abce"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"8bfc1f43d663801bbeb546fc707364d5817615ef","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if hypervisor_type \u003d\u003d \"xen\":"},{"line_number":42,"context_line":"            driver \u003d \"phy\""},{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            driver \u003d \"qemu\""},{"line_number":45,"context_line":"        device_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":46,"context_line":"        xml \u003d \"\"\"\u003cdisk type\u003d\u0027block\u0027\u003e"},{"line_number":47,"context_line":"                     \u003cdriver name\u003d\u0027%s\u0027 type\u003d\u0027raw\u0027/\u003e"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F%2BKQ%3D","line":44,"updated":"2011-11-15 22:33:33.000000000","message":"Since this logic is repeated in an inherited class, perhaps we could create a method in LibvirtVolumeDriver which abstracts this a bit:\n\ndef _pick_volume_driver(self):\n    hypervisor_type \u003d self.connection.get_hypervisor_type().lower()\n    return \"phy\" if hypervisor_type \u003d\u003d \"xen\" else \"qemu\"","commit_id":"2e76f437d2662a93d10955450354cffe65d9a3a4"}]}