)]}'
{"nova/scheduler/utils.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"98a2f8e2f11edb5e7f5a8db7f05890577fc2fa65","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        # NOTE(ndipanov): We always have the flavor in system-metadata because"},{"line_number":95,"context_line":"        # build_request_spec uses instance_obj.compat_instance to make sure"},{"line_number":96,"context_line":"        # of that."},{"line_number":97,"context_line":"        self.instance_flavor \u003d flavors.extract_flavor(self.instance_properties)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __getattr__(self, name):"},{"line_number":100,"context_line":"        \"\"\"Allow for dot-style access to the request_spec dictionary\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_2d4e5997","line":97,"updated":"2015-03-10 14:56:19.000000000","message":"I see, at this step self.instance_properties will be retrieve from __getattr__.","commit_id":"16449523312f73176b973d47b484511a8c1ea517"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"98a2f8e2f11edb5e7f5a8db7f05890577fc2fa65","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # of that."},{"line_number":97,"context_line":"        self.instance_flavor \u003d flavors.extract_flavor(self.instance_properties)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __getattr__(self, name):"},{"line_number":100,"context_line":"        \"\"\"Allow for dot-style access to the request_spec dictionary\"\"\""},{"line_number":101,"context_line":"        if name in self._request_spec:"},{"line_number":102,"context_line":"            return self._request_spec[name]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_f08b3666","line":99,"updated":"2015-03-10 14:56:19.000000000","message":"I would say we probably want to reduce the scope of this. There is only 4 attributes why not to define them in the constructor to do not make confusion with declared attributes?","commit_id":"16449523312f73176b973d47b484511a8c1ea517"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8aa2638353b240903416561326c05d5fdbf06528","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self._request_spec \u003d request_spec"},{"line_number":90,"context_line":"        flavor \u003d request_spec.get(\u0027instance_type\u0027)"},{"line_number":91,"context_line":"        if flavor:"},{"line_number":92,"context_line":"            flavor \u003d objects.Flavor(**flavor)"},{"line_number":93,"context_line":"        self.flavor \u003d flavor"},{"line_number":94,"context_line":"        # NOTE(ndipanov): We always have the flavor in system-metadata because"},{"line_number":95,"context_line":"        # build_request_spec uses instance_obj.compat_instance to make sure"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_067183e0","line":92,"updated":"2015-05-01 11:11:15.000000000","message":"should this not be a flavor object?\nI suggest checking that it is an object and if not to convert it","commit_id":"8152544cb43546cc20a5e88adfe3a3180cd6b890"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8aa2638353b240903416561326c05d5fdbf06528","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        # NOTE(ndipanov): We always have the flavor in system-metadata because"},{"line_number":95,"context_line":"        # build_request_spec uses instance_obj.compat_instance to make sure"},{"line_number":96,"context_line":"        # of that."},{"line_number":97,"context_line":"        self.instance_flavor \u003d flavors.extract_flavor(self.instance_properties)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __getattr__(self, name):"},{"line_number":100,"context_line":"        \"\"\"Allow for dot-style access to the request_spec dictionary\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_e678c7c6","line":97,"updated":"2015-05-01 11:11:15.000000000","message":"in line 91 we check that flavors is not None. If this is None then this will result in an exception","commit_id":"8152544cb43546cc20a5e88adfe3a3180cd6b890"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8aa2638353b240903416561326c05d5fdbf06528","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \"\"\"Allow for dot-style access to the request_spec dictionary\"\"\""},{"line_number":101,"context_line":"        if name in self._request_spec:"},{"line_number":102,"context_line":"            return self._request_spec[name]"},{"line_number":103,"context_line":"        raise AttributeError(\"\u0027%(obj)s\u0027 object has no attribute \u0027%(name)s\u0027\" %"},{"line_number":104,"context_line":"                             {\u0027obj\u0027: self, \u0027name\u0027: name})"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def new_flavor_requested(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_26b59fed","line":103,"updated":"2015-05-01 11:11:15.000000000","message":"missing translation","commit_id":"8152544cb43546cc20a5e88adfe3a3180cd6b890"}]}