)]}'
{"doc/api_samples/os-agents/agent-post-req.xml":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"62390ce5ed7651b71ba8c52b08e2c5b8a1fbb037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cagent\u003e"},{"line_number":3,"context_line":"\u003chypervisor\u003ehypervisor\u003c/hypervisor\u003e"},{"line_number":4,"context_line":"\u003cos\u003eos\u003c/os\u003e"},{"line_number":5,"context_line":"\u003carchitecture\u003ex86\u003c/architecture\u003e"},{"line_number":6,"context_line":"\u003cversion\u003e8.0\u003c/version\u003e"}],"source_content_type":"application/xml","patch_set":13,"id":"AAAAMX%2F%2F91c%3D","line":3,"updated":"2012-12-04 16:45:01.000000000","message":"nit: Indent the inner elements by 2 spaces for visual nesting…","commit_id":"dbf700c390d60465be5f3a7621a41c914c20aca8"}],"doc/api_samples/os-agents/agent-update-put-req.xml":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"62390ce5ed7651b71ba8c52b08e2c5b8a1fbb037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cpara\u003e"},{"line_number":3,"context_line":"\u003cversion\u003e7.0\u003c/version\u003e"},{"line_number":4,"context_line":"\u003curl\u003exxx://xxxx/xxx/xxx\u003c/url\u003e"},{"line_number":5,"context_line":"\u003cmd5hash\u003eadd6bb58e139be103324d04d82d8f545\u003c/md5hash\u003e"},{"line_number":6,"context_line":"\u003c/para\u003e"}],"source_content_type":"application/xml","patch_set":13,"id":"AAAAMX%2F%2F91Y%3D","line":3,"updated":"2012-12-04 16:45:01.000000000","message":"nit: indent, visual nesting","commit_id":"dbf700c390d60465be5f3a7621a41c914c20aca8"}],"nova/api/openstack/compute/contrib/agents.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"379c418c8d56964628d9b6488e81d21e126755ca","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        for agent_build in db.agent_build_get_all(context):"},{"line_number":89,"context_line":"            if hypervisor and agent_build.hypervisor !\u003d hypervisor:"},{"line_number":90,"context_line":"                continue"},{"line_number":91,"context_line":"            agents.append({\u0027hypervisor\u0027: agent_build.hypervisor,"},{"line_number":92,"context_line":"                           \u0027os\u0027: agent_build.os,"},{"line_number":93,"context_line":"                           \u0027architecture\u0027: agent_build.architecture,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F%2FkM%3D","line":90,"updated":"2012-11-12 16:05:56.000000000","message":"Seems like it would be a good idea to add a new db api call to get by hypervisor instead of fetching them all and iterating here. Might be able to jam that in the get_all() call as an optional filter too...","commit_id":"218283c91f04c7dea9ef613e28b3492bd76a7ac5"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"7a8522ae02e9d6b24c5f089a36a48e993f4a5d7a","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        for agent_build in db.agent_build_get_all(context):"},{"line_number":89,"context_line":"            if hypervisor and agent_build.hypervisor !\u003d hypervisor:"},{"line_number":90,"context_line":"                continue"},{"line_number":91,"context_line":"            agents.append({\u0027hypervisor\u0027: agent_build.hypervisor,"},{"line_number":92,"context_line":"                           \u0027os\u0027: agent_build.os,"},{"line_number":93,"context_line":"                           \u0027architecture\u0027: agent_build.architecture,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F%2BzM%3D","line":90,"in_reply_to":"AAAAMH%2F%2F%2FkM%3D","updated":"2012-11-13 03:44:01.000000000","message":"It a good idea. I will try it. Thank you for your review.","commit_id":"218283c91f04c7dea9ef613e28b3492bd76a7ac5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"379c418c8d56964628d9b6488e81d21e126755ca","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            if \u0027hypervisor\u0027 in body:"},{"line_number":143,"context_line":"                hypervisor \u003d body[\u0027hypervisor\u0027]"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                hypervisor \u003d body[\u0027hypervisor\u0027] \u003d \u0027xen\u0027"},{"line_number":146,"context_line":"            os \u003d body[\u0027os\u0027]"},{"line_number":147,"context_line":"            architecture \u003d body[\u0027architecture\u0027]"},{"line_number":148,"context_line":"            version \u003d body[\u0027version\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F%2FkI%3D","line":145,"updated":"2012-11-12 16:05:56.000000000","message":"Default to xen? Why?","commit_id":"218283c91f04c7dea9ef613e28b3492bd76a7ac5"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"7a8522ae02e9d6b24c5f089a36a48e993f4a5d7a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            if \u0027hypervisor\u0027 in body:"},{"line_number":143,"context_line":"                hypervisor \u003d body[\u0027hypervisor\u0027]"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                hypervisor \u003d body[\u0027hypervisor\u0027] \u003d \u0027xen\u0027"},{"line_number":146,"context_line":"            os \u003d body[\u0027os\u0027]"},{"line_number":147,"context_line":"            architecture \u003d body[\u0027architecture\u0027]"},{"line_number":148,"context_line":"            version \u003d body[\u0027version\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F%2BzU%3D","line":145,"in_reply_to":"AAAAMH%2F%2F%2FkI%3D","updated":"2012-11-13 03:44:01.000000000","message":"sorry, I\u0027m not sure about it. I just find the default set in the nova-manage code, as the following:\n\nclass AgentBuildCommands(object):\n    \"\"\"Class for managing agent builds.\"\"\"\n\n    def create(self, os, architecture, version, url, md5hash,\n                hypervisor\u003d\u0027xen\u0027):\n\n\nAnd I\u0027m not very sure What are agents? Are they only for XenAPI? If you can give me some information, I will very appreciate it. \n\nThank you for your comments.","commit_id":"218283c91f04c7dea9ef613e28b3492bd76a7ac5"}],"nova/exception.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"379c418c8d56964628d9b6488e81d21e126755ca","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    code \u003d 404"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class AgentBuildNotFoundById(NotFound):"},{"line_number":432,"context_line":"    message \u003d _(\"No agent-build associated with id %(id)s.\")"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F%2Fjs%3D","line":431,"updated":"2012-11-12 16:05:56.000000000","message":"I think just \"AgentBuildNotFound\" would be a better name. Are there any other examples of exceptions here indicating the mechanism? If you omit this, then the exception is useful regardless of how the agent lookup failed.","commit_id":"218283c91f04c7dea9ef613e28b3492bd76a7ac5"}],"nova/tests/integrated/api_samples/os-agents/agent-post-req.xml.tpl":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"62390ce5ed7651b71ba8c52b08e2c5b8a1fbb037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cagent\u003e"},{"line_number":3,"context_line":"\u003chypervisor\u003e%(hypervisor)s\u003c/hypervisor\u003e"},{"line_number":4,"context_line":"\u003cos\u003e%(os)s\u003c/os\u003e"},{"line_number":5,"context_line":"\u003carchitecture\u003e%(architecture)s\u003c/architecture\u003e"},{"line_number":6,"context_line":"\u003cversion\u003e%(version)s\u003c/version\u003e"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"AAAAMX%2F%2F908%3D","line":3,"updated":"2012-12-04 16:45:01.000000000","message":"nit: 2 space indent…","commit_id":"dbf700c390d60465be5f3a7621a41c914c20aca8"}],"nova/tests/integrated/api_samples/os-agents/agent-post-resp.xml.tpl":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"62390ce5ed7651b71ba8c52b08e2c5b8a1fbb037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cagent\u003e"},{"line_number":3,"context_line":"\u003curl\u003e%(url)s\u003c/url\u003e"},{"line_number":4,"context_line":"\u003chypervisor\u003e%(hypervisor)s\u003c/hypervisor\u003e"},{"line_number":5,"context_line":"\u003cmd5hash\u003e%(md5hash)s\u003c/md5hash\u003e"},{"line_number":6,"context_line":"\u003cversion\u003e%(version)s\u003c/version\u003e"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"AAAAMX%2F%2F90w%3D","line":3,"updated":"2012-12-04 16:45:01.000000000","message":"nit: 2 space indent","commit_id":"dbf700c390d60465be5f3a7621a41c914c20aca8"}],"nova/tests/integrated/api_samples/os-agents/agent-update-put-req.xml.tpl":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"62390ce5ed7651b71ba8c52b08e2c5b8a1fbb037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cpara\u003e"},{"line_number":3,"context_line":"\u003cversion\u003e%(version)s\u003c/version\u003e"},{"line_number":4,"context_line":"\u003curl\u003e%(url)s\u003c/url\u003e"},{"line_number":5,"context_line":"\u003cmd5hash\u003e%(md5hash)s\u003c/md5hash\u003e"},{"line_number":6,"context_line":"\u003c/para\u003e"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"AAAAMX%2F%2F90o%3D","line":3,"updated":"2012-12-04 16:45:01.000000000","message":"nit: 2 space indent","commit_id":"dbf700c390d60465be5f3a7621a41c914c20aca8"}],"nova/tests/integrated/api_samples/os-agents/agent-update-put-resp.xml.tpl":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"62390ce5ed7651b71ba8c52b08e2c5b8a1fbb037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cagent\u003e"},{"line_number":3,"context_line":"\u003cagent_id\u003e%(agent_id)d\u003c/agent_id\u003e"},{"line_number":4,"context_line":"\u003cversion\u003e%(version)s\u003c/version\u003e"},{"line_number":5,"context_line":"\u003curl\u003e%(url)s\u003c/url\u003e"},{"line_number":6,"context_line":"\u003cmd5hash\u003e%(md5hash)s\u003c/md5hash\u003e"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"AAAAMX%2F%2F90c%3D","line":3,"updated":"2012-12-04 16:45:01.000000000","message":"nit: 2 space indent","commit_id":"dbf700c390d60465be5f3a7621a41c914c20aca8"}]}