)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7b45033c8fc1ce7dc8b602d80c36fe89a0ac8430","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This removes the overloaded use of CONF.database.connection to point at"},{"line_number":13,"context_line":"the api or main database, and any potential confusion that could result."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"A new config option CONF.api_database.connection has been added."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Co-Authored-By: Andrew Laski \u003candrew.laski@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a80dd14_563063e8","line":15,"updated":"2015-03-11 00:00:31.000000000","message":"So sorry.  Since you implemented *all* the database options in the api_database group I think this line is now wrong.  Perhaps:\n\"A new option group \u0027api_database\u0027 is added to control the connection seetings for the api database\" or similar.","commit_id":"df5145770918b698f51ab94853d276e86b169d7c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c06deed3bd34741321b62065f2faa93e1714f2b7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This removes the overloaded use of CONF.database.connection to point at"},{"line_number":13,"context_line":"the api or main database, and any potential confusion that could result."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"A new config option CONF.api_database.connection has been added."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Co-Authored-By: Andrew Laski \u003candrew.laski@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a80dd14_57712176","line":15,"in_reply_to":"9a80dd14_563063e8","updated":"2015-03-11 14:51:02.000000000","message":"Ahh, good catch.","commit_id":"df5145770918b698f51ab94853d276e86b169d7c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"43a560d52aa0bbafcb7d91475114fac8d6806000","unresolved":false,"context_lines":[{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Co-Authored-By: Andrew Laski \u003candrew.laski@rackspace.com\u003e"},{"line_number":24,"context_line":"Change-Id: Ibd197ec431b052e9c4b3fb05bc4f44ee2f3fbdd4"},{"line_number":25,"context_line":"bp: cells-v2-mapping"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a80dd14_205ef276","line":25,"updated":"2015-03-12 14:18:06.000000000","message":"nit: (thanks to Tony, I missed to review the commit msg, my bad!) it would be cool if you could just mention \n\n  Partially-Implements: blueprint cells-v2-mapping\n\nbut that\u0027s not worth giving -1 for it since we still have the correct BP linked.","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"af76d28216c9e22bfd5f14a35dd7b3af3f863a74","unresolved":false,"context_lines":[{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"Co-Authored-By: Andrew Laski \u003candrew.laski@rackspace.com\u003e"},{"line_number":24,"context_line":"Change-Id: Ibd197ec431b052e9c4b3fb05bc4f44ee2f3fbdd4"},{"line_number":25,"context_line":"bp: cells-v2-mapping"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a80dd14_6607221e","line":25,"in_reply_to":"9a80dd14_205ef276","updated":"2015-03-12 14:53:53.000000000","message":"I didn\u0027t realize that was a thing.  Even if it isn\u0027t it could still be useful.  If I update any patches I\u0027ll modify that.","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"969f4eaabfe444f1721613dd8089a4eb12dd8cdf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"},{"line_number":80,"context_line":"               secret\u003dTrue)"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_2b405333","line":80,"updated":"2015-03-08 07:31:28.000000000","message":"I know during the meeting it was decided to have a single separate option, but I am wondering if it may be better to have all the oslo.db options available for the [api_database] section. Operators may want to set options like pool_size and timeout for the API DB.","commit_id":"a39b4207a68a3968bdf0eabf4091c4088275b286"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"82cf0c8848d69cfa839fa4bc3fc076c27a44cf81","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"},{"line_number":80,"context_line":"               secret\u003dTrue)"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_65594f8d","line":80,"in_reply_to":"9a80dd14_2a001b33","updated":"2015-03-10 13:22:08.000000000","message":"That\u0027s fair.  I\u0027ll add the other options in now.","commit_id":"a39b4207a68a3968bdf0eabf4091c4088275b286"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b44af6d40be55b8fb1d0b30360c0f545ada38bc2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"},{"line_number":80,"context_line":"               secret\u003dTrue)"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_fa0b3ed3","line":80,"in_reply_to":"9a80dd14_2b405333","updated":"2015-03-09 19:39:51.000000000","message":"I agree, we should add those options.  But I think we can add them on later when this gets closer to being a usable thing.","commit_id":"a39b4207a68a3968bdf0eabf4091c4088275b286"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"7f77241ec1aa9460daf6f4ed4453d9061879a84f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"},{"line_number":80,"context_line":"               secret\u003dTrue)"},{"line_number":81,"context_line":"]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_2a001b33","line":80,"in_reply_to":"9a80dd14_fa0b3ed3","updated":"2015-03-10 02:04:46.000000000","message":"I\u0027m on the fence with this approach.  I don\u0027t want to slow you down but if you\u0027re going to implement the oslo.db options in an adhoc basis I think that\u0027ll lead to _create_facade() being kinda ugly.\n\nIsn\u0027t pretty easy to add them all now and pass eitehr CONF.database or CONF.api_database to _create_facade()?","commit_id":"a39b4207a68a3968bdf0eabf4091c4088275b286"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e9768e17f25730cc658e624aec8077067e2ebba8","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _create_facade(connection_str, sqlite_fk\u003dFalse, autocommit\u003dTrue,"},{"line_number":98,"context_line":"                   expire_on_commit\u003dFalse):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    # NOTE(dheeraj): This fragment is copied from oslo.db"},{"line_number":101,"context_line":"    return db_session.EngineFacade("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_ca34df4b","line":98,"updated":"2015-03-10 02:05:01.000000000","message":"AFAICT the only callers of _create_facade() are in this file and none of them use the keyword args.  Are they there for compatibility with the oslo.db code base?","commit_id":"40a9b2d303c1235bf496fd02dbae96727a140498"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d19017dad50db9b569e90582808d7ea610fb53d0","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _create_facade(connection_str, sqlite_fk\u003dFalse, autocommit\u003dTrue,"},{"line_number":98,"context_line":"                   expire_on_commit\u003dFalse):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    # NOTE(dheeraj): This fragment is copied from oslo.db"},{"line_number":101,"context_line":"    return db_session.EngineFacade("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_650b0f7d","line":98,"in_reply_to":"9a80dd14_ca34df4b","updated":"2015-03-10 13:22:18.000000000","message":"This was done by Dheeraj originally, and I\u0027m guessing that was the case.  I can update this to just have the defaults to be in the EngineFacade call, and these can be added later if callers want to modify them.","commit_id":"40a9b2d303c1235bf496fd02dbae96727a140498"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"a8ddb01f52ef57b0b56adcfb37af1dc567a0d839","unresolved":false,"context_lines":[{"line_number":121,"context_line":"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_5efabfbd","line":124,"updated":"2015-03-13 05:00:45.000000000","message":"Shouldn\u0027t there be CONF.register_opts(oslo.db.options.database_opts, \u0027database\u0027) too?","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2aa4469dd3130e7a63af1fb77c02eabec5aaff2a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_998527d1","line":124,"in_reply_to":"9a80dd14_5efabfbd","updated":"2015-03-13 11:04:48.000000000","message":"Oh, good point, because we no longer call this line:\nhttps://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/session.py#L831","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ff26468899557288aa7440e7aad611194dd90ff8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_eb9ba070","line":124,"in_reply_to":"9a80dd14_90f5f1ee","updated":"2015-03-13 14:30:54.000000000","message":"yeah, not sure how its working mind, but I guess it must be working, unless the defaults work by accident.","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"aa5164ac8e98b4dbfd1a01befb3eb571651481b5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_90f5f1ee","line":124,"in_reply_to":"9a80dd14_998527d1","updated":"2015-03-13 14:11:54.000000000","message":"I don\u0027t mind adding it back, but it seems to be getting loaded properly otherwise I expect that Tempest testing would be failing.","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"a8ddb01f52ef57b0b56adcfb37af1dc567a0d839","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_fe0b73d3","line":125,"updated":"2015-03-13 05:00:45.000000000","message":"Rather than redefine bunch of options can\u0027t we re-use the options defined in oslo.db and register them under a new group \u0027api_database\u0027?\n\nSomething like CONF.register_opts(oslo.db.options.database_opts, \u0027api_database\u0027)","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"aa5164ac8e98b4dbfd1a01befb3eb571651481b5","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_70da3d4c","line":125,"in_reply_to":"9a80dd14_1971370c","updated":"2015-03-13 14:11:54.000000000","message":"If that works the way we expect, sure.  Because of the way that deprecated options are defined I\u0027m not sure this will actually work.  For example, sql_connection in the default group is aliased to oslo.db.options.database_opts.connection if that is also registered for api_db_opts.connection what happens when sql_connection and api_database.connection is defined?","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ff26468899557288aa7440e7aad611194dd90ff8","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_0beb94dc","line":125,"in_reply_to":"9a80dd14_70da3d4c","updated":"2015-03-13 14:30:54.000000000","message":"ah, good point... but it sucks to have the cut and paste, hmm... getting the values for these configs from the oslo ones seems crazy too. I guess this could work as it is if we have to.","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2aa4469dd3130e7a63af1fb77c02eabec5aaff2a","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"CONF \u003d cfg.CONF"},{"line_number":124,"context_line":"CONF.register_opts(db_opts)"},{"line_number":125,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":126,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_1971370c","line":125,"in_reply_to":"9a80dd14_fe0b73d3","updated":"2015-03-13 11:04:48.000000000","message":"I actually like that idea now, but only because we probably need that other line too, at the moment.","commit_id":"ea80a5e3d9ed05d957dbf6b2a12a4c22164ce694"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"cc6e11df3934c5a82e759807d17774bb729d1bec","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    \u0027Should be empty, \"project\" or \"global\".\u0027),"},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"api_db_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_3845fa42","line":76,"updated":"2015-03-13 19:31:57.000000000","message":"why can\u0027t oslo_db.options.database_opts be reused here?    Can simple changes to oslo_db.options.database_opts be proposed to oslo so that nova does not have to copy 60 lines of code?","commit_id":"3545fd6d55d713851061226798133662a4c8dbf7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"b39d39f4f23405fc5d52473c1ea631f0523ea47f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    \u0027Should be empty, \"project\" or \"global\".\u0027),"},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"api_db_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_730a358b","line":76,"in_reply_to":"9a80dd14_3845fa42","updated":"2015-03-13 20:03:27.000000000","message":"I think we\u0027re at a timing issue with the release, this won\u0027t change the interface going forward, so I think it\u0027s fine to work on an oslo.db fix for multiple dbs in Liberty instead.","commit_id":"3545fd6d55d713851061226798133662a4c8dbf7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"5e4ed077781bcde2e1bf55f9cfa17d6fca9052d2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                    \u0027Should be empty, \"project\" or \"global\".\u0027),"},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"api_db_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":78,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":79,"context_line":"                    \u0027the Nova API database.\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_9f56cb28","line":76,"in_reply_to":"9a80dd14_730a358b","updated":"2015-03-13 20:38:18.000000000","message":"Timing is exactly the issue.  I would like to do the work in oslo_db to facilitate what I\u0027m trying to do here, but I\u0027m up against a deadline in Nova at the moment.","commit_id":"3545fd6d55d713851061226798133662a4c8dbf7"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"410bc2a5da3355c4895d721ef95d011ce102564e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"CONF \u003d cfg.CONF"},{"line_number":125,"context_line":"CONF.register_opts(db_opts)"},{"line_number":126,"context_line":"CONF.register_opts(oslo_db_options.database_opts, \u0027database\u0027)"},{"line_number":127,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":128,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_283f79b5","line":126,"updated":"2015-03-13 15:35:28.000000000","message":"The register_opts for database is called in nova/config.py (options.set_defaults) via https://github.com/openstack/oslo.db/blob/master/oslo_db/options.py#L192. So the options are already registered and this line will apparently do nothing. Apologies.","commit_id":"3545fd6d55d713851061226798133662a4c8dbf7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"83b9b6b1fee86bb1e1060ad348ac6f16194d0ffb","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"CONF \u003d cfg.CONF"},{"line_number":125,"context_line":"CONF.register_opts(db_opts)"},{"line_number":126,"context_line":"CONF.register_opts(oslo_db_options.database_opts, \u0027database\u0027)"},{"line_number":127,"context_line":"CONF.register_opts(api_db_opts, group\u003d\u0027api_database\u0027)"},{"line_number":128,"context_line":"CONF.import_opt(\u0027compute_topic\u0027, \u0027nova.compute.rpcapi\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_ab3283a4","line":126,"in_reply_to":"9a80dd14_283f79b5","updated":"2015-03-13 15:49:58.000000000","message":"Not a problem.  It\u0027s better to call it here anyways since this is near where it\u0027s used rather than relying on it being loaded in a tucked away place.","commit_id":"3545fd6d55d713851061226798133662a4c8dbf7"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"cc6e11df3934c5a82e759807d17774bb729d1bec","unresolved":false,"context_lines":[{"line_number":138,"context_line":"def _create_facade(conf_group):"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # NOTE(dheeraj): This fragment is copied from oslo.db"},{"line_number":141,"context_line":"    return db_session.EngineFacade("},{"line_number":142,"context_line":"        sql_connection\u003dconf_group.connection,"},{"line_number":143,"context_line":"        slave_connection\u003dconf_group.slave_connection,"},{"line_number":144,"context_line":"        sqlite_fk\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_f810c24f","line":141,"updated":"2015-03-13 19:31:57.000000000","message":"is there no way we can use EngineFacade.from_config here?  I see that it hardcodes to \"conf.database\"  I don\u0027t understand why a few simple changes can\u0027t be proposed to oslo.db in order to make this possible.   All of this duplication is just that much more code we on the oslo.db team will have to get ripped out of here.","commit_id":"3545fd6d55d713851061226798133662a4c8dbf7"}]}