)]}'
{"nova/tests/unit/virt/vmwareapi/fake.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"345c223cdec35fe6681d1fc6902166554d0c4c24","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"    return {\u0027type\u0027: \u0027fake\u0027}"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"def assertPathExists(test, path):"},{"line_number":1053,"context_line":"    test.assertIn(path, _db_content.get(\u0027files\u0027))"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1e43466d","line":1052,"updated":"2015-03-17 16:24:21.000000000","message":"All the users of these seem to be in the same test class. Why not just make this an instancemethod on that class instead of passing the test in?","commit_id":"e9a19aad7b303ea4e2b8d33d83efae65847ed40c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"1c2150af9f2666f17ad87aa07c8c62511e200676","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"    return {\u0027type\u0027: \u0027fake\u0027}"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"def assertPathExists(test, path):"},{"line_number":1053,"context_line":"    test.assertIn(path, _db_content.get(\u0027files\u0027))"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_94fab741","line":1052,"in_reply_to":"9a80dd14_1e43466d","updated":"2015-03-17 16:52:53.000000000","message":"Yes, this is a hokey design flag :)\n\nThe alternative was to expose \"_db_content.get(\u0027files\u0027)\" to the test, which is also a hokey design flag. It was a toss-up. Picked this one because there\u0027s no reason the tests should all be in the same test class (probably its own hokey design flag, in fact).","commit_id":"e9a19aad7b303ea4e2b8d33d83efae65847ed40c"}]}