)]}'
{"nova/virt/disk/vfs/localfs.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1a49499f7c2c401c910cb5d06badd9d6fe8d1096","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                                     \u0027value\u0027, \u0027-s\u0027,"},{"line_number":166,"context_line":"                                     \u0027TYPE\u0027, self.mount.device,"},{"line_number":167,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":168,"context_line":"                                     check_exit_code\u003d[0, 2])"},{"line_number":169,"context_line":"            return out.strip()"},{"line_number":170,"context_line":"        return \"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_263753b2","line":168,"updated":"2015-03-04 10:39:32.000000000","message":"The only expected value here is 0, when here it means we have well mounted the fs.","commit_id":"27bbef87c4f0830c04844b1e4b0b2619a9e37530"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"9180d969036a7e110ecfe41889dbd16c2f897db3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                                     \u0027value\u0027, \u0027-s\u0027,"},{"line_number":166,"context_line":"                                     \u0027TYPE\u0027, self.mount.device,"},{"line_number":167,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":168,"context_line":"                                     check_exit_code\u003d[0, 2])"},{"line_number":169,"context_line":"            return out.strip()"},{"line_number":170,"context_line":"        return \"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_50064721","line":168,"in_reply_to":"9a80dd14_263753b2","updated":"2015-03-12 18:06:07.000000000","message":"0 means that blkid read the TYPE value from the block device, not that its correctly mounted; 2 indicates that it was read, but the TYPE value was not found.","commit_id":"27bbef87c4f0830c04844b1e4b0b2619a9e37530"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"887099c3a7175c35bc9fc7dc38c37fe58839108d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            utils.execute(cmd, owner, canonpath, run_as_root\u003dTrue)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def get_image_fs(self):"},{"line_number":163,"context_line":"        if self.mount.device or self.mount.get_dev():"},{"line_number":164,"context_line":"            out, err \u003d utils.execute(\u0027blkid\u0027, \u0027-o\u0027,"},{"line_number":165,"context_line":"                                     \u0027value\u0027, \u0027-s\u0027,"},{"line_number":166,"context_line":"                                     \u0027TYPE\u0027, self.mount.device,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_1909142d","side":"PARENT","line":163,"updated":"2015-05-11 14:26:05.000000000","message":"Well if we was able to mount the device so we expect to be able to get the filesystem. I do not believe we want to let this method returning nothing in that case.\n\nThis method is invoked in disk/api.py and the result is compared against a list of SUPPORTED_FS_TO_EXTEND so I think it\u0027s bad design to handle that case when we are not able to read the filesystem while the disk is mounted with this way.\n\nThe method should handle when utils.execute raise an ProcessException and reraise it has a NovaException then is_image_extendable will handle it.","commit_id":"df04ec843a9d32d30ec99ba07b5e757281dfdbb5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"554de17eeec9b1949759cf738272926ae9e1215d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            utils.execute(cmd, owner, canonpath, run_as_root\u003dTrue)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def get_image_fs(self):"},{"line_number":163,"context_line":"        if self.mount.device or self.mount.get_dev():"},{"line_number":164,"context_line":"            out, err \u003d utils.execute(\u0027blkid\u0027, \u0027-o\u0027,"},{"line_number":165,"context_line":"                                     \u0027value\u0027, \u0027-s\u0027,"},{"line_number":166,"context_line":"                                     \u0027TYPE\u0027, self.mount.device,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad8896b_4e1db30e","side":"PARENT","line":163,"in_reply_to":"9af37de9_1909142d","updated":"2015-05-11 16:23:03.000000000","message":"If get_image_fs() doesn\u0027t return anything, the check in is_image_extendable will be False so is_image_extendable will return False, same as if we handled the ProcessExecutionError as NovaException in there, which doesn\u0027t fail, it just logs a warning that we can\u0027t resize.","commit_id":"df04ec843a9d32d30ec99ba07b5e757281dfdbb5"}]}