)]}'
{"nova/api/openstack/compute/contrib/availability_zone.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1509937e4a9d87ad2f868a5e889c41be4a80c06","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        authorize_detail(context)"},{"line_number":115,"context_line":"        # NOTE(alex_xu): back-compatible with db layer hard-code admin"},{"line_number":116,"context_line":"        # permission checks."},{"line_number":117,"context_line":"        nova_context.require_admin_context(context)"},{"line_number":118,"context_line":"        return self._describe_availability_zones_verbose(context)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_9abb7e74","line":117,"updated":"2015-03-18 19:56:02.000000000","message":"nit: I\u0027d probably move this into _describe_availability_zones_verbose so it\u0027s closer to the actual code that\u0027s going to use the context, and just in case something ever comes along and calls _describe_availability_zones_verbose since it\u0027s a private method.","commit_id":"e5d0531d8ed4efcd612c0597557e5651c16294b5"}],"nova/tests/unit/fake_policy.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7da83f737d3355118c00ef8f930f864e6634029e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    \"compute_extension:v3:os-fping:all_tenants\": \"is_admin:True\","},{"line_number":230,"context_line":"    \"compute_extension:hide_server_addresses\": \"\","},{"line_number":231,"context_line":"    \"compute_extension:v3:os-hide-server-addresses\": \"\","},{"line_number":232,"context_line":"    \"compute_extension:hosts\": \"\","},{"line_number":233,"context_line":"    \"compute_extension:v3:os-hosts\": \"rule:admin_api\","},{"line_number":234,"context_line":"    \"compute_extension:hypervisors\": \"rule:admin_api\","},{"line_number":235,"context_line":"    \"compute_extension:v3:os-hypervisors\": \"rule:admin_api\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_edd2185a","line":232,"updated":"2015-03-18 14:31:30.000000000","message":"In this change you remove the admin restriction for the v3 API:\n\nhttps://review.openstack.org/#/c/150354/9/nova/tests/unit/fake_policy.py\n\nBut here you\u0027re changing the v2 API, so I\u0027m confused about consistency.","commit_id":"90d1d0823ae100b0727792f3c56e69b151ab683c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4dd1a1ce41b50de1e307437b22f6bff92ec2c1de","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    \"compute_extension:v3:os-fping:all_tenants\": \"is_admin:True\","},{"line_number":230,"context_line":"    \"compute_extension:hide_server_addresses\": \"\","},{"line_number":231,"context_line":"    \"compute_extension:v3:os-hide-server-addresses\": \"\","},{"line_number":232,"context_line":"    \"compute_extension:hosts\": \"\","},{"line_number":233,"context_line":"    \"compute_extension:v3:os-hosts\": \"rule:admin_api\","},{"line_number":234,"context_line":"    \"compute_extension:hypervisors\": \"rule:admin_api\","},{"line_number":235,"context_line":"    \"compute_extension:v3:os-hypervisors\": \"rule:admin_api\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_c88d42d5","line":232,"in_reply_to":"9a80dd14_edd2185a","updated":"2015-03-18 15:17:24.000000000","message":"After check the code, I get some memory back. This change is for the test \u0027 test_list_hosts_with_non_admin(self):\u0027 in https://review.openstack.org/#/c/160088/8/nova/tests/unit/api/openstack/compute/contrib/test_hosts.py\n\nThe reason I didn\u0027t change v3 policy is because that is not the scope for this patch. The tuning of test_hosts is the scope of cleanup compute_node_* db call.\n\nBut......when I separated service and comptue_node db call patch....I forgot compute_node_*... Those only can be fixed as bug in L I guess.","commit_id":"90d1d0823ae100b0727792f3c56e69b151ab683c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1509937e4a9d87ad2f868a5e889c41be4a80c06","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    \"compute_extension:hide_server_addresses\": \"\","},{"line_number":231,"context_line":"    \"compute_extension:v3:os-hide-server-addresses\": \"\","},{"line_number":232,"context_line":"    \"compute_extension:hosts\": \"\","},{"line_number":233,"context_line":"    \"compute_extension:v3:os-hosts\": \"rule:admin_api\","},{"line_number":234,"context_line":"    \"compute_extension:hypervisors\": \"rule:admin_api\","},{"line_number":235,"context_line":"    \"compute_extension:v3:os-hypervisors\": \"rule:admin_api\","},{"line_number":236,"context_line":"    \"compute_extension:image_size\": \"\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_5a80268b","line":233,"updated":"2015-03-18 19:56:02.000000000","message":"I still don\u0027t really understand why this rule is in here but not for v2, something about the tests and we can\u0027t fix until L?","commit_id":"e5d0531d8ed4efcd612c0597557e5651c16294b5"}]}