)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":11189,"name":"yuntongjin","email":"yuntong.jin@intel.com","username":"yuntong"},"change_message_id":"f0c33c91a0e8b4cc99e7f0b51283d59d258562f8","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"    return result"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"def fixed_ip_get_by_host(context, host):"},{"line_number":1305,"context_line":"    session \u003d get_session()"},{"line_number":1306,"context_line":"    with session.begin():"},{"line_number":1307,"context_line":"        instance_uuids \u003d _instance_get_all_uuids_by_host(context, host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_6a49178b","line":1304,"updated":"2015-03-04 06:14:44.000000000","message":"This func is called by nova/cmd/manager, if the policy enforcement removed here, where to policy check this action ?","commit_id":"e45516ddc6f4b9f407b31edd48cc13c96600b6ea"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"7c659936feed2b094134f5f6a822f0230eb36ce0","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"    return result"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"def fixed_ip_get_by_host(context, host):"},{"line_number":1305,"context_line":"    session \u003d get_session()"},{"line_number":1306,"context_line":"    with session.begin():"},{"line_number":1307,"context_line":"        instance_uuids \u003d _instance_get_all_uuids_by_host(context, host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_d5311bee","line":1304,"in_reply_to":"9a80dd14_6a49178b","updated":"2015-03-07 08:39:40.000000000","message":"There are two thins, you should know.\n1. nova/cmd/manager is not the rpc server.\n2. nova/cmd/manager  also elevated the context. \n\ncan you remove your -1?","commit_id":"e45516ddc6f4b9f407b31edd48cc13c96600b6ea"},{"author":{"_account_id":11189,"name":"yuntongjin","email":"yuntong.jin@intel.com","username":"yuntong"},"change_message_id":"7a51fd26654fdc654eaf8d96d67e60e9ace28700","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"    return result"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"def fixed_ip_get_by_host(context, host):"},{"line_number":1305,"context_line":"    session \u003d get_session()"},{"line_number":1306,"context_line":"    with session.begin():"},{"line_number":1307,"context_line":"        instance_uuids \u003d _instance_get_all_uuids_by_host(context, host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1d490860","line":1304,"in_reply_to":"9a80dd14_d5311bee","updated":"2015-03-09 06:15:52.000000000","message":"Sounds fair.","commit_id":"e45516ddc6f4b9f407b31edd48cc13c96600b6ea"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"67623487b3c53c7b8e5c64c9ea82838152fd403c","unresolved":false,"context_lines":[{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":""},{"line_number":1308,"context_line":"@require_admin_context"},{"line_number":1309,"context_line":"def fixed_ip_get_all(context):"},{"line_number":1310,"context_line":"    result \u003d model_query(context, models.FixedIp, read_deleted\u003d\"yes\").all()"},{"line_number":1311,"context_line":"    if not result:"},{"line_number":1312,"context_line":"        raise exception.NoFixedIpsDefined()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_7555a91b","side":"PARENT","line":1309,"updated":"2015-04-28 08:07:22.000000000","message":"this method is called from FixedIPList.get_all() and the method is just called from unit test. So this removal is safe.","commit_id":"dc06cf40c44eabcd99ad97486914515a839d2fc4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"67623487b3c53c7b8e5c64c9ea82838152fd403c","unresolved":false,"context_lines":[{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"@require_admin_context"},{"line_number":1394,"context_line":"def fixed_ip_get_by_host(context, host):"},{"line_number":1395,"context_line":"    session \u003d get_session()"},{"line_number":1396,"context_line":"    with session.begin():"},{"line_number":1397,"context_line":"        instance_uuids \u003d _instance_get_all_uuids_by_host(context, host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_f05b072d","side":"PARENT","line":1394,"updated":"2015-04-28 08:07:22.000000000","message":"This method is called from FixedIPList.get_by_host() and the method also is just called from unit test.","commit_id":"dc06cf40c44eabcd99ad97486914515a839d2fc4"}]}
