)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0d96175622a1dd75de99236d986d5eadfc191fb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"up quota related queries."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changing the migration scripts to allow an already existing"},{"line_number":13,"context_line":" project_id+deleted index."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1378395"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa041b7_91fed136","line":13,"updated":"2015-04-03 14:41:31.000000000","message":"None of this makes much sense to me until someone explained it. I propose that we change this to:\n\nMake 274 idempotent so that it can be backported.","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4554784948b9f936d0657e5f94f7972015e1ecf3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Changing the migration scripts to allow an already existing"},{"line_number":13,"context_line":" project_id+deleted index."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1378395"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie2492f98374544003bfc9b3b7f8c4a4a7a54ba8d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa041b7_51ff29aa","line":15,"updated":"2015-04-03 14:31:09.000000000","message":"We should have a new bug for this.  This points to the original bug that jerdfelt opened, I don\u0027t see any comments in there about why we need to change this.","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"}],"nova/db/sqlalchemy/migrate_repo/versions/274_update_instances_project_id_index.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5ef55f1a4291785271d1c8a78356d3a6f43f7e2b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    for index in instances.indexes:"},{"line_number":35,"context_line":"        if [c.name for c in index.columns] \u003d\u003d [\u0027project_id\u0027, \u0027deleted\u0027]:"},{"line_number":36,"context_line":"            LOG.info(_LI(\u0027Skipped adding instances_project_id_deleted_idx \u0027"},{"line_number":37,"context_line":"                         \u0027because an equivalent index already exists.\u0027))"},{"line_number":38,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_84557451","line":35,"updated":"2015-04-03 14:07:13.000000000","message":"Are we sure that this list comp will always return those names in that order? Seems brittle to me. I would prefer:\n\n    if set([c.name for c in index.columns]) \u003d\u003d set([\u0027project_id\u0027, \u0027deleted\u0027]):","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"886d09b04bac26ca6ef71eaa49b80d114cafa55d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    for index in instances.indexes:"},{"line_number":35,"context_line":"        if [c.name for c in index.columns] \u003d\u003d [\u0027project_id\u0027, \u0027deleted\u0027]:"},{"line_number":36,"context_line":"            LOG.info(_LI(\u0027Skipped adding instances_project_id_deleted_idx \u0027"},{"line_number":37,"context_line":"                         \u0027because an equivalent index already exists.\u0027))"},{"line_number":38,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_b1a435a6","line":35,"in_reply_to":"baa041b7_84557451","updated":"2015-04-03 14:33:31.000000000","message":"Yeah it\u0027s probably safer to do a sorted list like in the 248 migration:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/migrate_repo/versions/248_add_expire_reservations_index.py#n23","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"719196d8fdcee910a5ed652985bd74021dfc041f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    for index in instances.indexes:"},{"line_number":35,"context_line":"        if [c.name for c in index.columns] \u003d\u003d [\u0027project_id\u0027, \u0027deleted\u0027]:"},{"line_number":36,"context_line":"            LOG.info(_LI(\u0027Skipped adding instances_project_id_deleted_idx \u0027"},{"line_number":37,"context_line":"                         \u0027because an equivalent index already exists.\u0027))"},{"line_number":38,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_d18699da","line":35,"in_reply_to":"baa041b7_b1a435a6","updated":"2015-04-03 14:39:59.000000000","message":"Nevermind, we don\u0027t want this sorted, the order of the columns matters.","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e9cf9badf055d50316f12e188de47a973ea0e9bd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        index \u003d Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":41,"context_line":"                      instances.c.project_id, instances.c.deleted)"},{"line_number":42,"context_line":"        index.create()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    for index in instances.indexes:"},{"line_number":45,"context_line":"        if [c.name for c in index.columns] \u003d\u003d [\u0027project_id\u0027]:"},{"line_number":46,"context_line":"            index.drop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_691372b9","line":43,"updated":"2015-04-03 10:00:42.000000000","message":"you can\u0027t just modify an existing migration, in particular as this change can\u0027t be merged for Kilo (data migration) so it would be added in Liberty.\n\nInstead of doing that, you have to add a new migration version which would fix what\u0027s wrong and then we could perhaps backport that migration if that\u0027s really useful for Kilo (using the left versions).\n\nAlso FYI, there is an effort in Kilo on providing no db migrations using sqla-migrate, we probably need to discuss on the status by the Vancouver summit.","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0ae2c8c368e106246779addf0b16208551115a7a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        index \u003d Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":41,"context_line":"                      instances.c.project_id, instances.c.deleted)"},{"line_number":42,"context_line":"        index.create()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    for index in instances.indexes:"},{"line_number":45,"context_line":"        if [c.name for c in index.columns] \u003d\u003d [\u0027project_id\u0027]:"},{"line_number":46,"context_line":"            index.drop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_8902360a","line":43,"in_reply_to":"baa041b7_691372b9","updated":"2015-04-03 10:11:05.000000000","message":"s/data mig/DB mig\n\nYou\u0027re not manipulating data obviously, made a typo.","commit_id":"788d5124108380d74f7f5c61bb5b3c6c60958581"}]}