)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"9211a0225a883f70bc1821fde50a2b42ca886c0f","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"UpgradeImpact: Due to the db layer permission checks deleted. There need"},{"line_number":21,"context_line":"default policy rule instead of that. In this patch,"},{"line_number":22,"context_line":"\"compute_extension:v3:os-quota-class-sets:update\" was updated with a default"},{"line_number":23,"context_line":"rule. Admin will be notfied to update their policy configure file to keep"},{"line_number":24,"context_line":"the behavior as before."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_98587a58","line":22,"updated":"2015-05-06 15:28:30.000000000","message":"\"os_compute_api:os-quota-class-sets:show\" ?","commit_id":"86a04fc6c493f76588fa7e8a2f25e2694a5f47d0"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"421f6bd4e3997ac893f2e351781b56fec9183ffc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove db layer hard-code permission checks for quota_class_get_all_by_name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patches remove the hard-code permission checks for db call"},{"line_number":10,"context_line":"quota_class_get_all_by_name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For v2 api, there already have same hard-code permission checks in REST API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_92571f02","line":9,"updated":"2015-05-07 05:44:51.000000000","message":"patch removes","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f61ada6915508c29075ef11c416083a3d33220af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove db layer hard-code permission checks for quota_class_get_all_by_name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patches remove the hard-code permission checks for db call"},{"line_number":10,"context_line":"quota_class_get_all_by_name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For v2 api, there already have same hard-code permission checks in REST API"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_32704b72","line":9,"in_reply_to":"1aca2d91_92571f02","updated":"2015-05-07 05:51:10.000000000","message":"Done","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"421f6bd4e3997ac893f2e351781b56fec9183ffc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For v2 api, there already have same hard-code permission checks in REST API"},{"line_number":13,"context_line":"layer, so it is back-compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For v2.1 api, for distinguish show and update permission, this patch adds"},{"line_number":16,"context_line":"new rule for show method."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially implements bp nova-api-policy-final-part"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_323f2bb6","line":15,"updated":"2015-05-07 05:44:51.000000000","message":"s/for/to","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f61ada6915508c29075ef11c416083a3d33220af","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For v2 api, there already have same hard-code permission checks in REST API"},{"line_number":13,"context_line":"layer, so it is back-compatible."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For v2.1 api, for distinguish show and update permission, this patch adds"},{"line_number":16,"context_line":"new rule for show method."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially implements bp nova-api-policy-final-part"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_126d4f98","line":15,"in_reply_to":"1aca2d91_323f2bb6","updated":"2015-05-07 05:51:10.000000000","message":"Done","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"421f6bd4e3997ac893f2e351781b56fec9183ffc","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially implements bp nova-api-policy-final-part"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"UpgradeImpact: Due to the db layer permission checks deleted. There need"},{"line_number":21,"context_line":"default policy rule instead of that. In this patch,"},{"line_number":22,"context_line":"\"os_compute_api:os-quota-class-sets:update\" was updated with a default"},{"line_number":23,"context_line":"rule. Admin will be notfied to update their policy configure file to keep"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_727363b2","line":20,"updated":"2015-05-07 05:44:51.000000000","message":"sorry, I don\u0027t understand, do you want to say: \nDue to the db layer permission checks deleted,(comma) they need\ndefault policy rule ...","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f61ada6915508c29075ef11c416083a3d33220af","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially implements bp nova-api-policy-final-part"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"UpgradeImpact: Due to the db layer permission checks deleted. There need"},{"line_number":21,"context_line":"default policy rule instead of that. In this patch,"},{"line_number":22,"context_line":"\"os_compute_api:os-quota-class-sets:update\" was updated with a default"},{"line_number":23,"context_line":"rule. Admin will be notfied to update their policy configure file to keep"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_f269b38c","line":20,"in_reply_to":"1aca2d91_727363b2","updated":"2015-05-07 05:51:10.000000000","message":"Done","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"421f6bd4e3997ac893f2e351781b56fec9183ffc","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"UpgradeImpact: Due to the db layer permission checks deleted. There need"},{"line_number":21,"context_line":"default policy rule instead of that. In this patch,"},{"line_number":22,"context_line":"\"os_compute_api:os-quota-class-sets:update\" was updated with a default"},{"line_number":23,"context_line":"rule. Admin will be notfied to update their policy configure file to keep"},{"line_number":24,"context_line":"the behavior as before."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_b2a0dbf5","line":22,"updated":"2015-05-07 05:44:51.000000000","message":"hmm.. do you mean \n\nos_compute_api:os-quota-class-sets:show","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f61ada6915508c29075ef11c416083a3d33220af","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"UpgradeImpact: Due to the db layer permission checks deleted. There need"},{"line_number":21,"context_line":"default policy rule instead of that. In this patch,"},{"line_number":22,"context_line":"\"os_compute_api:os-quota-class-sets:update\" was updated with a default"},{"line_number":23,"context_line":"rule. Admin will be notfied to update their policy configure file to keep"},{"line_number":24,"context_line":"the behavior as before."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aca2d91_d20597c2","line":22,"in_reply_to":"1aca2d91_b2a0dbf5","updated":"2015-05-07 05:51:10.000000000","message":"Done","commit_id":"7d1278eed0aa66ccdc162870d5362accf3095a8f"}],"nova/api/openstack/compute/plugins/v3/quota_classes.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"421f6bd4e3997ac893f2e351781b56fec9183ffc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":67,"context_line":"        authorize(context)"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            nova.context.authorize_quota_class_context(context, id)"},{"line_number":70,"context_line":"            values \u003d QUOTAS.get_class_quotas(context, id)"},{"line_number":71,"context_line":"            return self._format_quota_set(id, values)"},{"line_number":72,"context_line":"        except exception.Forbidden:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_32dbab7e","side":"PARENT","line":69,"updated":"2015-05-07 05:44:51.000000000","message":"you\u0027v moved this out, so will  QUOTAS.get_class_quotas exception.Forbidden?\nif not, we need to remove the exception handler and 403.\nor do you want not leave it and clean up them all together?","commit_id":"a85d45cc08eaaedad2ebe8427203d4866d17172a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f61ada6915508c29075ef11c416083a3d33220af","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":67,"context_line":"        authorize(context)"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            nova.context.authorize_quota_class_context(context, id)"},{"line_number":70,"context_line":"            values \u003d QUOTAS.get_class_quotas(context, id)"},{"line_number":71,"context_line":"            return self._format_quota_set(id, values)"},{"line_number":72,"context_line":"        except exception.Forbidden:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_32f72bd5","side":"PARENT","line":69,"in_reply_to":"1aca2d91_32dbab7e","updated":"2015-05-07 05:51:10.000000000","message":"yes, we should remove it.","commit_id":"a85d45cc08eaaedad2ebe8427203d4866d17172a"}],"nova/context.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b9468e8c74a07e4a648ed79055094e5bcbb7e49b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            raise exception.Forbidden()"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"def authorize_quota_class_context(context, class_name):"},{"line_number":265,"context_line":"    \"\"\"Ensures a request has permission to access the given quota class.\"\"\""},{"line_number":266,"context_line":"    if is_user_context(context):"},{"line_number":267,"context_line":"        if not context.quota_class:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_cea98092","line":264,"updated":"2015-06-19 13:54:14.000000000","message":"We should leave a TODO \"Remove the method once legacy V2.0 is removed from in tree\"","commit_id":"dd7aca0f19071758756c0179c536f76d2a4acc91"}]}