)]}'
{"nova/api/openstack/compute/views/versions.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c146edde2b7bad7bf560a0077c2d3ec4fdaf42de","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"versions_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027, default\u003dNone,"},{"line_number":27,"context_line":"               help\u003d_(\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":28,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":29,"context_line":"                      \u0027attribute to populate the URL base. If Nova is \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_275a5f84","line":26,"updated":"2015-04-13 05:19:41.000000000","message":"the default value is None - so we do not need default\u003dNone","commit_id":"26752e34032d0c025c6b777edf01850d4b1bc617"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"5661ceb409423ad2ac6eaba45e4e288901255fd8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"versions_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027, default\u003dNone,"},{"line_number":27,"context_line":"               help\u003d_(\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":28,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":29,"context_line":"                      \u0027attribute to populate the URL base. If Nova is \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_a5d30438","line":26,"in_reply_to":"7aaa499b_275a5f84","updated":"2015-04-14 02:22:28.000000000","message":"agree","commit_id":"26752e34032d0c025c6b777edf01850d4b1bc617"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c146edde2b7bad7bf560a0077c2d3ec4fdaf42de","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"versions_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027, default\u003dNone,"},{"line_number":27,"context_line":"               help\u003d_(\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":28,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":29,"context_line":"                      \u0027attribute to populate the URL base. If Nova is \u0027"},{"line_number":30,"context_line":"                      \u0027operating behind a proxy, you will want to change \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_c7517b64","line":27,"updated":"2015-04-13 05:19:41.000000000","message":"there os no need to translate the help (that is not the convention in nova)","commit_id":"26752e34032d0c025c6b777edf01850d4b1bc617"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"5661ceb409423ad2ac6eaba45e4e288901255fd8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"versions_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027, default\u003dNone,"},{"line_number":27,"context_line":"               help\u003d_(\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":28,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":29,"context_line":"                      \u0027attribute to populate the URL base. If Nova is \u0027"},{"line_number":30,"context_line":"                      \u0027operating behind a proxy, you will want to change \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_1fa547b4","line":27,"in_reply_to":"7aaa499b_c7517b64","updated":"2015-04-14 02:22:28.000000000","message":"hi garyk, thanks for your suggestion","commit_id":"26752e34032d0c025c6b777edf01850d4b1bc617"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"1b5b3cd0080904c1d5e208c95eb1d5ee54e14367","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"versions_opts \u003d ["},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":27,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":28,"context_line":"                      \u0027attribute to populate the URL base. If Nova is \u0027"},{"line_number":29,"context_line":"                      \u0027operating behind a proxy, you will want to change \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_9ffef736","line":26,"updated":"2015-04-14 02:50:34.000000000","message":"is here a indent nit ?","commit_id":"2a8883dae07b5f360d4f462aee0bd3f4771a2f4c"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"588d302d43e41c5a1523d02d824e2ce581ae1673","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"versions_opts \u003d ["},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027public_endpoint\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027Public url to use for versions endpoint. The default \u0027"},{"line_number":27,"context_line":"                      \u0027is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":28,"context_line":"                      \u0027attribute to populate the URL base. If Nova is \u0027"},{"line_number":29,"context_line":"                      \u0027operating behind a proxy, you will want to change \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_107d346e","line":26,"in_reply_to":"7aaa499b_9ffef736","updated":"2015-04-14 05:10:12.000000000","message":"Done","commit_id":"2a8883dae07b5f360d4f462aee0bd3f4771a2f4c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b47a9fdd68c8717b1e6a1add22e035056b7fb778","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                    \u0027value is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":28,"context_line":"                    \u0027attribute to populate the URL base. If Nova is \u0027"},{"line_number":29,"context_line":"                    \u0027operating behind a proxy, you will want to change \u0027"},{"line_number":30,"context_line":"                    \u0027this to represent the proxy\\\u0027s URL.\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_06a40d55","line":30,"updated":"2015-04-20 12:20:05.000000000","message":"Can we please give an example of a valid URL, does it need the \"\\\", etc?","commit_id":"0792e7cfd402cba21b0674a85aeb07228e06ff61"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"41efb745b3791622d661cc2e0d9d705a68a3291a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                    \u0027value is None, which will use the request\\\u0027s host_url \u0027"},{"line_number":28,"context_line":"                    \u0027attribute to populate the URL base. If Nova is \u0027"},{"line_number":29,"context_line":"                    \u0027operating behind a proxy, you will want to change \u0027"},{"line_number":30,"context_line":"                    \u0027this to represent the proxy\\\u0027s URL.\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_053503d9","line":30,"in_reply_to":"dac4157f_06a40d55","updated":"2015-04-21 02:43:19.000000000","message":"\"\\\" is a escape character.Do you mean giving an example in help info?","commit_id":"0792e7cfd402cba21b0674a85aeb07228e06ff61"}],"nova/tests/unit/test_versions.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"789c632666032caa5fa7a0745361e53350ebdade","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import __builtin__"},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"import StringIO"},{"line_number":18,"context_line":"import webob"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova.api.openstack.compute import versions"},{"line_number":21,"context_line":"from nova import test"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_df70ffde","line":18,"updated":"2015-04-14 02:56:02.000000000","message":"maybe it is better to move the above two lines to the first secition (next to the \"import __builtin__\")","commit_id":"2a8883dae07b5f360d4f462aee0bd3f4771a2f4c"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"588d302d43e41c5a1523d02d824e2ce581ae1673","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import __builtin__"},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"import StringIO"},{"line_number":18,"context_line":"import webob"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova.api.openstack.compute import versions"},{"line_number":21,"context_line":"from nova import test"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_906384dc","line":18,"in_reply_to":"7aaa499b_df70ffde","updated":"2015-04-14 05:10:12.000000000","message":"liusheng, thanks for your sugestion!","commit_id":"2a8883dae07b5f360d4f462aee0bd3f4771a2f4c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b47a9fdd68c8717b1e6a1add22e035056b7fb778","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        href_v2 \u003d \"http://127.0.0.1:8774/v2/\""},{"line_number":79,"context_line":"        href_v21 \u003d \"http://127.0.0.1:8774/v2.1/\""},{"line_number":80,"context_line":"        if public_endpoint:"},{"line_number":81,"context_line":"            cfg.CONF.set_override(\u0027public_endpoint\u0027, public_endpoint)"},{"line_number":82,"context_line":"            href_v2 \u003d \"http://example.com:8774/v2/\""},{"line_number":83,"context_line":"            href_v21 \u003d \"http://example.com:8774/v2.1/\""},{"line_number":84,"context_line":"        res \u003d versions.Versions().index(req)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_26b6f18a","line":81,"updated":"2015-04-20 12:20:05.000000000","message":"Please use self.flags() to set config variables, so they are correctly unset.","commit_id":"0792e7cfd402cba21b0674a85aeb07228e06ff61"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"41efb745b3791622d661cc2e0d9d705a68a3291a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        href_v2 \u003d \"http://127.0.0.1:8774/v2/\""},{"line_number":79,"context_line":"        href_v21 \u003d \"http://127.0.0.1:8774/v2.1/\""},{"line_number":80,"context_line":"        if public_endpoint:"},{"line_number":81,"context_line":"            cfg.CONF.set_override(\u0027public_endpoint\u0027, public_endpoint)"},{"line_number":82,"context_line":"            href_v2 \u003d \"http://example.com:8774/v2/\""},{"line_number":83,"context_line":"            href_v21 \u003d \"http://example.com:8774/v2.1/\""},{"line_number":84,"context_line":"        res \u003d versions.Versions().index(req)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_02829994","line":81,"in_reply_to":"dac4157f_26b6f18a","updated":"2015-04-21 02:43:19.000000000","message":"agree, thanks for your review and suggestion","commit_id":"0792e7cfd402cba21b0674a85aeb07228e06ff61"}]}