)]}'
{"nova/tests/functional/wsgi/test_flavor_manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8eb4e7b5227d0d8b81b17fa8ccf3571d51626d3f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        super(FlavorManageFullstack, self).setUp()"},{"line_number":74,"context_line":"        self.useFixture(policy_fixture.RealPolicyFixture())"},{"line_number":75,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture())"},{"line_number":76,"context_line":"        self.api \u003d api_fixture.admin_api"},{"line_number":77,"context_line":"        self.user_api \u003d api_fixture.api"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def assertFlavorDbEqual(self, flav, flavdb):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_502007f7","line":76,"updated":"2015-03-12 18:01:09.000000000","message":"nit: I might name this self.admin_api so it\u0027s more clear in the tests, but I see you did it this way so you wouldn\u0027t have to update the existing tests.","commit_id":"74e5287a745bed1fa270829eab2802aa49285571"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"e4a8ed661e916fade9bb951684686447bbf479b3","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                                   check_response_status\u003dFalse)"},{"line_number":213,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_flavor_manage_permissions(self):"},{"line_number":216,"context_line":"        \"\"\"Ensure that regular users can\u0027t create or delete flavors."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_01638742","line":215,"updated":"2015-03-06 20:22:59.000000000","message":"white box functional tests, nice!","commit_id":"74e5287a745bed1fa270829eab2802aa49285571"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8eb4e7b5227d0d8b81b17fa8ccf3571d51626d3f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        # Create the flavor as the admin user"},{"line_number":232,"context_line":"        self.api.api_post(\u0027flavors\u0027, flav1)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        resp \u003d self.user_api.api_delete(\u0027flavors/%s\u0027 % flav1[\u0027flavor\u0027][\u0027id\u0027],"},{"line_number":235,"context_line":"                                        check_response_status\u003dFalse)"},{"line_number":236,"context_line":"        self.assertEqual(403, resp.status)"},{"line_number":237,"context_line":"        # ... and ensure that we didn\u0027t actually delete the flavor,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_70726b12","line":234,"updated":"2015-03-12 18:01:09.000000000","message":"nit: I had to read this a few times to see that the user_api was being used, could have a comment in here saying something like \u0027Ensure the user can\u0027t delete the flavor\u0027.","commit_id":"74e5287a745bed1fa270829eab2802aa49285571"}]}