)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cc90155dafb269948bd60361e12ada694f3095ea","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that the Scheduler has RPC calls to receive updates from compute"},{"line_number":10,"context_line":"whenever a compute node\u0027s instances change significantly, we need to add"},{"line_number":11,"context_line":"calls to compute to send those updates."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint isolate-scheduler-db"},{"line_number":14,"context_line":"(https://blueprints.launchpad.net/nova/+spec/isolate-scheduler-db)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9a80dd14_0e39463f","line":11,"updated":"2015-03-17 22:30:18.000000000","message":"Needs a proper and good DocImpact for the new CONF option added here...","commit_id":"006c6c00f9044e99b4cd2b5cfe97c556fea91580"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8eb6ce44cb5238c777961c8d484e0bbb226c50c7","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partially-Implements: blueprint isolate-scheduler-db"},{"line_number":25,"context_line":"(https://blueprints.launchpad.net/nova/+spec/isolate-scheduler-db)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I5e93ec949e2fa0e29c52beb20201696caad85776"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"9a80dd14_91be0ead","line":26,"updated":"2015-03-18 17:10:54.000000000","message":"Probably should have doc impact here for the new config param.","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"6fc0641ebabf55572ad977c94d171a3b0473d92f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partially-Implements: blueprint isolate-scheduler-db"},{"line_number":25,"context_line":"(https://blueprints.launchpad.net/nova/+spec/isolate-scheduler-db)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I5e93ec949e2fa0e29c52beb20201696caad85776"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"9a80dd14_0c85a506","line":26,"in_reply_to":"9a80dd14_91be0ead","updated":"2015-03-18 17:29:17.000000000","message":"Umm... it\u0027s right above here. :)","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"}],"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0a2f242f946b1f5570846f4b39dcaeb82830bab8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries_interval\u0027,"},{"line_number":173,"context_line":"               default\u003d3,"},{"line_number":174,"context_line":"               help\u003d\u0027Waiting time interval (seconds) between block \u0027"},{"line_number":175,"context_line":"                    \u0027device allocation retries on failures\u0027),"},{"line_number":176,"context_line":"    cfg.IntOpt(\u0027scheduler_instance_sync_interval\u0027,"},{"line_number":177,"context_line":"               default\u003d120,"},{"line_number":178,"context_line":"               help\u003d\u0027Waiting time interval (seconds) between sending the \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a80dd14_6ebba275","line":175,"updated":"2015-03-17 22:21:13.000000000","message":"Why did you change the line above this one? I know you needed to add the comma, but you also moved the space for no reason...","commit_id":"006c6c00f9044e99b4cd2b5cfe97c556fea91580"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cc90155dafb269948bd60361e12ada694f3095ea","unresolved":false,"context_lines":[{"line_number":177,"context_line":"               default\u003d120,"},{"line_number":178,"context_line":"               help\u003d\u0027Waiting time interval (seconds) between sending the \u0027"},{"line_number":179,"context_line":"                    \u0027scheduler a list of current instance UUIDs to verify \u0027"},{"line_number":180,"context_line":"                    \u0027that its view of instances is in sync with nova\u0027),"},{"line_number":181,"context_line":"]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"timeout_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"9a80dd14_8e7b76f3","line":180,"updated":"2015-03-17 22:30:18.000000000","message":"Might be good to note in the help string that this does not mean anything if the scheduler_tracks_instance_changes CONF option is False...","commit_id":"006c6c00f9044e99b4cd2b5cfe97c556fea91580"},{"author":{"_account_id":9282,"name":"hougangliu","email":"liuhoug@cn.ibm.com","username":"HougangLiu"},"change_message_id":"7d49f9606aea06007327369c5f58cc42e4954976","unresolved":false,"context_lines":[{"line_number":2987,"context_line":"                instance.progress \u003d 0"},{"line_number":2988,"context_line":"                instance.save()"},{"line_number":2989,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2990,"context_line":""},{"line_number":2991,"context_line":"            self._notify_about_instance_usage("},{"line_number":2992,"context_line":"                    context, instance, \"rebuild.end\","},{"line_number":2993,"context_line":"                    network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_aa52dd65","line":2990,"updated":"2015-03-18 03:14:36.000000000","message":"self._update_scheduler_instance_info(context, instance) should add before this line.","commit_id":"683d97b46de49472bdf2b853d765a8077c9ddc87"},{"author":{"_account_id":9282,"name":"hougangliu","email":"liuhoug@cn.ibm.com","username":"HougangLiu"},"change_message_id":"acc99d1dd2465467dded3af586a04880223cdcd0","unresolved":false,"context_lines":[{"line_number":2987,"context_line":"                instance.progress \u003d 0"},{"line_number":2988,"context_line":"                instance.save()"},{"line_number":2989,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2990,"context_line":""},{"line_number":2991,"context_line":"            self._notify_about_instance_usage("},{"line_number":2992,"context_line":"                    context, instance, \"rebuild.end\","},{"line_number":2993,"context_line":"                    network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_0ab4b2f0","line":2990,"in_reply_to":"9a80dd14_7a942144","updated":"2015-03-18 14:14:37.000000000","message":"I do not agree with you. I think a new instance comes for the host by rebuild, and the host\u0027s instance info should be updated for scheduler.","commit_id":"683d97b46de49472bdf2b853d765a8077c9ddc87"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"37cb61d7ad12b2dd924a6df7eb3e69512eecd3fb","unresolved":false,"context_lines":[{"line_number":2987,"context_line":"                instance.progress \u003d 0"},{"line_number":2988,"context_line":"                instance.save()"},{"line_number":2989,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2990,"context_line":""},{"line_number":2991,"context_line":"            self._notify_about_instance_usage("},{"line_number":2992,"context_line":"                    context, instance, \"rebuild.end\","},{"line_number":2993,"context_line":"                    network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_7a942144","line":2990,"in_reply_to":"9a80dd14_aa52dd65","updated":"2015-03-18 12:46:15.000000000","message":"It is unnecessary here, since _build_resources() is only called from _build_and_run_instance(), and the update to the scheduler is made there (L# 2325)","commit_id":"683d97b46de49472bdf2b853d765a8077c9ddc87"},{"author":{"_account_id":9282,"name":"hougangliu","email":"liuhoug@cn.ibm.com","username":"HougangLiu"},"change_message_id":"7d49f9606aea06007327369c5f58cc42e4954976","unresolved":false,"context_lines":[{"line_number":4431,"context_line":"            self.image_api.delete(context, image[\u0027id\u0027])"},{"line_number":4432,"context_line":""},{"line_number":4433,"context_line":"        self._unshelve_instance_key_restore(instance, scrubbed_keys)"},{"line_number":4434,"context_line":"        self._update_instance_after_spawn(context, instance)"},{"line_number":4435,"context_line":"        instance.save(expected_task_state\u003dtask_states.SPAWNING)"},{"line_number":4436,"context_line":"        self._notify_about_instance_usage(context, instance, \u0027unshelve.end\u0027)"},{"line_number":4437,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_6ad0e5c9","line":4434,"updated":"2015-03-18 03:14:36.000000000","message":"self._update_scheduler_instance_info(context, instance) should add here.","commit_id":"683d97b46de49472bdf2b853d765a8077c9ddc87"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"37cb61d7ad12b2dd924a6df7eb3e69512eecd3fb","unresolved":false,"context_lines":[{"line_number":4431,"context_line":"            self.image_api.delete(context, image[\u0027id\u0027])"},{"line_number":4432,"context_line":""},{"line_number":4433,"context_line":"        self._unshelve_instance_key_restore(instance, scrubbed_keys)"},{"line_number":4434,"context_line":"        self._update_instance_after_spawn(context, instance)"},{"line_number":4435,"context_line":"        instance.save(expected_task_state\u003dtask_states.SPAWNING)"},{"line_number":4436,"context_line":"        self._notify_about_instance_usage(context, instance, \u0027unshelve.end\u0027)"},{"line_number":4437,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_bada1915","line":4434,"in_reply_to":"9a80dd14_6ad0e5c9","updated":"2015-03-18 12:46:15.000000000","message":"Agree - good catch.","commit_id":"683d97b46de49472bdf2b853d765a8077c9ddc87"},{"author":{"_account_id":9282,"name":"hougangliu","email":"liuhoug@cn.ibm.com","username":"HougangLiu"},"change_message_id":"217728706ad269072a15b48c2e312e18e15992b7","unresolved":false,"context_lines":[{"line_number":2987,"context_line":"                instance.progress \u003d 0"},{"line_number":2988,"context_line":"                instance.save()"},{"line_number":2989,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2990,"context_line":""},{"line_number":2991,"context_line":"            self._notify_about_instance_usage("},{"line_number":2992,"context_line":"                    context, instance, \"rebuild.end\","},{"line_number":2993,"context_line":"                    network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a80dd14_eadf5e0a","line":2990,"updated":"2015-03-18 14:17:49.000000000","message":"I still persist self._update_scheduler_instance_info(context, instance) should be added here since the host\u0027s instances info has changed.","commit_id":"b1ab3bb3b2d76c2c73c0b9b3dd1e05924cfd5fa0"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"db6cf17e9a3dd45622097bbf7e2cab044b0b7f18","unresolved":false,"context_lines":[{"line_number":2987,"context_line":"                instance.progress \u003d 0"},{"line_number":2988,"context_line":"                instance.save()"},{"line_number":2989,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2990,"context_line":""},{"line_number":2991,"context_line":"            self._notify_about_instance_usage("},{"line_number":2992,"context_line":"                    context, instance, \"rebuild.end\","},{"line_number":2993,"context_line":"                    network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a80dd14_4dc3248a","line":2990,"in_reply_to":"9a80dd14_eadf5e0a","updated":"2015-03-18 14:31:41.000000000","message":"OK, I was looking at another method. It would be good to add the update call here, too.","commit_id":"b1ab3bb3b2d76c2c73c0b9b3dd1e05924cfd5fa0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f46fb4233a9d4d71a152c0ba955addbb5c532ace","unresolved":false,"context_lines":[{"line_number":1982,"context_line":"        instance.save(expected_task_state\u003dtask_states.SPAWNING)"},{"line_number":1983,"context_line":"        return instance"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"    def _update_scheduler_instance_info(self, context, instance):"},{"line_number":1986,"context_line":"        \"\"\"Sends an InstanceList with created or updated Instance objects to"},{"line_number":1987,"context_line":"        the Scheduler client."},{"line_number":1988,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_2d0fd089","line":1985,"updated":"2015-03-18 14:42:02.000000000","message":"can you please add unit tests for these methods?","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"65772c66321d6a57d3d334b21636c885aa9e13a5","unresolved":false,"context_lines":[{"line_number":1982,"context_line":"        instance.save(expected_task_state\u003dtask_states.SPAWNING)"},{"line_number":1983,"context_line":"        return instance"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"    def _update_scheduler_instance_info(self, context, instance):"},{"line_number":1986,"context_line":"        \"\"\"Sends an InstanceList with created or updated Instance objects to"},{"line_number":1987,"context_line":"        the Scheduler client."},{"line_number":1988,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_fe063c84","line":1985,"in_reply_to":"9a80dd14_2d0fd089","updated":"2015-03-18 15:30:06.000000000","message":"OK, I\u0027ll add tests and re-spin.","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f46fb4233a9d4d71a152c0ba955addbb5c532ace","unresolved":false,"context_lines":[{"line_number":1999,"context_line":"        self.scheduler_client.update_instance_info(context, self.host,"},{"line_number":2000,"context_line":"                                                   instance)"},{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"    def _delete_scheduler_instance_info(self, context, instance_uuid):"},{"line_number":2003,"context_line":"        \"\"\"Sends the uuid of the deleted Instance to the Scheduler client.\"\"\""},{"line_number":2004,"context_line":"        if not self.send_instance_updates:"},{"line_number":2005,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_6d20e8f8","line":2002,"updated":"2015-03-18 14:42:02.000000000","message":"ditto","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8eb6ce44cb5238c777961c8d484e0bbb226c50c7","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"        self.scheduler_client.delete_instance_info(context, self.host,"},{"line_number":2008,"context_line":"                                                   instance_uuid)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    @periodic_task.periodic_task(spacing\u003dCONF.scheduler_instance_sync_interval)"},{"line_number":2011,"context_line":"    def _sync_scheduler_instance_info(self, context):"},{"line_number":2012,"context_line":"        if not self.send_instance_updates:"},{"line_number":2013,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_31f7228e","line":2010,"updated":"2015-03-18 17:10:54.000000000","message":"Are we sure this actually works? I remember someone trying to fix these sorts of config, I don\u0027t remember the outcome.","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"6fc0641ebabf55572ad977c94d171a3b0473d92f","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"        self.scheduler_client.delete_instance_info(context, self.host,"},{"line_number":2008,"context_line":"                                                   instance_uuid)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    @periodic_task.periodic_task(spacing\u003dCONF.scheduler_instance_sync_interval)"},{"line_number":2011,"context_line":"    def _sync_scheduler_instance_info(self, context):"},{"line_number":2012,"context_line":"        if not self.send_instance_updates:"},{"line_number":2013,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_cc146da1","line":2010,"in_reply_to":"9a80dd14_31f7228e","updated":"2015-03-18 17:29:17.000000000","message":"It\u0027s working on my devstack. I\u0027m not aware of any other issues with periodic_task","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"6fc0641ebabf55572ad977c94d171a3b0473d92f","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"        self.scheduler_client.delete_instance_info(context, self.host,"},{"line_number":2008,"context_line":"                                                   instance_uuid)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    @periodic_task.periodic_task(spacing\u003dCONF.scheduler_instance_sync_interval)"},{"line_number":2011,"context_line":"    def _sync_scheduler_instance_info(self, context):"},{"line_number":2012,"context_line":"        if not self.send_instance_updates:"},{"line_number":2013,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_ec0bf17a","line":2010,"in_reply_to":"9a80dd14_31f7228e","updated":"2015-03-18 17:29:17.000000000","message":"It\u0027s working on my devstack. I\u0027m not aware of any other issues with periodic_task","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f46fb4233a9d4d71a152c0ba955addbb5c532ace","unresolved":false,"context_lines":[{"line_number":2008,"context_line":"                                                   instance_uuid)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    @periodic_task.periodic_task(spacing\u003dCONF.scheduler_instance_sync_interval)"},{"line_number":2011,"context_line":"    def _sync_scheduler_instance_info(self, context):"},{"line_number":2012,"context_line":"        if not self.send_instance_updates:"},{"line_number":2013,"context_line":"            return"},{"line_number":2014,"context_line":"        context \u003d context.elevated()"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_8d1fdcb6","line":2011,"updated":"2015-03-18 14:42:02.000000000","message":"ditto","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f46fb4233a9d4d71a152c0ba955addbb5c532ace","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"                                                  reservations,"},{"line_number":4056,"context_line":"                                                  instance\u003dinstance)"},{"line_number":4057,"context_line":"        try:"},{"line_number":4058,"context_line":"            self._finish_resize(context, instance, migration,"},{"line_number":4059,"context_line":"                                disk_info, image)"},{"line_number":4060,"context_line":"            quotas.commit()"},{"line_number":4061,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_0d5a0c83","line":4058,"updated":"2015-03-18 14:42:02.000000000","message":"any reason why the scheduler is not notified here? maybe I am missing something","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"65772c66321d6a57d3d334b21636c885aa9e13a5","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"                                                  reservations,"},{"line_number":4056,"context_line":"                                                  instance\u003dinstance)"},{"line_number":4057,"context_line":"        try:"},{"line_number":4058,"context_line":"            self._finish_resize(context, instance, migration,"},{"line_number":4059,"context_line":"                                disk_info, image)"},{"line_number":4060,"context_line":"            quotas.commit()"},{"line_number":4061,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a80dd14_7ee16cfb","line":4058,"in_reply_to":"9a80dd14_0d5a0c83","updated":"2015-03-18 15:30:06.000000000","message":"The call to update is in _finish_resize() L#4036","commit_id":"dcb70d3064d641e69f10f6d5369aeb437e4fa442"},{"author":{"_account_id":1981,"name":"Don Dugger","email":"n0ano@n0ano.com","username":"n0ano"},"change_message_id":"e52bab3f1efe1ef348a6c0147c248dda205365f5","unresolved":false,"context_lines":[{"line_number":5249,"context_line":""},{"line_number":5250,"context_line":"        network_info \u003d self._get_instance_nw_info(ctxt, instance)"},{"line_number":5251,"context_line":""},{"line_number":5252,"context_line":"        self._update_scheduler_instance_info(ctxt, instance)"},{"line_number":5253,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":5254,"context_line":"                                          \"live_migration._post.start\","},{"line_number":5255,"context_line":"                                          network_info\u003dnetwork_info)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_6b451e42","line":5252,"updated":"2015-03-18 20:52:01.000000000","message":"Note this is the only time you update the scheduler before a `notify_about_instance_usage\u0027 on a `.start\u0027 event, all other time you do this before the `.end\u0027 event.  Should this call be made about 30 lines down just before the `live_migration._post.end\u0027 event?","commit_id":"159e8a73f8cf2394d2fea8416b78088fea7f3a1e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b97636898d676a70495f98ae460d1bcf8a99a8c0","unresolved":false,"context_lines":[{"line_number":5249,"context_line":""},{"line_number":5250,"context_line":"        network_info \u003d self._get_instance_nw_info(ctxt, instance)"},{"line_number":5251,"context_line":""},{"line_number":5252,"context_line":"        self._update_scheduler_instance_info(ctxt, instance)"},{"line_number":5253,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":5254,"context_line":"                                          \"live_migration._post.start\","},{"line_number":5255,"context_line":"                                          network_info\u003dnetwork_info)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_d705cc10","line":5252,"in_reply_to":"9a80dd14_6b451e42","updated":"2015-03-18 21:04:40.000000000","message":"Done","commit_id":"159e8a73f8cf2394d2fea8416b78088fea7f3a1e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"17dae19322acc0251848da72cee04306c7ebc08e","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        if not self.send_instance_updates:"},{"line_number":2013,"context_line":"            return"},{"line_number":2014,"context_line":"        context \u003d context.elevated()"},{"line_number":2015,"context_line":"        instances \u003d objects.InstanceList.get_by_host(context, self.host)"},{"line_number":2016,"context_line":"        uuids \u003d [instance.uuid for instance in instances]"},{"line_number":2017,"context_line":"        self.scheduler_client.sync_instance_info(context, self.host, uuids)"},{"line_number":2018,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_b5ad9933","line":2015,"updated":"2015-03-19 10:49:38.000000000","message":"Most periodic tasks do this:\n\ndb_instances \u003d objects.InstanceList.get_by_host(\n                context, self.host, expected_attrs\u003d[], use_slave\u003dTrue)\n\nBut maybe lets just raise a bug and fix that in a follow on patch. Not sure what stuff you need merging in for the sync, you might need the flavor in system_metadata I guess, but we could add use_slave I think.","commit_id":"b798f7c711c25fa0dba0e03b93080f3f3eb5448b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ac687478b7aca0a29740bb332e28fa9876640d26","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"        if not self.send_instance_updates:"},{"line_number":2013,"context_line":"            return"},{"line_number":2014,"context_line":"        context \u003d context.elevated()"},{"line_number":2015,"context_line":"        instances \u003d objects.InstanceList.get_by_host(context, self.host)"},{"line_number":2016,"context_line":"        uuids \u003d [instance.uuid for instance in instances]"},{"line_number":2017,"context_line":"        self.scheduler_client.sync_instance_info(context, self.host, uuids)"},{"line_number":2018,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_9525f5c3","line":2015,"in_reply_to":"9a80dd14_b5ad9933","updated":"2015-03-19 10:51:58.000000000","message":"Actually I just see you only use the uuids, I am going blind, I suspect thats worth optimising as above, but not sure we should block the change on a performance optimisation.","commit_id":"b798f7c711c25fa0dba0e03b93080f3f3eb5448b"}],"nova/scheduler/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96ccb25197888aac3ca790912811b135d0e4575e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"class SchedulerManager(manager.Manager):"},{"line_number":56,"context_line":"    \"\"\"Chooses a host to run instances on.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    target \u003d messaging.Target(version\u003d\u00274.2\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def __init__(self, scheduler_driver\u003dNone, *args, **kwargs):"},{"line_number":61,"context_line":"        if not scheduler_driver:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_ceb64ef9","line":58,"updated":"2015-03-17 22:05:02.000000000","message":"This should go with the RPC change.","commit_id":"508ce691d0ac98ac64a902965acaae02da570be4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4ad5d1f0fff08961563e6d336e3261b861ae1abd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"class SchedulerManager(manager.Manager):"},{"line_number":56,"context_line":"    \"\"\"Chooses a host to run instances on.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    target \u003d messaging.Target(version\u003d\u00274.2\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def __init__(self, scheduler_driver\u003dNone, *args, **kwargs):"},{"line_number":61,"context_line":"        if not scheduler_driver:"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_4c8fc675","line":58,"updated":"2015-03-17 22:51:37.000000000","message":"Reverted this too :(","commit_id":"e426a6048cca914d32b375a0b6c6877e26130a4f"}]}