)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"65917e59fc4ab83b48b7fae9a18fe71f07446c04","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt test_cpu_info method fixed random PYTHONHASHSEED compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"changed collection for features from list to set to guaranitee"},{"line_number":10,"context_line":"object equality"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1348818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_296896b9","line":9,"updated":"2015-03-12 16:17:21.000000000","message":"typo: guarantee","commit_id":"9abdaa055556dd5d6172b62466b6eeb508049c52"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"ec0baffda9dcd05e83666cb5052639168c90b7ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt test_cpu_info method fixed random PYTHONHASHSEED compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"changed collection for features from list to set to guaranitee"},{"line_number":10,"context_line":"object equality"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1348818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_7c2a4a91","line":9,"in_reply_to":"9a80dd14_296896b9","updated":"2015-03-12 16:40:51.000000000","message":"Done","commit_id":"9abdaa055556dd5d6172b62466b6eeb508049c52"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"70209db590e027187da41a2dc18ab8eb732b3af3","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        # NOTE(tdurakov): serialization cpu_info before writing to db,"},{"line_number":464,"context_line":"        # moved from driver._get_cpu_info"},{"line_number":465,"context_line":"        if \u0027cpu_info\u0027 in values:"},{"line_number":466,"context_line":"            values[\u0027cpu_info\u0027] \u003d jsonutils.dumps(values[\u0027cpu_info\u0027])"},{"line_number":467,"context_line":"        self.compute_node \u003d self.conductor_api.compute_node_create(context,"},{"line_number":468,"context_line":"                                                                   values)"},{"line_number":469,"context_line":"        # NOTE(sbauza): We don\u0027t want to miss the first creation event"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_76bab50b","line":466,"updated":"2015-03-11 10:44:16.000000000","message":"is libvirt the only driver that does this?\nthis needs to be addressed in the commit message.\nit is not clear why we need this change here","commit_id":"a6c7fda640233f9c37ade8419a9c03d67ab8a822"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"8e0fa049fa7ab3b3d2e38053732232ce2121ace9","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        # NOTE(tdurakov): serialization cpu_info before writing to db,"},{"line_number":464,"context_line":"        # moved from driver._get_cpu_info"},{"line_number":465,"context_line":"        if \u0027cpu_info\u0027 in values:"},{"line_number":466,"context_line":"            values[\u0027cpu_info\u0027] \u003d jsonutils.dumps(values[\u0027cpu_info\u0027])"},{"line_number":467,"context_line":"        self.compute_node \u003d self.conductor_api.compute_node_create(context,"},{"line_number":468,"context_line":"                                                                   values)"},{"line_number":469,"context_line":"        # NOTE(sbauza): We don\u0027t want to miss the first creation event"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_d11feb59","line":466,"in_reply_to":"9a80dd14_769b9572","updated":"2015-03-11 11:22:24.000000000","message":"search more, libvirt wasn\u0027t the one, new patch set will move this to LibvirtDriver.get_available_resource","commit_id":"a6c7fda640233f9c37ade8419a9c03d67ab8a822"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"b576d2754011c96de7a949f259b1cf3506df5cbd","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        # NOTE(tdurakov): serialization cpu_info before writing to db,"},{"line_number":464,"context_line":"        # moved from driver._get_cpu_info"},{"line_number":465,"context_line":"        if \u0027cpu_info\u0027 in values:"},{"line_number":466,"context_line":"            values[\u0027cpu_info\u0027] \u003d jsonutils.dumps(values[\u0027cpu_info\u0027])"},{"line_number":467,"context_line":"        self.compute_node \u003d self.conductor_api.compute_node_create(context,"},{"line_number":468,"context_line":"                                                                   values)"},{"line_number":469,"context_line":"        # NOTE(sbauza): We don\u0027t want to miss the first creation event"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_769b9572","line":466,"in_reply_to":"9a80dd14_76bab50b","updated":"2015-03-11 10:48:55.000000000","message":"libvirt was the only one that dumps cpu_info into json string in _get_cpu_info method","commit_id":"a6c7fda640233f9c37ade8419a9c03d67ab8a822"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1db51fd9fb66872c0f7fcb037c3e25a5f8dd7d6b","unresolved":false,"context_lines":[{"line_number":9170,"context_line":"                \"arch\": arch.X86_64,"},{"line_number":9171,"context_line":"                \"topology\": {\"cores\": 2, \"threads\": 1, \"sockets\": 4}}"},{"line_number":9172,"context_line":"        got \u003d jsonutils.loads(drvr._get_cpu_info())"},{"line_number":9173,"context_line":"        got[\u0027features\u0027] \u003d sorted(got[\u0027features\u0027])"},{"line_number":9174,"context_line":"        self.assertEqual(want, got)"},{"line_number":9175,"context_line":""},{"line_number":9176,"context_line":"    def test_get_pcidev_info(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_6c02ca0c","line":9173,"updated":"2015-03-05 13:43:36.000000000","message":"appologize if we\u0027ve been through this before, but it\u0027s really weird that we just address this by doing sorts here. It seems like if order doesn\u0027t matter features should be a set and not a list in the functional code.","commit_id":"83340a37c4925cdf1fd652e2cdd756b4d25f3fcf"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"fe12af4aa998cfb084463b98bc5c530dce7ce430","unresolved":false,"context_lines":[{"line_number":9170,"context_line":"                \"arch\": arch.X86_64,"},{"line_number":9171,"context_line":"                \"topology\": {\"cores\": 2, \"threads\": 1, \"sockets\": 4}}"},{"line_number":9172,"context_line":"        got \u003d jsonutils.loads(drvr._get_cpu_info())"},{"line_number":9173,"context_line":"        got[\u0027features\u0027] \u003d sorted(got[\u0027features\u0027])"},{"line_number":9174,"context_line":"        self.assertEqual(want, got)"},{"line_number":9175,"context_line":""},{"line_number":9176,"context_line":"    def test_get_pcidev_info(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1bdc4274","line":9173,"in_reply_to":"9a80dd14_6c02ca0c","updated":"2015-03-11 10:31:28.000000000","message":"Sean, thanks for comment. Changed features container to set as i did in first patch set. Also move cpu_info serialization from _get_cpu_info to resorce tracker, as it closer to db inser/update.","commit_id":"83340a37c4925cdf1fd652e2cdd756b4d25f3fcf"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ed27ef569aa391aab6fdc483fd5a4439dcece9d5","unresolved":false,"context_lines":[{"line_number":4623,"context_line":"        # That said, arch_filter.py now seems to rely on"},{"line_number":4624,"context_line":"        # the libvirt drivers format which suggests this"},{"line_number":4625,"context_line":"        # data format needs to be standardized across drivers"},{"line_number":4626,"context_line":"        return jsonutils.dumps(cpu_info)"},{"line_number":4627,"context_line":""},{"line_number":4628,"context_line":"    def _get_pcidev_info(self, devname):"},{"line_number":4629,"context_line":"        \"\"\"Returns a dict of PCI device.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a53f27b3","side":"PARENT","line":4626,"updated":"2015-03-03 09:47:09.000000000","message":"it is not clear why you are changing this and it looks like this breaks the gate","commit_id":"c1a8578c4b3f85a92d7bd6ae7f584a595b3e7d3f"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d5ec1a7f5cc395a80a4090bafa9ad1c1ef94218a","unresolved":false,"context_lines":[{"line_number":4623,"context_line":"        # That said, arch_filter.py now seems to rely on"},{"line_number":4624,"context_line":"        # the libvirt drivers format which suggests this"},{"line_number":4625,"context_line":"        # data format needs to be standardized across drivers"},{"line_number":4626,"context_line":"        return jsonutils.dumps(cpu_info)"},{"line_number":4627,"context_line":""},{"line_number":4628,"context_line":"    def _get_pcidev_info(self, devname):"},{"line_number":4629,"context_line":"        \"\"\"Returns a dict of PCI device.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_cada5877","side":"PARENT","line":4626,"in_reply_to":"ba7be1f8_a53f27b3","updated":"2015-03-03 15:26:35.000000000","message":"Thanks, for your comment! I supposed that dumps is ambiguous. As you can see, all unit tests passed successfully. I\u0027ll check logs for details.","commit_id":"c1a8578c4b3f85a92d7bd6ae7f584a595b3e7d3f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eac43847e2c3c067e4aeec99692d0910d3248d97","unresolved":false,"context_lines":[{"line_number":4620,"context_line":"        #"},{"line_number":4621,"context_line":"        # That said, arch_filter.py now seems to rely on"},{"line_number":4622,"context_line":"        # the libvirt drivers format which suggests this"},{"line_number":4623,"context_line":"        # data format needs to be standardized across drivers"},{"line_number":4624,"context_line":"        return cpu_info"},{"line_number":4625,"context_line":""},{"line_number":4626,"context_line":"    def _get_pcidev_info(self, devname):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_f2266867","line":4623,"updated":"2015-03-12 15:43:52.000000000","message":"Please move the above comment to directly above line 4868 below.","commit_id":"6f6cbb82179398bb772bc258859dc3ecbd42376a"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6c9c8b5be03066f4789c3b94a24eba9d0cb22f0a","unresolved":false,"context_lines":[{"line_number":4620,"context_line":"        #"},{"line_number":4621,"context_line":"        # That said, arch_filter.py now seems to rely on"},{"line_number":4622,"context_line":"        # the libvirt drivers format which suggests this"},{"line_number":4623,"context_line":"        # data format needs to be standardized across drivers"},{"line_number":4624,"context_line":"        return cpu_info"},{"line_number":4625,"context_line":""},{"line_number":4626,"context_line":"    def _get_pcidev_info(self, devname):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_c629a98a","line":4623,"in_reply_to":"9a80dd14_f2266867","updated":"2015-03-12 15:53:26.000000000","message":"Done","commit_id":"6f6cbb82179398bb772bc258859dc3ecbd42376a"}]}