)]}'
{"nova/api/openstack/compute/contrib/security_groups.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"62b7ecde63917739d6d7ece7c8fcb5c85bcd9980","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":69,"context_line":"    except exception.SecurityGroupExistsForInstance as exp:"},{"line_number":70,"context_line":"        msg \u003d exp.format_message()"},{"line_number":71,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class SecurityGroupControllerBase(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_eab3ae4a","line":71,"updated":"2015-03-03 09:30:02.000000000","message":"why is this raising a BadRequest. Should this not be HTTPConflict?","commit_id":"f16afc44af7129c75c503a145bd67dca386d8178"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"86576a00992115fb725037c082fa4615dff43c03","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    except exception.NoUniqueMatch as exp:"},{"line_number":67,"context_line":"        msg \u003d exp.format_message()"},{"line_number":68,"context_line":"        raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":69,"context_line":"    except exception.SecurityGroupExistsForInstance as exp:"},{"line_number":70,"context_line":"        msg \u003d exp.format_message()"},{"line_number":71,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_5a7b8fbd","line":69,"updated":"2015-03-03 17:29:53.000000000","message":"and this won\u0027t work because \nline #54 catches Invalid exception\n\nSecurityGroupExistsForInstance inherits from Invalid\n\nso should we explictly catch it?","commit_id":"f8f1496c5668bd0040b6c01c03d53fc557f2f52b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3e9861b29efca94261562c015982ff5529d668b2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    except exception.NoUniqueMatch as exp:"},{"line_number":67,"context_line":"        msg \u003d exp.format_message()"},{"line_number":68,"context_line":"        raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":69,"context_line":"    except exception.SecurityGroupExistsForInstance as exp:"},{"line_number":70,"context_line":"        msg \u003d exp.format_message()"},{"line_number":71,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_5acd6130","line":69,"updated":"2015-03-03 12:22:10.000000000","message":"why is this not exc.HTTPConflict?","commit_id":"f8f1496c5668bd0040b6c01c03d53fc557f2f52b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"616ea3fb1967652c3a26c57a4f087bc6c8735414","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    except exception.NoUniqueMatch as exp:"},{"line_number":67,"context_line":"        msg \u003d exp.format_message()"},{"line_number":68,"context_line":"        raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":69,"context_line":"    except exception.SecurityGroupExistsForInstance as exp:"},{"line_number":70,"context_line":"        msg \u003d exp.format_message()"},{"line_number":71,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ea89c06f","line":69,"in_reply_to":"ba7be1f8_5a7b8fbd","updated":"2015-03-04 01:21:04.000000000","message":"Right, thanks, Removed.","commit_id":"f8f1496c5668bd0040b6c01c03d53fc557f2f52b"}]}