)]}'
{"nova/compute/api.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"dd8160d7941441b86e7dc36d8187ac41806c47e0","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                \u0027access_ip_v6\u0027: access_ip_v6,"},{"line_number":506,"context_line":"                \u0027availability_zone\u0027: availability_zone,"},{"line_number":507,"context_line":"                \u0027root_device_name\u0027: root_device_name,"},{"line_number":508,"context_line":"                \u0027architecture\u0027: architecture,"},{"line_number":509,"context_line":"                \u0027progress\u0027: 0}"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"            if user_data:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F%2FFU%3D","side":"PARENT","line":508,"updated":"2012-12-03 19:32:35.000000000","message":"Not sure why you removed this? shouldn\u0027t we be setting this to \u0027Unknown\u0027 if we couldn\u0027t get it from  glance instead of not passing it?","commit_id":"ac7737dc8b5122ff83beff2ae00eef7365fa032d"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e00b11bca0f116fa5b28226973356896155d2988","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                \u0027access_ip_v6\u0027: access_ip_v6,"},{"line_number":506,"context_line":"                \u0027availability_zone\u0027: availability_zone,"},{"line_number":507,"context_line":"                \u0027root_device_name\u0027: root_device_name,"},{"line_number":508,"context_line":"                \u0027architecture\u0027: architecture,"},{"line_number":509,"context_line":"                \u0027progress\u0027: 0}"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"            if user_data:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F948%3D","side":"PARENT","line":508,"in_reply_to":"AAAAMX%2F%2F%2FFU%3D","updated":"2012-12-04 16:16:39.000000000","message":"Vish, it is currently populated in _inherit_properties_from_image (see bellow), and will be set to None if not present, so anything set on this line will be overwritten anyway.\n\nDo you think setting it to \u0027Unknown\u0027 makes sense or is None good enough (I checked and value \u0027Unknown\u0027 is not expected anywhere else in the code)?\n\nAlso take a look at  https://review.openstack.org/16632 and the discussion there.","commit_id":"ac7737dc8b5122ff83beff2ae00eef7365fa032d"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e00b11bca0f116fa5b28226973356896155d2988","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                    base64.decodestring(user_data)"},{"line_number":521,"context_line":"                except base64.binascii.Error:"},{"line_number":522,"context_line":"                    raise exception.InstanceUserDataMalformed()"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"            options_from_image \u003d self._inherit_properties_from_image("},{"line_number":525,"context_line":"                    image, auto_disk_config)"},{"line_number":526,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F94k%3D","side":"PARENT","line":523,"updated":"2012-12-04 16:16:39.000000000","message":"This call will overwrite anything that was set above","commit_id":"ac7737dc8b5122ff83beff2ae00eef7365fa032d"}]}