)]}'
{"nova/tests/test_imagecache.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5859c0e1bcffd62725ad5a6654f04c7a30a2441e","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            self.assertEquals(image_cache_manager.corrupt_base_files, [])"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def test_handle_base_image_absent(self):"},{"line_number":644,"context_line":"        \"\"\"Ensure we warn for use of a missing base image.\"\"\""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        img \u003d \u0027123\u0027"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F2mU%3D","side":"PARENT","line":644,"updated":"2012-11-20 00:09:09.000000000","message":"Did you mean to nuke this docstring?","commit_id":"f093d030f072b29e0dd137454a3c1cd7d8cf1b55"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"531f7ab169f2a9225946f15a8e7ce94b0391873c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            self.assertEquals(image_cache_manager.corrupt_base_files, [])"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def test_handle_base_image_absent(self):"},{"line_number":644,"context_line":"        \"\"\"Ensure we warn for use of a missing base image.\"\"\""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        img \u003d \u0027123\u0027"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F1Z0%3D","side":"PARENT","line":644,"in_reply_to":"AAAAMH%2F%2F2mU%3D","updated":"2012-11-20 20:34:31.000000000","message":"Yes, doc strings in unit tests suck because they cause the name of the failing test to be hidden.","commit_id":"f093d030f072b29e0dd137454a3c1cd7d8cf1b55"}],"nova/virt/driver.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1a0214a83567dda0acf2223c6325b0d4881419ce","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    types that support that contract"},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import socket"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova import flags"},{"line_number":28,"context_line":"from nova.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5mA%3D","line":25,"updated":"2012-11-16 15:18:37.000000000","message":"unused import","commit_id":"6708a671869d1fe2f772ea3b297dba87f35c7b25"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1a0214a83567dda0acf2223c6325b0d4881419ce","unresolved":false,"context_lines":[{"line_number":3017,"context_line":"class HostState(object):"},{"line_number":3018,"context_line":"    \"\"\"Manages information about the compute node through libvirt\"\"\""},{"line_number":3019,"context_line":"    def __init__(self, virtapi, read_only):"},{"line_number":3020,"context_line":"        super(HostState, self).__init__()"},{"line_number":3021,"context_line":"        self.read_only \u003d read_only"},{"line_number":3022,"context_line":"        self._stats \u003d {}"},{"line_number":3023,"context_line":"        self.connection \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5lw%3D","side":"PARENT","line":3020,"updated":"2012-11-16 15:18:37.000000000","message":"looks unrelated?","commit_id":"90dffc3a9c69aa5ffab23d2a28a8f669ef18be97"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1a0214a83567dda0acf2223c6325b0d4881419ce","unresolved":false,"context_lines":[{"line_number":70,"context_line":"from nova.openstack.common import importutils"},{"line_number":71,"context_line":"from nova.openstack.common import jsonutils"},{"line_number":72,"context_line":"from nova.openstack.common import log as logging"},{"line_number":73,"context_line":"from nova.openstack.common import uuidutils"},{"line_number":74,"context_line":"from nova import utils"},{"line_number":75,"context_line":"from nova.virt import configdrive"},{"line_number":76,"context_line":"from nova.virt.disk import api as disk"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5l8%3D","line":73,"updated":"2012-11-16 15:18:37.000000000","message":"unused import","commit_id":"6708a671869d1fe2f772ea3b297dba87f35c7b25"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1a0214a83567dda0acf2223c6325b0d4881419ce","unresolved":false,"context_lines":[{"line_number":3053,"context_line":"        data[\"supported_instances\"] \u003d \\"},{"line_number":3054,"context_line":"            self.connection.get_instance_capabilities()"},{"line_number":3055,"context_line":""},{"line_number":3056,"context_line":"        self._stats.update(data)"},{"line_number":3057,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5ls%3D","line":3056,"updated":"2012-11-16 15:18:37.000000000","message":"looks unrelated?","commit_id":"6708a671869d1fe2f772ea3b297dba87f35c7b25"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5859c0e1bcffd62725ad5a6654f04c7a30a2441e","unresolved":false,"context_lines":[{"line_number":3054,"context_line":"            self.connection.get_instance_capabilities()"},{"line_number":3055,"context_line":""},{"line_number":3056,"context_line":"        self._stats \u003d data"},{"line_number":3057,"context_line":""},{"line_number":3058,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F2mA%3D","side":"PARENT","line":3057,"updated":"2012-11-20 00:09:09.000000000","message":"Did you mean to make this random whitespace change?","commit_id":"f093d030f072b29e0dd137454a3c1cd7d8cf1b55"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"531f7ab169f2a9225946f15a8e7ce94b0391873c","unresolved":false,"context_lines":[{"line_number":3054,"context_line":"            self.connection.get_instance_capabilities()"},{"line_number":3055,"context_line":""},{"line_number":3056,"context_line":"        self._stats \u003d data"},{"line_number":3057,"context_line":""},{"line_number":3058,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F1Zo%3D","side":"PARENT","line":3057,"in_reply_to":"AAAAMH%2F%2F2mA%3D","updated":"2012-11-20 20:34:31.000000000","message":"The patch originally changed the line above, and the whitespace was included there. The change doesn\u0027t really harm anything, so I\u0027d rather not do another revision if I can avoid it.","commit_id":"f093d030f072b29e0dd137454a3c1cd7d8cf1b55"}],"nova/virt/libvirt/imagecache.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"36312b8e1d5d16877fa8813b7e3e0a88a41fca84","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                self.instance_names.add(instance[\u0027name\u0027] + \u0027_resize\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            image_ref_str \u003d str(instance[\u0027image_ref\u0027])"},{"line_number":148,"context_line":"            local, remote, insts, \u003d self.used_images.get(image_ref_str,"},{"line_number":149,"context_line":"                                                         (0, 0, []))"},{"line_number":150,"context_line":"            if instance[\u0027host\u0027] \u003d\u003d CONF.host:"},{"line_number":151,"context_line":"                local +\u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F6t8%3D","line":148,"updated":"2012-11-15 21:30:04.000000000","message":"?","commit_id":"408ef7be0b23255d36f679360e43efafc3bbac99"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"62c9331be915be20ec3b3d9a666880359f81ef4b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                self.instance_names.add(instance[\u0027name\u0027] + \u0027_resize\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            image_ref_str \u003d str(instance[\u0027image_ref\u0027])"},{"line_number":148,"context_line":"            local, remote, insts, \u003d self.used_images.get(image_ref_str,"},{"line_number":149,"context_line":"                                                         (0, 0, []))"},{"line_number":150,"context_line":"            if instance[\u0027host\u0027] \u003d\u003d CONF.host:"},{"line_number":151,"context_line":"                local +\u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2F6nI%3D","line":148,"in_reply_to":"AAAAMH%2F%2F6t8%3D","updated":"2012-11-15 22:39:35.000000000","message":"Done","commit_id":"408ef7be0b23255d36f679360e43efafc3bbac99"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5859c0e1bcffd62725ad5a6654f04c7a30a2441e","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027base_file\u0027: base_file,"},{"line_number":327,"context_line":"                          \u0027local\u0027: local,"},{"line_number":328,"context_line":"                          \u0027remote\u0027: remote})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"                self.active_base_files.append(base_file)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"                if not base_file:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F2l0%3D","line":329,"updated":"2012-11-20 00:09:09.000000000","message":"Did you mean to move this block below the image_in_use \u003d True statement? It doesn\u0027t seem to change the functionality, and makes it harder to tell what changed.","commit_id":"652f703ea75c8ebea6c5523946b848135b451f45"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"531f7ab169f2a9225946f15a8e7ce94b0391873c","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                          \u0027base_file\u0027: base_file,"},{"line_number":327,"context_line":"                          \u0027local\u0027: local,"},{"line_number":328,"context_line":"                          \u0027remote\u0027: remote})"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"                self.active_base_files.append(base_file)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"                if not base_file:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMH%2F%2F1Zg%3D","line":329,"in_reply_to":"AAAAMH%2F%2F2l0%3D","updated":"2012-11-20 20:34:31.000000000","message":"Yah, I figured the code read better that way.","commit_id":"652f703ea75c8ebea6c5523946b848135b451f45"}],"nova/virt/powervm/driver.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1a0214a83567dda0acf2223c6325b0d4881419ce","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":"        return False"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def manage_image_cache(self, context, all_instances):"},{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":"        Manage the driver\u0027s local image cache."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F5lg%3D","side":"PARENT","line":159,"updated":"2012-11-16 15:18:37.000000000","message":"unrelated change, and not necessary ...\n\nPerhaps the author of this driver likes having all the interfaces specified here, even if not being used?","commit_id":"90dffc3a9c69aa5ffab23d2a28a8f669ef18be97"}]}