)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"3bff77217a092182bfcd4579fb2eee52be556a63","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return facade.get_session(use_slave\u003duse_slave, **kwargs)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def get_api_session():"},{"line_number":147,"context_line":"    connection_str \u003d CONF.api_database.connection"},{"line_number":148,"context_line":"    facade \u003d _create_facade_lazily(_API_FACADE, connection_str)"},{"line_number":149,"context_line":"    return facade.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_682a5191","line":146,"updated":"2015-03-08 07:30:40.000000000","message":"This should atleast accept **kwargs like get_session","commit_id":"fa84dc48e86125970b506050ae2dc66f50d068ee"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"42be26bc06afeda24af37ff50609a3bab235d302","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    return facade.get_session(use_slave\u003duse_slave, **kwargs)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def get_api_session():"},{"line_number":147,"context_line":"    connection_str \u003d CONF.api_database.connection"},{"line_number":148,"context_line":"    facade \u003d _create_facade_lazily(_API_FACADE, connection_str)"},{"line_number":149,"context_line":"    return facade.get_session()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_113e42da","line":146,"in_reply_to":"9a80dd14_682a5191","updated":"2015-03-09 16:24:35.000000000","message":"Sure.  I didn\u0027t add it because nothing was passing any kwargs yet, but it could be nice for some consistency.","commit_id":"fa84dc48e86125970b506050ae2dc66f50d068ee"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"3bff77217a092182bfcd4579fb2eee52be556a63","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                \u0027get_session\u0027)"},{"line_number":994,"context_line":"        mock_facade.get_session.assert_called_once_with(use_slave\u003dFalse)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    @mock.patch.object(sqlalchemy_api, \u0027_create_facade\u0027)"},{"line_number":997,"context_line":"    def test_get_api_session(self, mock_create_facade):"},{"line_number":998,"context_line":"        self.assertEqual(None,"},{"line_number":999,"context_line":"                sqlalchemy_api._ENGINE_FACADE[sqlalchemy_api._API_FACADE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_abf0c3fe","line":996,"updated":"2015-03-08 07:30:40.000000000","message":"Should be _create_facade_lazily","commit_id":"fa84dc48e86125970b506050ae2dc66f50d068ee"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"3bff77217a092182bfcd4579fb2eee52be556a63","unresolved":false,"context_lines":[{"line_number":996,"context_line":"    @mock.patch.object(sqlalchemy_api, \u0027_create_facade\u0027)"},{"line_number":997,"context_line":"    def test_get_api_session(self, mock_create_facade):"},{"line_number":998,"context_line":"        self.assertEqual(None,"},{"line_number":999,"context_line":"                sqlalchemy_api._ENGINE_FACADE[sqlalchemy_api._API_FACADE])"},{"line_number":1000,"context_line":"        self.flags(connection\u003d\u0027get_api_session\u0027, group\u003d\u0027api_database\u0027)"},{"line_number":1001,"context_line":"        mock_facade \u003d mock.MagicMock()"},{"line_number":1002,"context_line":"        mock_create_facade.return_value \u003d mock_facade"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_0bdf0f6a","line":999,"updated":"2015-03-08 07:30:40.000000000","message":"nit: assertIsNone can be used","commit_id":"fa84dc48e86125970b506050ae2dc66f50d068ee"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"3bff77217a092182bfcd4579fb2eee52be556a63","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"        mock_create_facade.return_value \u003d mock_facade"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"        sqlalchemy_api.get_api_session()"},{"line_number":1005,"context_line":"        mock_create_facade.assert_called_once_with(\u0027get_api_session\u0027)"},{"line_number":1006,"context_line":"        self.assertEqual(mock_facade,"},{"line_number":1007,"context_line":"                sqlalchemy_api._ENGINE_FACADE[sqlalchemy_api._API_FACADE])"},{"line_number":1008,"context_line":"        self.assertEqual(None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8b077fc9","line":1005,"updated":"2015-03-08 07:30:40.000000000","message":"_API_FACADE is also an argument","commit_id":"fa84dc48e86125970b506050ae2dc66f50d068ee"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"3bff77217a092182bfcd4579fb2eee52be556a63","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        mock_create_facade.assert_called_once_with(\u0027get_api_session\u0027)"},{"line_number":1006,"context_line":"        self.assertEqual(mock_facade,"},{"line_number":1007,"context_line":"                sqlalchemy_api._ENGINE_FACADE[sqlalchemy_api._API_FACADE])"},{"line_number":1008,"context_line":"        self.assertEqual(None,"},{"line_number":1009,"context_line":"                sqlalchemy_api._ENGINE_FACADE[sqlalchemy_api._MAIN_FACADE])"},{"line_number":1010,"context_line":"        mock_facade.get_session.assert_called_once_with()"},{"line_number":1011,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ab0c43ee","line":1008,"updated":"2015-03-08 07:30:40.000000000","message":"nit: AssertIsNone","commit_id":"fa84dc48e86125970b506050ae2dc66f50d068ee"}]}