)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c234df5aff9d9b08bcb116b8a958caf76851ffb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yunhong jiang \u003cyunhong.jiang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-05 15:12:17 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check host cpu_info if no cpu_model for guest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When no cpu_model specified to guest, we should use host cpu_info to"},{"line_number":10,"context_line":"check for live migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_2e4a2126","line":7,"updated":"2015-03-08 09:35:33.000000000","message":"please prefix libvirt:","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c234df5aff9d9b08bcb116b8a958caf76851ffb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When no cpu_model specified to guest, we should use host cpu_info to"},{"line_number":10,"context_line":"check for live migration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Tony Walker found the bug and proposed the fix."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I410f53f6e54a698a48d8d5566ce192cda0365c98"},{"line_number":15,"context_line":"Related-Bug: 1082414"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_8e394da6","line":12,"updated":"2015-03-08 09:35:33.000000000","message":"Please add:\n\nCo-Authored-By: Tony Walker \u003chis email\u003e","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb0dc4f650bc421fecd335d63860bdcb6ff97080","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When no cpu_model specified to guest, we should use host cpu_info to"},{"line_number":10,"context_line":"check for live migration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Tony Walker found the bug and proposed the fix."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I410f53f6e54a698a48d8d5566ce192cda0365c98"},{"line_number":15,"context_line":"Related-Bug: 1082414"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_7f95bd85","line":12,"in_reply_to":"1a6ced46_df4f9169","updated":"2015-03-25 18:49:22.000000000","message":"I guess it was this:\n\nhttps://bugs.launchpad.net/nova/+bug/1082414/comments/29\n\nStill, no public email and it was 2012 so I\u0027d just omit this.","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aab95de61f99cee5368fa4df6da82bc3e4a696c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When no cpu_model specified to guest, we should use host cpu_info to"},{"line_number":10,"context_line":"check for live migration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Tony Walker found the bug and proposed the fix."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I410f53f6e54a698a48d8d5566ce192cda0365c98"},{"line_number":15,"context_line":"Related-Bug: 1082414"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_df4f9169","line":12,"in_reply_to":"9a80dd14_8e394da6","updated":"2015-03-25 18:47:36.000000000","message":"The guy doesn\u0027t have an email in launchpad.  I don\u0027t see a .patch file posted in LP so I\u0027d just remove this line.","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"21fa7e97b194363ae7456b9471e3707d0a089721","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Tony Walker found the bug and proposed the fix."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I410f53f6e54a698a48d8d5566ce192cda0365c98"},{"line_number":15,"context_line":"Related-Bug: 1082414"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_72b78185","line":15,"updated":"2015-03-20 10:20:22.000000000","message":"Bug 1433933 mentioned this also in the meantime.","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aab95de61f99cee5368fa4df6da82bc3e4a696c6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Tony Walker found the bug and proposed the fix."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I410f53f6e54a698a48d8d5566ce192cda0365c98"},{"line_number":15,"context_line":"Related-Bug: 1082414"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_5f3c81c8","line":15,"in_reply_to":"9a80dd14_72b78185","updated":"2015-03-25 18:47:36.000000000","message":"That bug was marked as a duplicate of this bug.","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c234df5aff9d9b08bcb116b8a958caf76851ffb","unresolved":false,"context_lines":[{"line_number":5846,"context_line":"                        matchers.DictMatches(return_value))"},{"line_number":5847,"context_line":""},{"line_number":5848,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5849,"context_line":"        \u0027_create_shared_storage_test_file\u0027)"},{"line_number":5850,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5851,"context_line":"        \u0027_compare_cpu\u0027)"},{"line_number":5852,"context_line":"    def test_check_can_live_migrate_guest_cpu_none_model("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0e4d5d3e","line":5849,"updated":"2015-03-08 09:35:33.000000000","message":"you can have return_value\u003d\u0027filename\u0027\nand save line 5861 and 5866","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c234df5aff9d9b08bcb116b8a958caf76851ffb","unresolved":false,"context_lines":[{"line_number":5848,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5849,"context_line":"        \u0027_create_shared_storage_test_file\u0027)"},{"line_number":5850,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5851,"context_line":"        \u0027_compare_cpu\u0027)"},{"line_number":5852,"context_line":"    def test_check_can_live_migrate_guest_cpu_none_model("},{"line_number":5853,"context_line":"            self, mock_cpu, mock_test_file):"},{"line_number":5854,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ae3e118a","line":5851,"updated":"2015-03-08 09:35:33.000000000","message":"you can use return_value\u003d1 here instead of line 5862","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67a2a188b617bb9a915f961a3c8932ef3923eb17","unresolved":false,"context_lines":[{"line_number":5848,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5849,"context_line":"        \u0027_create_shared_storage_test_file\u0027)"},{"line_number":5850,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":5851,"context_line":"        \u0027_compare_cpu\u0027)"},{"line_number":5852,"context_line":"    def test_check_can_live_migrate_guest_cpu_none_model("},{"line_number":5853,"context_line":"            self, mock_cpu, mock_test_file):"},{"line_number":5854,"context_line":"        instance_ref \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_dfb871ca","line":5851,"in_reply_to":"9a80dd14_ae3e118a","updated":"2015-03-25 19:09:01.000000000","message":"_compare_cpu doesn\u0027t actually return a value, it raises an exception if the compare fails.","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2898b46d7c9b098feab1113e7605fc684adad71d","unresolved":false,"context_lines":[{"line_number":4947,"context_line":"                    (disk_available_gb * units.Ki) - CONF.reserved_host_disk_mb"},{"line_number":4948,"context_line":""},{"line_number":4949,"context_line":"        # Compare CPU"},{"line_number":4950,"context_line":"        if not instance.vcpu_model or not instance.vcpu_model.model:"},{"line_number":4951,"context_line":"            source_cpu_info \u003d src_compute_info[\u0027cpu_info\u0027]"},{"line_number":4952,"context_line":"            self._compare_cpu(None, source_cpu_info)"},{"line_number":4953,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_bfec95f4","line":4950,"updated":"2015-03-25 18:57:50.000000000","message":"Looks like this should be OK:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/objects/vcpu_model.py#n36","commit_id":"a3ec067daba5f30953e0ae90a157b44e592661b2"}]}