)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"dee2b4bc1e8cee8c88a6b708edf3805e65c7ecea","unresolved":false,"context_lines":[{"line_number":13,"context_line":" assuming it\u0027s not on shared storage\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There is not need to do this as the base class can return None indicating"},{"line_number":16,"context_line":"that the opertaion is not supported. If the driver actually supports"},{"line_number":17,"context_line":"this, say for example as libvirt does, then it can override the method."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The patch removes unnecessary log warnings for something that is not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa041b7_781db7bc","line":16,"updated":"2015-04-01 21:00:30.000000000","message":"s/opertaion/operation/ :)","commit_id":"09ba3167dd492e75b6c702fd7de63bbdf3f42ecd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81546c72c48651f8553e52544895047ff5953e3c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027Hypervisor driver does not support instance shared storage check,"},{"line_number":13,"context_line":" assuming it\u0027s not on shared storage\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There is not need to do this as the base class can return None indicating"},{"line_number":16,"context_line":"that the opertaion is not supported. If the driver actually supports"},{"line_number":17,"context_line":"this, say for example as libvirt does, then it can override the method."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5ad0253b_75b0288c","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":12},"updated":"2015-04-28 16:00:21.000000000","message":"should be \"no\"","commit_id":"d3e86c9758b4ae01fb9994052e24c8b22d9dc997"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81546c72c48651f8553e52544895047ff5953e3c","unresolved":false,"context_lines":[{"line_number":13,"context_line":" assuming it\u0027s not on shared storage\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There is not need to do this as the base class can return None indicating"},{"line_number":16,"context_line":"that the opertaion is not supported. If the driver actually supports"},{"line_number":17,"context_line":"this, say for example as libvirt does, then it can override the method."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The patch removes unnecessary log warnings for something that is not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5ad0253b_15a7b450","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":18},"updated":"2015-04-28 16:00:21.000000000","message":"\"operation\" is misspelled","commit_id":"d3e86c9758b4ae01fb9994052e24c8b22d9dc997"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81546c72c48651f8553e52544895047ff5953e3c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The patch removes unnecessary log warnings for something that is not"},{"line_number":20,"context_line":"supported by most drivers."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"TrivialFix"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib6c5fabe2d3a4e17d322d00887b8e4b294541fca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5ad0253b_b86d95ce","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":10},"updated":"2015-04-28 16:00:21.000000000","message":"This is not a trivial fix, IMHO :)","commit_id":"d3e86c9758b4ae01fb9994052e24c8b22d9dc997"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f1ba2552327704fe6ff340a6d2913eef19bc428d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Virt: update shared storage log information message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The shared storage base methods in"},{"line_number":10,"context_line":"commit 52f6981aa35e27c48587ad2320891db8364edd02 raised NotImplemented."},{"line_number":11,"context_line":"This led to the following warning:"},{"line_number":12,"context_line":"\u0027Hypervisor driver does not support instance shared storage check,"},{"line_number":13,"context_line":" assuming it\u0027s not on shared storage\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5ad0253b_db35ebf7","line":10,"updated":"2015-04-28 16:39:28.000000000","message":"Not sure this part is really still relevant, but doesn\u0027t hurt.","commit_id":"3a6cfdfd0de49ba9eb5e2a01ed619cd942b006ad"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ffb01765a837f686d33013e1d7bb5d91d81796b9","unresolved":false,"context_lines":[{"line_number":869,"context_line":"                                  check_instance_shared_storage(context,"},{"line_number":870,"context_line":"                                  instance, data, host\u003dhost))"},{"line_number":871,"context_line":"        except NotImplementedError:"},{"line_number":872,"context_line":"            LOG.warning(_LW(\u0027Hypervisor driver does not support \u0027"},{"line_number":873,"context_line":"                            \u0027instance shared storage check, \u0027"},{"line_number":874,"context_line":"                            \u0027assuming it\\\u0027s not on shared storage\u0027),"},{"line_number":875,"context_line":"                        instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_58e4410c","side":"PARENT","line":872,"updated":"2015-04-28 16:06:44.000000000","message":"This doesn\u0027t need to be a warning, just change to info or debug level and be done with it, we don\u0027t need all of the other changes as Dan pointed out.  It\u0027s definitely not a warning to not support a thing.","commit_id":"93610787de148c4bb01f2b9ee903c2d7e27e172a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81546c72c48651f8553e52544895047ff5953e3c","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                                  instance, data, host\u003dhost))"},{"line_number":871,"context_line":"        except Exception:"},{"line_number":872,"context_line":"            LOG.exception(_LE(\u0027Failed to check if instance shared\u0027),"},{"line_number":873,"context_line":"                          instance\u003dinstance)"},{"line_number":874,"context_line":"        finally:"},{"line_number":875,"context_line":"            if data:"},{"line_number":876,"context_line":"                self.driver.check_instance_shared_storage_cleanup(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_352f50a3","line":873,"updated":"2015-04-28 16:00:21.000000000","message":"This change is unrelated to the rest of the patch.","commit_id":"d3e86c9758b4ae01fb9994052e24c8b22d9dc997"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81546c72c48651f8553e52544895047ff5953e3c","unresolved":false,"context_lines":[{"line_number":6695,"context_line":""},{"line_number":6696,"context_line":"        self.mox.ReplayAll()"},{"line_number":6697,"context_line":"        self.compute._destroy_evacuated_instances(fake_context)"},{"line_number":6698,"context_line":""},{"line_number":6699,"context_line":"    def test_complete_partial_deletion(self):"},{"line_number":6700,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":6701,"context_line":"        instance \u003d objects.Instance()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_3834e5dc","side":"PARENT","line":6698,"updated":"2015-04-28 16:00:21.000000000","message":"Why are you removing this test? Shouldn\u0027t you just change the raise to a return None?","commit_id":"93610787de148c4bb01f2b9ee903c2d7e27e172a"}]}