)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e7f959d0415c96a93f0e7d928f88d2e72de8590c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update to return the correct esx iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector is the first ESX\u0027s connector info;"},{"line_number":10,"context_line":"Now update to return the connector info of the host running the VM."},{"line_number":11,"context_line":"Closes-Bug: #1429581"},{"line_number":12,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aca2d91_15204247","line":9,"updated":"2015-05-09 15:34:32.000000000","message":"Commit message line widths too long.\n\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ebb4f9d9b285c7d05a96530dbd5f7196e3cdaae6"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"5d3ee95dbd350c870731d281073a018d9d197da7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update to return the correct esx iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector is the first ESX\u0027s connector info;"},{"line_number":10,"context_line":"Now update to return the connector info of the host running the VM."},{"line_number":11,"context_line":"Closes-Bug: #1429581"},{"line_number":12,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9af37de9_cf7d1de9","line":9,"in_reply_to":"1aca2d91_15204247","updated":"2015-05-09 19:34:54.000000000","message":"ok","commit_id":"ebb4f9d9b285c7d05a96530dbd5f7196e3cdaae6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9a8ed835d1ea41768933ee4021126117745e1e49","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     javeme \u003cjavaloveme@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-10 03:49:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update to return the correct esx iqn."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info, Now update to return the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9af37de9_ecf22206","line":7,"updated":"2015-05-11 03:34:05.000000000","message":"VMware: Update to return the correct ESX iqn.","commit_id":"69d7fe0f2008037f66b8ff9360a445ee56f45f56"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"1d3534c7b0544943e01f18c3b15c739991a8e752","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     javeme \u003cjavaloveme@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-10 03:49:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update to return the correct esx iqn."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info, Now update to return the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9af37de9_237cab71","line":7,"in_reply_to":"9af37de9_ecf22206","updated":"2015-05-11 13:51:03.000000000","message":"Done","commit_id":"69d7fe0f2008037f66b8ff9360a445ee56f45f56"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9a8ed835d1ea41768933ee4021126117745e1e49","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update to return the correct esx iqn."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info, Now update to return the"},{"line_number":11,"context_line":"connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"},{"line_number":13,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9af37de9_8cda7677","line":10,"updated":"2015-05-11 03:34:05.000000000","message":"info.  This will update it to return the","commit_id":"69d7fe0f2008037f66b8ff9360a445ee56f45f56"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"1d3534c7b0544943e01f18c3b15c739991a8e752","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update to return the correct esx iqn."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info, Now update to return the"},{"line_number":11,"context_line":"connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"},{"line_number":13,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9af37de9_c3939fa2","line":10,"in_reply_to":"9af37de9_8cda7677","updated":"2015-05-11 13:51:03.000000000","message":"Done","commit_id":"69d7fe0f2008037f66b8ff9360a445ee56f45f56"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"fdd54369738451774bf67c6e36919758686c2a0f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Update to return the correct ESX iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info. This will update it to return"},{"line_number":11,"context_line":"the connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a0c5dc1_0a308500","line":9,"updated":"2015-05-13 03:45:26.000000000","message":"By default, the return value...","commit_id":"7905f5a781cd2ae7c4092bb921f039fe2c879b3c"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"9a2b864bfb6aaeb83c225e3dbd19add34e2beae3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Update to return the correct ESX iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info. This will update it to return"},{"line_number":11,"context_line":"the connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a0c5dc1_1793095d","line":9,"in_reply_to":"9a0c5dc1_0a308500","updated":"2015-05-13 13:50:24.000000000","message":"Thanks for your advice.","commit_id":"7905f5a781cd2ae7c4092bb921f039fe2c879b3c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"fdd54369738451774bf67c6e36919758686c2a0f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Update to return the correct ESX iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info. This will update it to return"},{"line_number":11,"context_line":"the connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"},{"line_number":13,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a0c5dc1_ca182d87","line":10,"updated":"2015-05-13 03:45:26.000000000","message":"s/connector/connection.  This patch will update...","commit_id":"7905f5a781cd2ae7c4092bb921f039fe2c879b3c"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"9a2b864bfb6aaeb83c225e3dbd19add34e2beae3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Update to return the correct ESX iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info. This will update it to return"},{"line_number":11,"context_line":"the connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"},{"line_number":13,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a0c5dc1_b788bd23","line":10,"in_reply_to":"9a0c5dc1_ca182d87","updated":"2015-05-13 13:50:24.000000000","message":"ok","commit_id":"7905f5a781cd2ae7c4092bb921f039fe2c879b3c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"fdd54369738451774bf67c6e36919758686c2a0f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info. This will update it to return"},{"line_number":11,"context_line":"the connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"},{"line_number":13,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a0c5dc1_aa1df974","line":12,"updated":"2015-05-13 03:45:26.000000000","message":"Add a new line above this line","commit_id":"7905f5a781cd2ae7c4092bb921f039fe2c879b3c"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"9a2b864bfb6aaeb83c225e3dbd19add34e2beae3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connector info. This will update it to return"},{"line_number":11,"context_line":"the connector info of the host running the VM."},{"line_number":12,"context_line":"Closes-Bug: #1429581"},{"line_number":13,"context_line":"Change-Id: Iac4f199632a0196f7cb8e1e50b7c7c4bb285d97d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a0c5dc1_978db933","line":12,"in_reply_to":"9a0c5dc1_aa1df974","updated":"2015-05-13 13:50:24.000000000","message":"ok","commit_id":"7905f5a781cd2ae7c4092bb921f039fe2c879b3c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4771c0bb76009324bfb3b232b32394c89d81decd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Update to return the correct ESX iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connection info. This patch will update it"},{"line_number":11,"context_line":"to return the connection info of the host running the VM."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a016987_78020d71","line":9,"updated":"2015-05-17 03:50:20.000000000","message":"s/returning/return","commit_id":"2cc0c8b5afef174ae1ae6df6ad0b58ed6906e5b5"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"a3412863f6913dcb0d3532bb63c59787dbf3593b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Update to return the correct ESX iqn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default, the returning value of method get_volume_connector"},{"line_number":10,"context_line":"is the first ESX\u0027s connection info. This patch will update it"},{"line_number":11,"context_line":"to return the connection info of the host running the VM."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a016987_fd45446e","line":9,"in_reply_to":"7a016987_78020d71","updated":"2015-05-23 12:48:22.000000000","message":"Done","commit_id":"2cc0c8b5afef174ae1ae6df6ad0b58ed6906e5b5"}],"nova/tests/unit/virt/vmwareapi/test_volumeops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            vmdk_path\u003dnew_file_name)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_iscsi_get_host_iqn(self):"},{"line_number":326,"context_line":"        session \u003d self._volumeops._session"},{"line_number":327,"context_line":"        instance \u003d self._instance"},{"line_number":328,"context_line":"        host_mor \u003d mock.Mock()"},{"line_number":329,"context_line":"        iqn \u003d \u0027iscsi-name\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_2a5e8d12","line":326,"updated":"2015-05-13 16:14:22.000000000","message":"not clear why we need these localvariables - session and instance","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"fc94455ff054c0b0e1eccce9c9199615035dbcea","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            vmdk_path\u003dnew_file_name)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def test_iscsi_get_host_iqn(self):"},{"line_number":326,"context_line":"        session \u003d self._volumeops._session"},{"line_number":327,"context_line":"        instance \u003d self._instance"},{"line_number":328,"context_line":"        host_mor \u003d mock.Mock()"},{"line_number":329,"context_line":"        iqn \u003d \u0027iscsi-name\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_10e1b89a","line":326,"in_reply_to":"9a0c5dc1_2a5e8d12","updated":"2015-05-14 16:00:17.000000000","message":"Thank you for your review.\nI define  these local variables because they have been used in many places: line 336, line 341...","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            mock.patch.object(session, \u0027_call_method\u0027,"},{"line_number":337,"context_line":"                              return_value\u003dhbas)"},{"line_number":338,"context_line":"        ) as (get_host_ref_for_vm, call_method):"},{"line_number":339,"context_line":"            val \u003d self._volumeops._iscsi_get_host_iqn(instance)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"            get_host_ref_for_vm.assert_called_once_with(session, instance)"},{"line_number":342,"context_line":"            call_method.assert_called_once_with(vim_util,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_8a4c5943","line":339,"updated":"2015-05-13 16:14:22.000000000","message":"can you please add a test for when the instance is not found (you added the code for  except exception.InstanceNotFound)","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"fc94455ff054c0b0e1eccce9c9199615035dbcea","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            mock.patch.object(session, \u0027_call_method\u0027,"},{"line_number":337,"context_line":"                              return_value\u003dhbas)"},{"line_number":338,"context_line":"        ) as (get_host_ref_for_vm, call_method):"},{"line_number":339,"context_line":"            val \u003d self._volumeops._iscsi_get_host_iqn(instance)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"            get_host_ref_for_vm.assert_called_once_with(session, instance)"},{"line_number":342,"context_line":"            call_method.assert_called_once_with(vim_util,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_b1ad8933","line":339,"in_reply_to":"9a0c5dc1_8a4c5943","updated":"2015-05-14 16:00:17.000000000","message":"ok","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            self.assertEqual(iqn, val)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def test_get_volume_connector(self):"},{"line_number":350,"context_line":"        instance \u003d self._instance"},{"line_number":351,"context_line":"        vm_id \u003d \u0027fack-vm\u0027"},{"line_number":352,"context_line":"        vm_ref \u003d mock.MagicMock(value\u003dvm_id)"},{"line_number":353,"context_line":"        iqn \u003d \u0027iscsi-name\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_ea851559","line":350,"updated":"2015-05-13 16:14:22.000000000","message":"ditto","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def test_get_volume_connector(self):"},{"line_number":350,"context_line":"        instance \u003d self._instance"},{"line_number":351,"context_line":"        vm_id \u003d \u0027fack-vm\u0027"},{"line_number":352,"context_line":"        vm_ref \u003d mock.MagicMock(value\u003dvm_id)"},{"line_number":353,"context_line":"        iqn \u003d \u0027iscsi-name\u0027"},{"line_number":354,"context_line":"        url \u003d \u0027test_url\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_aa7f1d65","line":351,"updated":"2015-05-13 16:14:22.000000000","message":"fack \u003d\u003e fake","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"fc94455ff054c0b0e1eccce9c9199615035dbcea","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def test_get_volume_connector(self):"},{"line_number":350,"context_line":"        instance \u003d self._instance"},{"line_number":351,"context_line":"        vm_id \u003d \u0027fack-vm\u0027"},{"line_number":352,"context_line":"        vm_ref \u003d mock.MagicMock(value\u003dvm_id)"},{"line_number":353,"context_line":"        iqn \u003d \u0027iscsi-name\u0027"},{"line_number":354,"context_line":"        url \u003d \u0027test_url\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_5085f0aa","line":351,"in_reply_to":"9a0c5dc1_aa7f1d65","updated":"2015-05-14 16:00:17.000000000","message":"ok, thank you.","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                                               instance)"},{"line_number":366,"context_line":"            iscsi_get_host_iqn.assert_called_once_with(instance)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"            self.assertEqual(connector[\u0027ip\u0027], url)"},{"line_number":369,"context_line":"            self.assertEqual(connector[\u0027host\u0027], url)"},{"line_number":370,"context_line":"            self.assertEqual(connector[\u0027initiator\u0027], iqn)"},{"line_number":371,"context_line":"            self.assertEqual(connector[\u0027instance\u0027], vm_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_4ae8a110","line":368,"updated":"2015-05-13 16:14:22.000000000","message":"the expected parameter should be first","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"fc94455ff054c0b0e1eccce9c9199615035dbcea","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                                               instance)"},{"line_number":366,"context_line":"            iscsi_get_host_iqn.assert_called_once_with(instance)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"            self.assertEqual(connector[\u0027ip\u0027], url)"},{"line_number":369,"context_line":"            self.assertEqual(connector[\u0027host\u0027], url)"},{"line_number":370,"context_line":"            self.assertEqual(connector[\u0027initiator\u0027], iqn)"},{"line_number":371,"context_line":"            self.assertEqual(connector[\u0027instance\u0027], vm_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_b0b66c88","line":368,"in_reply_to":"9a0c5dc1_4ae8a110","updated":"2015-05-14 16:00:17.000000000","message":"ok, thank you.","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            iscsi_get_host_iqn.assert_called_once_with(instance)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"            self.assertEqual(connector[\u0027ip\u0027], url)"},{"line_number":369,"context_line":"            self.assertEqual(connector[\u0027host\u0027], url)"},{"line_number":370,"context_line":"            self.assertEqual(connector[\u0027initiator\u0027], iqn)"},{"line_number":371,"context_line":"            self.assertEqual(connector[\u0027instance\u0027], vm_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_4a5661d3","line":369,"updated":"2015-05-13 16:14:22.000000000","message":"ditto","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"            self.assertEqual(connector[\u0027ip\u0027], url)"},{"line_number":369,"context_line":"            self.assertEqual(connector[\u0027host\u0027], url)"},{"line_number":370,"context_line":"            self.assertEqual(connector[\u0027initiator\u0027], iqn)"},{"line_number":371,"context_line":"            self.assertEqual(connector[\u0027instance\u0027], vm_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_ea6195a9","line":370,"updated":"2015-05-13 16:14:22.000000000","message":"ditto","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98870b157734c41af9e5034fa7930e26d53e41be","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            self.assertEqual(connector[\u0027ip\u0027], url)"},{"line_number":369,"context_line":"            self.assertEqual(connector[\u0027host\u0027], url)"},{"line_number":370,"context_line":"            self.assertEqual(connector[\u0027initiator\u0027], iqn)"},{"line_number":371,"context_line":"            self.assertEqual(connector[\u0027instance\u0027], vm_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_8a733980","line":371,"updated":"2015-05-13 16:14:22.000000000","message":"ditto","commit_id":"9804cb711d01e5f331ceb46c73a8894e6df02165"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"6efae58692699e4bac85382b5ecde96552ba6bdb","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            mock.patch.object(self._volumeops, \u0027_iscsi_get_host_iqn\u0027,"},{"line_number":387,"context_line":"                              return_value\u003diqn)"},{"line_number":388,"context_line":"        ) as (fake_get_vm_ref,"},{"line_number":389,"context_line":"              fake_iscsi_get_host_iqn):"},{"line_number":390,"context_line":"            connector \u003d self._volumeops.get_volume_connector(self._instance)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            fake_get_vm_ref.assert_called_once_with(self._volumeops._session,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_1231cd0b","line":389,"updated":"2015-07-12 03:11:50.000000000","message":"this can move up on the same line above","commit_id":"cdf73658c1605da67944236d88e258c330aacbe7"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"bdcc0498917f2cf543b06ddc93a1e910b5021a27","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            mock.patch.object(self._volumeops, \u0027_iscsi_get_host_iqn\u0027,"},{"line_number":387,"context_line":"                              return_value\u003diqn)"},{"line_number":388,"context_line":"        ) as (fake_get_vm_ref,"},{"line_number":389,"context_line":"              fake_iscsi_get_host_iqn):"},{"line_number":390,"context_line":"            connector \u003d self._volumeops.get_volume_connector(self._instance)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            fake_get_vm_ref.assert_called_once_with(self._volumeops._session,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_f17175a9","line":389,"in_reply_to":"9a41bdd9_1231cd0b","updated":"2015-08-28 03:19:30.000000000","message":"ok","commit_id":"cdf73658c1605da67944236d88e258c330aacbe7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ccd5d124c5c218ea37225ec8b294fe39dd7e4533","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        hba \u003d vmwareapi_fake.HostInternetScsiHba(iqn)"},{"line_number":447,"context_line":"        hbas \u003d mock.MagicMock(HostHostBusAdapter\u003d[hba])"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        with contextlib.nested("},{"line_number":450,"context_line":"            mock.patch.object(vm_util, \u0027get_host_ref_for_vm\u0027,"},{"line_number":451,"context_line":"                              return_value\u003dhost_mor),"},{"line_number":452,"context_line":"            mock.patch.object(self._volumeops._session, \u0027_call_method\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"da20952f_cf77c1d2","line":449,"updated":"2015-09-10 22:48:21.000000000","message":"contextlib.nested isn\u0027t available in python3 and causes indentation issues as seen here.\n\nI recommend creating a test method, decorating it and calling it, for example:\n\n @mock.patch.object(vm_util, \u0027get_host_ref_for_vm\u0027, return_value\u003dhost_mor)\n @mock.patch.object(self._volumeops._session, \u0027_call_method\u0027, return_value\u003dhbas)\n def do_test(fake_call_method, fake_get_host_ref_for_vm):\n     ...\n do_test()","commit_id":"1e457566210559650b37095f9086557ffbf694e8"}]}