)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4b89c3b3ed63f022487d587956fcab8833b49d13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"create and populate allocated resources DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"needed by the scheduler defined in the blueprint:"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/simple-allocation-scheduler"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Created a script to update the compute_node table of the"},{"line_number":13,"context_line":"DB with the allocated values (version 058)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAACn%2F%2F%2BQk%3D","line":10,"updated":"2011-11-15 19:19:22.000000000","message":"I believe there\u0027s support for turning the text \"blueprint simple-allocation-scheduler\" into an actual link to the blueprint; something to keep in mind for future submissions.  (As it stands right now, this link doesn\u0027t come through as clickable.)\n\n(Just a point of information, not an action item.)","commit_id":"b1aa19f37e60e3f1b3d8ab2b3daa36601c4f2d0a"}],"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4b89c3b3ed63f022487d587956fcab8833b49d13","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_compute_node(self):"},{"line_number":165,"context_line":"        \"\"\"getting the compute_node ref, throws ComputeServiceUnavailable if"},{"line_number":166,"context_line":"        service or compute node not found.\"\"\""},{"line_number":167,"context_line":"        ctxt \u003d nova.context.get_admin_context()"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            service_ref \u003d self.db.service_get_all_compute_by_host(ctxt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BQg%3D","line":166,"updated":"2011-11-15 19:19:22.000000000","message":"Please read HACKING and update your doc strings accordingly.","commit_id":"b1aa19f37e60e3f1b3d8ab2b3daa36601c4f2d0a"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"af1cd3d22577aba835f0d79b5a9baec85aadc967","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_compute_node(self):"},{"line_number":165,"context_line":"        \"\"\"getting the compute_node ref, throws ComputeServiceUnavailable if"},{"line_number":166,"context_line":"        service or compute node not found.\"\"\""},{"line_number":167,"context_line":"        ctxt \u003d nova.context.get_admin_context()"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            service_ref \u003d self.db.service_get_all_compute_by_host(ctxt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F9qs%3D","line":166,"in_reply_to":"AAAACn%2F%2F%2BQg%3D","updated":"2011-11-17 15:05:10.000000000","message":"Done","commit_id":"b1aa19f37e60e3f1b3d8ab2b3daa36601c4f2d0a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4b89c3b3ed63f022487d587956fcab8833b49d13","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if compute_node_ref is not None:"},{"line_number":194,"context_line":"            # creating the dict to update with the new values"},{"line_number":195,"context_line":"            dic \u003d {}"},{"line_number":196,"context_line":"            if vcpus_allocated !\u003d 0:"},{"line_number":197,"context_line":"                dic[\u0027vcpus_allocated\u0027] \u003d \\"},{"line_number":198,"context_line":"                compute_node_ref[\u0027vcpus_allocated\u0027] + vcpus_allocated"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2BQc%3D","line":195,"updated":"2011-11-15 19:19:22.000000000","message":"I\u0027d really prefer if you came up with a more descriptive variable name; maybe \"updated_values\"?","commit_id":"b1aa19f37e60e3f1b3d8ab2b3daa36601c4f2d0a"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"af1cd3d22577aba835f0d79b5a9baec85aadc967","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if compute_node_ref is not None:"},{"line_number":194,"context_line":"            # creating the dict to update with the new values"},{"line_number":195,"context_line":"            dic \u003d {}"},{"line_number":196,"context_line":"            if vcpus_allocated !\u003d 0:"},{"line_number":197,"context_line":"                dic[\u0027vcpus_allocated\u0027] \u003d \\"},{"line_number":198,"context_line":"                compute_node_ref[\u0027vcpus_allocated\u0027] + vcpus_allocated"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F9qg%3D","line":195,"in_reply_to":"AAAACn%2F%2F%2BQc%3D","updated":"2011-11-17 15:05:10.000000000","message":"Done","commit_id":"b1aa19f37e60e3f1b3d8ab2b3daa36601c4f2d0a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return compute_node_ref[0]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def allocate_resources(self, context, instance_id, N\u003d1):"},{"line_number":184,"context_line":"        \"\"\"Update allocated resources in the compute node in the DB."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        Adding the instance resources values to the current allocated values"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9nI%3D","line":183,"updated":"2011-11-17 17:26:33.000000000","message":"Variables should be lowercase, even this one.  It would probably also be better to make the variable name longer; perhaps \"incr\" instead of \"N\"","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return compute_node_ref[0]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def allocate_resources(self, context, instance_id, N\u003d1):"},{"line_number":184,"context_line":"        \"\"\"Update allocated resources in the compute node in the DB."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        Adding the instance resources values to the current allocated values"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bY%3D","line":183,"in_reply_to":"AAAACn%2F%2F9nI%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            instance[\u0027local_gb\u0027] \u003d\u003d 0):"},{"line_number":199,"context_line":"            return"},{"line_number":200,"context_line":"        compute_node \u003d self._get_compute_node()"},{"line_number":201,"context_line":"        # add or substract instance resources to/from allocated values:"},{"line_number":202,"context_line":"        # creating the dictionary to update with the new values"},{"line_number":203,"context_line":"        to_allocate \u003d {\u0027vcpus_allocated\u0027:"},{"line_number":204,"context_line":"            compute_node[\u0027vcpus_allocated\u0027] + N * instance[\u0027vcpus\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9nE%3D","line":201,"updated":"2011-11-17 17:26:33.000000000","message":"The correct spelling is \"subtract\"","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            instance[\u0027local_gb\u0027] \u003d\u003d 0):"},{"line_number":199,"context_line":"            return"},{"line_number":200,"context_line":"        compute_node \u003d self._get_compute_node()"},{"line_number":201,"context_line":"        # add or substract instance resources to/from allocated values:"},{"line_number":202,"context_line":"        # creating the dictionary to update with the new values"},{"line_number":203,"context_line":"        to_allocate \u003d {\u0027vcpus_allocated\u0027:"},{"line_number":204,"context_line":"            compute_node[\u0027vcpus_allocated\u0027] + N * instance[\u0027vcpus\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bU%3D","line":201,"in_reply_to":"AAAACn%2F%2F9nE%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":2018,"context_line":"                alloc[\u0027memory_mb_allocated\u0027] +\u003d db_instance[\u0027memory_mb\u0027]"},{"line_number":2019,"context_line":"                alloc[\u0027local_gb_allocated\u0027] +\u003d db_instance[\u0027local_gb\u0027]"},{"line_number":2020,"context_line":""},{"line_number":2021,"context_line":"        # correct allocated values if necesasry:"},{"line_number":2022,"context_line":"        try:"},{"line_number":2023,"context_line":"            node \u003d self._get_compute_node()"},{"line_number":2024,"context_line":"            if(alloc[\u0027vcpus_allocated\u0027] !\u003d node[\u0027vcpus_allocated\u0027] or"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9nA%3D","line":2021,"updated":"2011-11-17 17:26:33.000000000","message":"\"necessary\"","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":2018,"context_line":"                alloc[\u0027memory_mb_allocated\u0027] +\u003d db_instance[\u0027memory_mb\u0027]"},{"line_number":2019,"context_line":"                alloc[\u0027local_gb_allocated\u0027] +\u003d db_instance[\u0027local_gb\u0027]"},{"line_number":2020,"context_line":""},{"line_number":2021,"context_line":"        # correct allocated values if necesasry:"},{"line_number":2022,"context_line":"        try:"},{"line_number":2023,"context_line":"            node \u003d self._get_compute_node()"},{"line_number":2024,"context_line":"            if(alloc[\u0027vcpus_allocated\u0027] !\u003d node[\u0027vcpus_allocated\u0027] or"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bQ%3D","line":2021,"in_reply_to":"AAAACn%2F%2F9nA%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"            if(alloc[\u0027vcpus_allocated\u0027] !\u003d node[\u0027vcpus_allocated\u0027] or"},{"line_number":2025,"context_line":"               alloc[\u0027memory_mb_allocated\u0027] !\u003d node[\u0027memory_mb_allocated\u0027] or"},{"line_number":2026,"context_line":"               alloc[\u0027local_gb_allocated\u0027] !\u003d node[\u0027local_gb_allocated\u0027]):"},{"line_number":2027,"context_line":"                LOG.warn(_(\"compute node allocated resources values do not \""},{"line_number":2028,"context_line":"                           \"match the real values. Updating compute node \""},{"line_number":2029,"context_line":"                           \"table in DB.\"))"},{"line_number":2030,"context_line":"                self.db.compute_node_update(nova.context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9m4%3D","line":2027,"updated":"2011-11-17 17:26:33.000000000","message":"I\u0027d really prefer that this be capitalized properly, i.e., \"Compute node allocated [...]\"","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"            if(alloc[\u0027vcpus_allocated\u0027] !\u003d node[\u0027vcpus_allocated\u0027] or"},{"line_number":2025,"context_line":"               alloc[\u0027memory_mb_allocated\u0027] !\u003d node[\u0027memory_mb_allocated\u0027] or"},{"line_number":2026,"context_line":"               alloc[\u0027local_gb_allocated\u0027] !\u003d node[\u0027local_gb_allocated\u0027]):"},{"line_number":2027,"context_line":"                LOG.warn(_(\"compute node allocated resources values do not \""},{"line_number":2028,"context_line":"                           \"match the real values. Updating compute node \""},{"line_number":2029,"context_line":"                           \"table in DB.\"))"},{"line_number":2030,"context_line":"                self.db.compute_node_update(nova.context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bM%3D","line":2027,"in_reply_to":"AAAACn%2F%2F9m4%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":2030,"context_line":"                self.db.compute_node_update(nova.context.get_admin_context(),"},{"line_number":2031,"context_line":"                                node[\u0027id\u0027], alloc)"},{"line_number":2032,"context_line":"        except exception.ComputeServiceUnavailable as ex:"},{"line_number":2033,"context_line":"            LOG.error(\"Compute Node not available!. Exception \u003d \""},{"line_number":2034,"context_line":"                      \"%(ex)s\" % locals())"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    def _reclaim_queued_deletes(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9m8%3D","line":2033,"updated":"2011-11-17 17:26:33.000000000","message":"You missed internationalization on this one.  Also, the exclamation point is unnecessary and should be removed.","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":2030,"context_line":"                self.db.compute_node_update(nova.context.get_admin_context(),"},{"line_number":2031,"context_line":"                                node[\u0027id\u0027], alloc)"},{"line_number":2032,"context_line":"        except exception.ComputeServiceUnavailable as ex:"},{"line_number":2033,"context_line":"            LOG.error(\"Compute Node not available!. Exception \u003d \""},{"line_number":2034,"context_line":"                      \"%(ex)s\" % locals())"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    def _reclaim_queued_deletes(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bI%3D","line":2033,"in_reply_to":"AAAACn%2F%2F9m8%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f2937abd7e2afc9f23d5cc9aac00a4b324ce27c4","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            self._run_instance(context, instance_id, **kwargs)"},{"line_number":561,"context_line":"        except Exception as ex:"},{"line_number":562,"context_line":"            # If there is any exception during this process, deallocate"},{"line_number":563,"context_line":"            self.allocate_resources(context, instance_id, incr\u003d-1)"},{"line_number":564,"context_line":"            raise ex"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAACn%2F%2F9YY%3D","line":563,"updated":"2011-11-18 16:19:55.000000000","message":"I think you can do this as a try/finally instead of a try/except.  That has a couple of benefits: first, you don\u0027t need to re-raise the exception; and second, we don\u0027t lose the stack trace due to the re-raise.","commit_id":"1d3aa29be4b39b89a815406b36d38c5e76b12dc0"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"dd79d46debcc0e26081f8bec87bfb3597fafe56b","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            self._run_instance(context, instance_id, **kwargs)"},{"line_number":561,"context_line":"        except Exception as ex:"},{"line_number":562,"context_line":"            # If there is any exception during this process, deallocate"},{"line_number":563,"context_line":"            self.allocate_resources(context, instance_id, incr\u003d-1)"},{"line_number":564,"context_line":"            raise ex"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAACn%2F%2F9Js%3D","line":563,"in_reply_to":"AAAACn%2F%2F9YY%3D","updated":"2011-11-21 10:37:35.000000000","message":"We want to deallocate the resources only if there is any problem during _run_instance. If the method succeeds we don\u0027t want to deallocate the resources, so we can\u0027t put the code under a finally.\nWhat I did instead of try/finally is to use a utils.save_and_reraise_exception (the same mechanism that is used by the _cleanup() method). I hope it\u0027s a better solution than simply re-raising the exception!","commit_id":"1d3aa29be4b39b89a815406b36d38c5e76b12dc0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f2937abd7e2afc9f23d5cc9aac00a4b324ce27c4","unresolved":false,"context_lines":[{"line_number":633,"context_line":"    def terminate_instance(self, context, instance_id):"},{"line_number":634,"context_line":"        \"\"\"Terminate an instance on this host.\"\"\""},{"line_number":635,"context_line":"        self.allocate_resources(context, instance_id, incr\u003d-1)"},{"line_number":636,"context_line":"        #generate usage info."},{"line_number":637,"context_line":"        instance \u003d self.db.instance_get(context.elevated(), instance_id)"},{"line_number":638,"context_line":"        notify_usage_exists(instance, current_period\u003dTrue)"},{"line_number":639,"context_line":"        self._delete_instance(context, instance_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAACn%2F%2F9YU%3D","line":636,"updated":"2011-11-18 16:19:55.000000000","message":"Would you mind updating this comment while you\u0027re here?  Just adding a space after the \u0027#\u0027 and capitalizing it.  Not a requirement, mind you...","commit_id":"1d3aa29be4b39b89a815406b36d38c5e76b12dc0"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"dd79d46debcc0e26081f8bec87bfb3597fafe56b","unresolved":false,"context_lines":[{"line_number":633,"context_line":"    def terminate_instance(self, context, instance_id):"},{"line_number":634,"context_line":"        \"\"\"Terminate an instance on this host.\"\"\""},{"line_number":635,"context_line":"        self.allocate_resources(context, instance_id, incr\u003d-1)"},{"line_number":636,"context_line":"        #generate usage info."},{"line_number":637,"context_line":"        instance \u003d self.db.instance_get(context.elevated(), instance_id)"},{"line_number":638,"context_line":"        notify_usage_exists(instance, current_period\u003dTrue)"},{"line_number":639,"context_line":"        self._delete_instance(context, instance_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAACn%2F%2F9Jw%3D","line":636,"in_reply_to":"AAAACn%2F%2F9YU%3D","updated":"2011-11-21 10:37:35.000000000","message":"Done","commit_id":"1d3aa29be4b39b89a815406b36d38c5e76b12dc0"}],"nova/db/sqlalchemy/migrate_repo/versions/059_add_allocated_fields_compute_nodes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                        db_schema.Column(\"id\", sql_types.Integer(),"},{"line_number":25,"context_line":"                        primary_key\u003dTrue))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#Add vcpus_allocated column to compute_nodes table"},{"line_number":28,"context_line":"vcpus_allocated \u003d db_schema.Column(\u0027vcpus_allocated\u0027,\\"},{"line_number":29,"context_line":"                         sql_types.Integer(), default\u003d0)"},{"line_number":30,"context_line":"#Add memory_allocated column to compute_nodes table"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9m0%3D","line":27,"updated":"2011-11-17 17:26:33.000000000","message":"You need to have a space after the \u0027#\u0027 character here.","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                        db_schema.Column(\"id\", sql_types.Integer(),"},{"line_number":25,"context_line":"                        primary_key\u003dTrue))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#Add vcpus_allocated column to compute_nodes table"},{"line_number":28,"context_line":"vcpus_allocated \u003d db_schema.Column(\u0027vcpus_allocated\u0027,\\"},{"line_number":29,"context_line":"                         sql_types.Integer(), default\u003d0)"},{"line_number":30,"context_line":"#Add memory_allocated column to compute_nodes table"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bE%3D","line":27,"in_reply_to":"AAAACn%2F%2F9m0%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"}],"nova/tests/test_compute_utils.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bfbabb1096e1938027bb3f30b4ec4e078d8cf8d3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        service and the corresponding compute node.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":87,"context_line":"        dic \u003d {\u0027binary\u0027: \u0027nova-compute\u0027, \u0027topic\u0027: \u0027compute\u0027,"},{"line_number":88,"context_line":"               \u0027report_count\u0027: 0, \u0027availability_zone\u0027: \u0027dummyzone\u0027}"},{"line_number":89,"context_line":"        dic[\u0027host\u0027] \u003d kwargs.get(\u0027host\u0027, \u0027dummy\u0027)"},{"line_number":90,"context_line":"        s_ref \u003d db.service_create(ctxt, dic)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9mw%3D","line":87,"updated":"2011-11-17 17:26:33.000000000","message":"I\u0027d really prefer a more descriptive variable name here; something like \u0027compute\u0027 would probably work.","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"},{"author":{"_account_id":1861,"name":"david-perez5","username":"david-perez5"},"change_message_id":"279eb40751cd705336ed4ae662babd27856b0c3a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        service and the corresponding compute node.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":87,"context_line":"        dic \u003d {\u0027binary\u0027: \u0027nova-compute\u0027, \u0027topic\u0027: \u0027compute\u0027,"},{"line_number":88,"context_line":"               \u0027report_count\u0027: 0, \u0027availability_zone\u0027: \u0027dummyzone\u0027}"},{"line_number":89,"context_line":"        dic[\u0027host\u0027] \u003d kwargs.get(\u0027host\u0027, \u0027dummy\u0027)"},{"line_number":90,"context_line":"        s_ref \u003d db.service_create(ctxt, dic)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F9bA%3D","line":87,"in_reply_to":"AAAACn%2F%2F9mw%3D","updated":"2011-11-18 10:20:47.000000000","message":"Done","commit_id":"ee9fed01df9582284feb471b9ccd06b3f0d84dbf"}]}